Re: [EXTERNAL] Re: Android 8 crash caused by upstream change.

[Andrew Grieve]

Chrome supports O still. You just need to set use_relr_relocations=false in your GN args, or set is_high_end_android=false.

On Thu, Feb 22, 2024 at 9:03 PM Yu Jiang <yuj...@microsoft.com> wrote:

Hi Mohamed,

Thanks for your reply, i'm still confused that how to avoid the crash on Android O/8, what does upstream do to avoid the crash happening. I noticed that you have commented in the description 

It seems that upstream will not support Android O/8? But for now, how to fix this on Android 8?  Thanks very much for your reply.

Best Regards,

Yu

---

From: Mohamed Heikal <mhe...@chromium.org>
Sent: Friday, February 2, 2024 1:42 AM
To: Yu Jiang <yuj...@microsoft.com>
Cc: pa...@chromium.org <pa...@chromium.org>; agr...@chromium.org <agr...@chromium.org>; mhe...@chromium.org <mhe...@chromium.org>; Jiayi Yan <jiay...@microsoft.com>; Ke Yu <k...@microsoft.com>; clank-build <clank...@google.com>
Subject: [EXTERNAL] Re: Android 8 crash caused by upstream change.

 

You don't often get email from mhe...@chromium.org. Learn why this is important

+clank-build 

The change you are pointing to is restricting relative relocations (the thing that crashes in Android 8/O) to the is_official_build configuration rather than make it more common (as in, there are fewer configurations that enable relative relocations by default rather than more after this change, so new crashes are not happening because of this). 

But also, use_relr_relocations is in a declare_args which means you can override the value in args.gn when building. For reference, chrome does not set is_high_end_android to true except when building the Q+ variant/SKU (to avoid crashing in O like you mentioned).

On Wed, Jan 31, 2024 at 9:49 PM Yu Jiang <yuj...@microsoft.com> wrote:

Hi Team,

I'm from Microsoft edge android mobile team, we found the PR from upstream which will cause crash in Android 8, could you please help to double check?

The PR: chromium/src - Chromium Code Search

Thanks,

Yu