depot_tools bootstrap.py requires admin privileges on Windows?

226 views
Skip to first unread message

Rob Sussman

unread,
Nov 19, 2024, 2:15:26 PM11/19/24
to build
Hello!

A recent change to depot_tools is causing a build issue on Windows for us. Perhaps this is a configuration problem on our side? 

It seems likely the problem we aer seeing is caused by this commit:

This causes the system git (at c:\Program Files\Git) to be used instead of the one local to depot_tools. The bootstrap.py script attempts to `git config --system ...` which fails because the context of the build does not have permissions to write inside C:\Program Files\Git. 

I've looked at the bootstrap.py script but I don't see any answers there. Here is where the script makes the calls to modify the system git config:

It feels like a bug that the bootstrap script would modify the system git config and thus need admin rights? Thanks for any suggestions!

Rob

Dirk Pranke

unread,
Nov 19, 2024, 2:44:56 PM11/19/24
to Rob Sussman, build, Josip Sokcevic, Anne Redulla, Allen Li
Hi Rob,

I'm not familiar with that CL in particular, but I would guess that this is just an accidental side effect of the work to not provide a bundled Git install. Stuff that possibly made sense with a Git we fully control makes less (or no) sense with a Git we don't. In this particular case, the code using `--system` is pretty old and we probably weren't aware of it when we made the problematic change. I would think that now we should be using `--global` instead.

I agree that we should be avoiding needing admin rights if at all possible.

If you can, it would be helpful if you can file a bug for this, so we can track the conversation and fix. I've also cc'ed the owners of that change to correct me if my guesses are wrong :).

-- Dirk

--
You received this message because you are subscribed to the Google Groups "build" group.
To unsubscribe from this group and stop receiving emails from it, send an email to build+un...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/build/68e0b424-f6b2-4e01-9737-b5946ede499en%40chromium.org.

Rob Sussman

unread,
Nov 19, 2024, 4:55:30 PM11/19/24
to build, dpr...@google.com, build, Josip Sokcevic, Anne Redulla, Allen Li, Rob Sussman
Hi Dirk,

Thanks so much for the quick reply. I've created an issue here:

Best,
Rob

Reply all
Reply to author
Forward
0 new messages