Search Conversations

Groups

1–30 of many

Mason Freed (Gerrit), … Chromium LUCI CQ (Gerrit)4

Jun 27

Remove KeyboardFocusableScrollers flag [chromium/src : main]

: Remove KeyboardFocusableScrollers flag ...................................................................... Remove KeyboardFocusableScrollers flag The feature

unread,

Remove KeyboardFocusableScrollers flag [chromium/src : main]

: Remove KeyboardFocusableScrollers flag ...................................................................... Remove KeyboardFocusableScrollers flag The feature

Jun 27

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)5

Jun 4

Remove virtual test for keyboard focusable scrollers [chromium/src : main]

scrollers Feature KeyboardFocusableScrollers was enabled by default in stable 132. The virtual tests can be removed. Note we should wait another milestone before removing the actual

unread,

Remove virtual test for keyboard focusable scrollers [chromium/src : main]

scrollers Feature KeyboardFocusableScrollers was enabled by default in stable 132. The virtual tests can be removed. Note we should wait another milestone before removing the actual

Jun 4

gwsq (Gerrit), … Chromium LUCI CQ (Gerrit)13

Jun 3

Remove enterprise policy for KeyboardFocusableScrollers at 138 [chromium/src : main]

policy for KeyboardFocusableScrollers at 138 ...................................................................... Remove enterprise policy for KeyboardFocusableScrollers

unread,

Remove enterprise policy for KeyboardFocusableScrollers at 138 [chromium/src : main]

policy for KeyboardFocusableScrollers at 138 ...................................................................... Remove enterprise policy for KeyboardFocusableScrollers

Jun 3

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)15

11/1/24

[A11y] Repair names for tabbable elements only if focused [chromium/src : main]

with the KeyboardFocusableScrollers feature. In some cases we repair accessible names for elements that are keyboard-focusable but are missing a name. That way, the user will hear

unread,

[A11y] Repair names for tabbable elements only if focused [chromium/src : main]

with the KeyboardFocusableScrollers feature. In some cases we repair accessible names for elements that are keyboard-focusable but are missing a name. That way, the user will hear

11/1/24

Mason Freed (Gerrit), … Chromium LUCI CQ (Gerrit)3

9/5/24

Enable KeyboardFocusableScrollers by default [chromium/src : main]

: Enable KeyboardFocusableScrollers by default ...................................................................... Enable KeyboardFocusableScrollers by default

unread,

Enable KeyboardFocusableScrollers by default [chromium/src : main]

: Enable KeyboardFocusableScrollers by default ...................................................................... Enable KeyboardFocusableScrollers by default

9/5/24

Mason Freed (Gerrit), … Chromium LUCI CQ (Gerrit)14

8/30/24

Make KeyboardFocusableScrollers keyboard-focus but not mouse-focus [chromium/src : main]

: Make KeyboardFocusableScrollers keyboard-focus but not mouse-focus ...................................................................... Make KeyboardFocusableScrollers

unread,

Make KeyboardFocusableScrollers keyboard-focus but not mouse-focus [chromium/src : main]

: Make KeyboardFocusableScrollers keyboard-focus but not mouse-focus ...................................................................... Make KeyboardFocusableScrollers

8/30/24

Di Zhang (Gerrit), … Mason Freed (Gerrit)7

8/26/24

[KeyboardFocusableScrollers] Make scrollers not mouse focusable by default [chromium/src : main]

: [KeyboardFocusableScrollers] Make scrollers not mouse focusable by default ...................................................................... Abandoned https

unread,

[KeyboardFocusableScrollers] Make scrollers not mouse focusable by default [chromium/src : main]

: [KeyboardFocusableScrollers] Make scrollers not mouse focusable by default ...................................................................... Abandoned https

8/26/24

Mason Freed (Gerrit), … Chromium LUCI CQ (Gerrit)5

8/23/24

[M129] Unship KeyboardFocusableScrollers, temporarily [chromium/src : refs/branch-heads/6668]

] Unship KeyboardFocusableScrollers, temporarily ...................................................................... [M129] Unship KeyboardFocusableScrollers

unread,

[M129] Unship KeyboardFocusableScrollers, temporarily [chromium/src : refs/branch-heads/6668]

] Unship KeyboardFocusableScrollers, temporarily ...................................................................... [M129] Unship KeyboardFocusableScrollers

8/23/24

Mason Freed (Gerrit), … Chromium LUCI CQ (Gerrit)3

8/20/24

Unship KeyboardFocusableScrollers, temporarily [chromium/src : main]

: Unship KeyboardFocusableScrollers, temporarily ...................................................................... Unship KeyboardFocusableScrollers, temporarily

unread,

Unship KeyboardFocusableScrollers, temporarily [chromium/src : main]

: Unship KeyboardFocusableScrollers, temporarily ...................................................................... Unship KeyboardFocusableScrollers, temporarily

8/20/24

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)5

8/9/24

Enable KeyboardFocusableScrollers to stable [chromium/src : main]

: Enable KeyboardFocusableScrollers to stable ...................................................................... Enable KeyboardFocusableScrollers to stable

unread,

Enable KeyboardFocusableScrollers to stable [chromium/src : main]

: Enable KeyboardFocusableScrollers to stable ...................................................................... Enable KeyboardFocusableScrollers to stable

8/9/24

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)16

5/14/24

Add an enterprise policy to disable KeyboardFocusableScrollers [chromium/src : main]

to disable KeyboardFocusableScrollers ...................................................................... Add an enterprise policy to disable KeyboardFocusableScrollers

unread,

Add an enterprise policy to disable KeyboardFocusableScrollers [chromium/src : main]

to disable KeyboardFocusableScrollers ...................................................................... Add an enterprise policy to disable KeyboardFocusableScrollers

5/14/24

Mason Freed (Gerrit), … Chromium LUCI CQ (Gerrit)7

5/9/24

Add feature and about_flags entry to disable KeyboardFocusableScrollers [chromium/src : main]

to disable KeyboardFocusableScrollers ...................................................................... Add feature and about_flags entry to disable KeyboardFocusableScrollers

unread,

Add feature and about_flags entry to disable KeyboardFocusableScrollers [chromium/src : main]

to disable KeyboardFocusableScrollers ...................................................................... Add feature and about_flags entry to disable KeyboardFocusableScrollers

5/9/24

Di Zhang (Gerrit)

5/6/24

Add a feature flag and about_flags entry to disable KeyboardFocusableScrollers [chromium/src : main]

Attention is currently required from: Mason Freed. New activity on the change2 comments: File third_party/blink/renderer/modules/accessibility/

unread,

Add a feature flag and about_flags entry to disable KeyboardFocusableScrollers [chromium/src : main]

Attention is currently required from: Mason Freed. New activity on the change2 comments: File third_party/blink/renderer/modules/accessibility/

5/6/24

Rubber Stamper (Gerrit), … Chromium LUCI CQ (Gerrit)4

4/30/24

[M125] Disable KeyboardFocusableScrollers from stable [chromium/src : refs/branch-heads/6422]

] Disable KeyboardFocusableScrollers from stable ...................................................................... [M125] Disable KeyboardFocusableScrollers

unread,

[M125] Disable KeyboardFocusableScrollers from stable [chromium/src : refs/branch-heads/6422]

] Disable KeyboardFocusableScrollers from stable ...................................................................... [M125] Disable KeyboardFocusableScrollers

4/30/24

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)3

4/24/24

Disable KeyboardFocusableScrollers from stable [chromium/src : main]

: Disable KeyboardFocusableScrollers from stable ...................................................................... Disable KeyboardFocusableScrollers from

unread,

Disable KeyboardFocusableScrollers from stable [chromium/src : main]

: Disable KeyboardFocusableScrollers from stable ...................................................................... Disable KeyboardFocusableScrollers from

4/24/24

Mason Freed (Gerrit), … Chromium LUCI CQ (Gerrit)4

4/12/24

Enable KeyboardFocusableScrollers to stable [chromium/src : main]

: Enable KeyboardFocusableScrollers to stable ...................................................................... Enable KeyboardFocusableScrollers to stable

unread,

Enable KeyboardFocusableScrollers to stable [chromium/src : main]

: Enable KeyboardFocusableScrollers to stable ...................................................................... Enable KeyboardFocusableScrollers to stable

4/12/24

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)11

12/12/23

Switch blink feature KeyboardFocusableScrollers to status experimental [chromium/src : main]

blink feature KeyboardFocusableScrollers to status experimental ...................................................................... Switch blink feature KeyboardFocusableScrollers

unread,

Switch blink feature KeyboardFocusableScrollers to status experimental [chromium/src : main]

blink feature KeyboardFocusableScrollers to status experimental ...................................................................... Switch blink feature KeyboardFocusableScrollers

12/12/23

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)12

11/20/23

Reland "SupportsFocus() should return true for all scrollers" [chromium/src : main]

For feature KeyboardFocusableScrollers, SupportsFocus() call IsKeyboardFocusableScroller which will potentially traverse through the scroller's children to find focusable

unread,

Reland "SupportsFocus() should return true for all scrollers" [chromium/src : main]

For feature KeyboardFocusableScrollers, SupportsFocus() call IsKeyboardFocusableScroller which will potentially traverse through the scroller's children to find focusable

11/20/23

Di Zhang (Gerrit), … Darren Shen (Gerrit)21

11/13/23

SupportsFocus() should return true for all scrollers [chromium/src : main]

For feature KeyboardFocusableScrollers, SupportsFocus() call IsScrollableContainerThatShouldBeKeyboardFocusable which can potentially traverse through the scroller's

unread,

SupportsFocus() should return true for all scrollers [chromium/src : main]

For feature KeyboardFocusableScrollers, SupportsFocus() call IsScrollableContainerThatShouldBeKeyboardFocusable which can potentially traverse through the scroller's

11/13/23

Di Zhang (Gerrit)

11/6/23

SupportsFocus() shouldn't traverse children [chromium/src : main]

For feature KeyboardFocusableScrollers, SupportsFocus() call IsScrollableContainerThatShouldBeKeyboardFocusable which can potentially traverse through the scroller's

unread,

SupportsFocus() shouldn't traverse children [chromium/src : main]

For feature KeyboardFocusableScrollers, SupportsFocus() call IsScrollableContainerThatShouldBeKeyboardFocusable which can potentially traverse through the scroller's

11/6/23

Mason Freed (Gerrit), Di Zhang (Gerrit)9

11/3/23

[KeyboardFocusableScrollers] SupportsFocus() call IsScrollableNode instead of IsScrollableContainerThatShouldBeKeyboardFocusable [chromium/src : main]

: [KeyboardFocusableScrollers] SupportsFocus() call IsScrollableNode instead of IsScrollableContainerThatShouldBeKeyboardFocusable ............................

unread,

[KeyboardFocusableScrollers] SupportsFocus() call IsScrollableNode instead of IsScrollableContainerThatShouldBeKeyboardFocusable [chromium/src : main]

: [KeyboardFocusableScrollers] SupportsFocus() call IsScrollableNode instead of IsScrollableContainerThatShouldBeKeyboardFocusable ............................

11/3/23

Philip Rogers (Gerrit)

10/30/23

Deflake focus tests by disabling KeyboardFocusableScrollers [chromium/src : main]

by disabling KeyboardFocusableScrollers ...................................................................... Abandoned -- To view, visit https://chromium-review

unread,

Deflake focus tests by disabling KeyboardFocusableScrollers [chromium/src : main]

by disabling KeyboardFocusableScrollers ...................................................................... Abandoned -- To view, visit https://chromium-review

10/30/23

Di Zhang (Gerrit), … Mason Freed (Gerrit)11

11/14/23

Put isScrollableNode's UpdateStyleAndLayout check behind flag [chromium/src : main]

-evaluting KeyboardFocusableScrollers' calls to update layout, this part of the logic should be behind the feature flag. Change-Id: Id775ab177716a5c07a32bc4c53ce0ec29f386d84

unread,

Put isScrollableNode's UpdateStyleAndLayout check behind flag [chromium/src : main]

-evaluting KeyboardFocusableScrollers' calls to update layout, this part of the logic should be behind the feature flag. Change-Id: Id775ab177716a5c07a32bc4c53ce0ec29f386d84

11/14/23

Chris Harrelson (Gerrit), … Chromium LUCI CQ (Gerrit)11

10/23/23

Turn off KeyboardFocusableScrollers for now while we fix issues. [chromium/src : main]

Turn off KeyboardFocusableScrollers for now while we fix issues. ...................................................................... Turn off KeyboardFocusableScrollers

unread,

Turn off KeyboardFocusableScrollers for now while we fix issues. [chromium/src : main]

Turn off KeyboardFocusableScrollers for now while we fix issues. ...................................................................... Turn off KeyboardFocusableScrollers

10/23/23

Mason Freed (Gerrit), … Chromium LUCI CQ (Gerrit)32

11/6/23

Add argument to IsFocusable() for a11y use only [chromium/src : main]

Therefore the KeyboardFocusableScrollers feature causes a dependency on layout and also this code cannot safely be called directly from the a11y update. Possible fixes: * Always

unread,

Add argument to IsFocusable() for a11y use only [chromium/src : main]

Therefore the KeyboardFocusableScrollers feature causes a dependency on layout and also this code cannot safely be called directly from the a11y update. Possible fixes: * Always

11/6/23

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)6

10/4/23

Enable feature KeyboardFocusableScrollers to stable [chromium/src : main]

Enable feature KeyboardFocusableScrollers to stable ...................................................................... Enable feature KeyboardFocusableScrollers

unread,

Enable feature KeyboardFocusableScrollers to stable [chromium/src : main]

Enable feature KeyboardFocusableScrollers to stable ...................................................................... Enable feature KeyboardFocusableScrollers

10/4/23

Di Zhang (Gerrit), … Chromium LUCI CQ (Gerrit)18

9/28/23

Deflake focus tests that relied on stale layout information [chromium/src : main]

layout information KeyboardFocusableScrollers is enabled for tests and allows focus for scrollable elements. The logic for whether an object is scrollable depends on layout size

unread,

Deflake focus tests that relied on stale layout information [chromium/src : main]

layout information KeyboardFocusableScrollers is enabled for tests and allows focus for scrollable elements. The logic for whether an object is scrollable depends on layout size

9/28/23

Mason Freed (Gerrit), … Zijie He (Gerrit)26

8/30/23

Address TODO(accessibility) things in ax_object.cc [chromium/src : main]

to the KeyboardFocusableScrollers feature. This CL implements those TODOs. Note that this undoes some of the test changes made in [1]. [1] https://chromium-review.googlesource

unread,

Address TODO(accessibility) things in ax_object.cc [chromium/src : main]

to the KeyboardFocusableScrollers feature. This CL implements those TODOs. Note that this undoes some of the test changes made in [1]. [1] https://chromium-review.googlesource

8/30/23

Mason Freed (Gerrit), … Blink W3C Test Autoroller (Gerrit)46

8/29/23

Rationalize the behavior of SupportsFocus, Is{keybd|mouse}Focusable [chromium/src : main]

up on KeyboardFocusableScrollers > entirely. […] Re-removed, per my other comment. File content/test/data/accessibility/html/overflow-actions-expected-android.txt

unread,

Rationalize the behavior of SupportsFocus, Is{keybd|mouse}Focusable [chromium/src : main]

up on KeyboardFocusableScrollers > entirely. […] Re-removed, per my other comment. File content/test/data/accessibility/html/overflow-actions-expected-android.txt

8/29/23

Di Zhang (Gerrit), … Mason Freed (Gerrit)13

8/21/23

Enable KeyboardFocusableScrollersEnabled code in ax_object.cc [chromium/src : main]

to ship KeyboardFocusableScrollers, we need to address all TODOs related to this feature for accessibility concerns. Change-Id: I6d9ff6e3bc8f9493c7d95aede3c2af033d04f3c1

unread,

Enable KeyboardFocusableScrollersEnabled code in ax_object.cc [chromium/src : main]

to ship KeyboardFocusableScrollers, we need to address all TODOs related to this feature for accessibility concerns. Change-Id: I6d9ff6e3bc8f9493c7d95aede3c2af033d04f3c1

8/21/23

Search

Clear search

Close search

Google apps

Main menu