Make ScrollIntoViewOptions default to auto alignment [chromium/src : main]

0 views

Skip to first unread message

Robert Flack (Gerrit)

unread,

12:01 PM (2 hours ago) 12:01 PM

to David A, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from David A

Robert Flack added 1 comment

File third_party/blink/renderer/core/scroll/scroll_into_view_util.cc

Line 607, Patchset 3 (Latest): : options.inlinePosition().AsEnum();

Robert Flack . unresolved

We should probably put this behind a feature flag. I think the actual "auto" value is never exposed to js, so you can just flag guard treating auto as overrideable. This flag can be experimental so that it is easily testable.

Open in Gerrit

Related details

Attention is currently required from:

David A

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages