[Editing] Fix InputEvent type for deletion commands with non-collapsed selection [chromium/src : main]

0 views
Skip to first unread message

Shweta Bindal (Gerrit)

unread,
Dec 18, 2025, 3:32:35 AM (5 days ago) Dec 18
to Pranav Modi, Sambamurthy Bandaru, Rakesh Goulikar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Pranav Modi, Rakesh Goulikar and Sambamurthy Bandaru

Shweta Bindal added 1 comment

File third_party/blink/web_tests/external/wpt/input-events/input-events-delete-selection.html
Line 17, Patchset 2 (Latest): inputEventsLog.push({
Shweta Bindal . unresolved

According to chromium docs we should use 2 spaces for indentation

Open in Gerrit

Related details

Attention is currently required from:
  • Pranav Modi
  • Rakesh Goulikar
  • Sambamurthy Bandaru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7e9f05a3e049472b2855341d571d6df350821e6a
Gerrit-Change-Number: 7266851
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Modi <prana...@microsoft.com>
Gerrit-Reviewer: Pranav Modi <prana...@microsoft.com>
Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-CC: Shweta Bindal <shweta...@microsoft.com>
Gerrit-Attention: Pranav Modi <prana...@microsoft.com>
Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 08:32:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Pranav Modi (Gerrit)

unread,
Dec 19, 2025, 1:21:48 AM (4 days ago) Dec 19
to Shweta Bindal, Sambamurthy Bandaru, Rakesh Goulikar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Rakesh Goulikar, Sambamurthy Bandaru and Shweta Bindal

Pranav Modi added 1 comment

File third_party/blink/web_tests/external/wpt/input-events/input-events-delete-selection.html
Line 17, Patchset 2: inputEventsLog.push({
Shweta Bindal . resolved

According to chromium docs we should use 2 spaces for indentation

Pranav Modi

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Rakesh Goulikar
  • Sambamurthy Bandaru
  • Shweta Bindal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7e9f05a3e049472b2855341d571d6df350821e6a
    Gerrit-Change-Number: 7266851
    Gerrit-PatchSet: 2
    Gerrit-Owner: Pranav Modi <prana...@microsoft.com>
    Gerrit-Reviewer: Pranav Modi <prana...@microsoft.com>
    Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
    Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
    Gerrit-CC: Shweta Bindal <shweta...@microsoft.com>
    Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>
    Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>
    Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 06:21:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Shweta Bindal <shweta...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sambamurthy Bandaru (Gerrit)

    unread,
    Dec 19, 2025, 2:01:29 AM (4 days ago) Dec 19
    to Pranav Modi, Shweta Bindal, Rakesh Goulikar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Pranav Modi, Rakesh Goulikar and Shweta Bindal

    Sambamurthy Bandaru added 3 comments

    File third_party/blink/web_tests/external/wpt/input-events/input-events-delete-selection.html
    Line 16, Patchset 3 (Latest): const DELETE_WORD_KEY = isMacOS ? "\uE00A" : "\uE009"; // Alt on Mac, Ctrl on others
    Sambamurthy Bandaru . unresolved
    ```suggestion
      const MODIFIER_KEY = isMacOS ? "\uE00A" : "\uE009"; // Alt on Mac, Ctrl on others
    ```
    Line 43, Patchset 3 (Latest): // Test Ctrl+Backspace (deleteWordBackward) with non-collapsed selection
    Sambamurthy Bandaru . unresolved
    ```suggestion
      // Test Ctrl+Backspace with non-collapsed selection
    ```
    Remove `(deleteWordBackward/Forward)` from any test descriptions and expectation strings too
    Line 55, Patchset 3 (Latest): .keyDown(DELETE_WORD_KEY)
    Sambamurthy Bandaru . unresolved

    replace all in the file

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Pranav Modi
    • Rakesh Goulikar
    • Shweta Bindal
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7e9f05a3e049472b2855341d571d6df350821e6a
      Gerrit-Change-Number: 7266851
      Gerrit-PatchSet: 3
      Gerrit-Owner: Pranav Modi <prana...@microsoft.com>
      Gerrit-Reviewer: Pranav Modi <prana...@microsoft.com>
      Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
      Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
      Gerrit-CC: Shweta Bindal <shweta...@microsoft.com>
      Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>
      Gerrit-Attention: Pranav Modi <prana...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sambamurthy Bandaru (Gerrit)

      unread,
      Dec 19, 2025, 2:07:49 AM (4 days ago) Dec 19
      to Pranav Modi, Shweta Bindal, Rakesh Goulikar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Pranav Modi, Rakesh Goulikar and Shweta Bindal

      Sambamurthy Bandaru voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Pranav Modi
      • Rakesh Goulikar
      • Shweta Bindal
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7e9f05a3e049472b2855341d571d6df350821e6a
        Gerrit-Change-Number: 7266851
        Gerrit-PatchSet: 3
        Gerrit-Owner: Pranav Modi <prana...@microsoft.com>
        Gerrit-Reviewer: Pranav Modi <prana...@microsoft.com>
        Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
        Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
        Gerrit-CC: Shweta Bindal <shweta...@microsoft.com>
        Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>
        Gerrit-Attention: Pranav Modi <prana...@microsoft.com>
        Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
        Gerrit-Comment-Date: Fri, 19 Dec 2025 07:07:17 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Pranav Modi (Gerrit)

        unread,
        Dec 19, 2025, 2:17:15 AM (4 days ago) Dec 19
        to Sambamurthy Bandaru, Shweta Bindal, Rakesh Goulikar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
        Attention needed from Rakesh Goulikar and Shweta Bindal

        Pranav Modi added 3 comments

        File third_party/blink/web_tests/external/wpt/input-events/input-events-delete-selection.html
        Line 16, Patchset 3 (Latest): const DELETE_WORD_KEY = isMacOS ? "\uE00A" : "\uE009"; // Alt on Mac, Ctrl on others
        Sambamurthy Bandaru . resolved
        ```suggestion
          const MODIFIER_KEY = isMacOS ? "\uE00A" : "\uE009"; // Alt on Mac, Ctrl on others
        ```
        Pranav Modi

        Done

        Line 43, Patchset 3 (Latest): // Test Ctrl+Backspace (deleteWordBackward) with non-collapsed selection
        Sambamurthy Bandaru . resolved
        ```suggestion
          // Test Ctrl+Backspace with non-collapsed selection
        ```
        Remove `(deleteWordBackward/Forward)` from any test descriptions and expectation strings too
        Pranav Modi

        Done

        Line 55, Patchset 3 (Latest): .keyDown(DELETE_WORD_KEY)
        Sambamurthy Bandaru . resolved

        replace all in the file

        Pranav Modi

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Rakesh Goulikar
        • Shweta Bindal
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I7e9f05a3e049472b2855341d571d6df350821e6a
          Gerrit-Change-Number: 7266851
          Gerrit-PatchSet: 3
          Gerrit-Owner: Pranav Modi <prana...@microsoft.com>
          Gerrit-Reviewer: Pranav Modi <prana...@microsoft.com>
          Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
          Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
          Gerrit-CC: Shweta Bindal <shweta...@microsoft.com>
          Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>
          Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
          Gerrit-Comment-Date: Fri, 19 Dec 2025 07:16:52 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Sambamurthy Bandaru <sambamurt...@microsoft.com>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Pranav Modi (Gerrit)

          unread,
          Dec 19, 2025, 2:21:03 AM (4 days ago) Dec 19
          to Kent Tamura, Sambamurthy Bandaru, Shweta Bindal, Rakesh Goulikar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
          Attention needed from Kent Tamura, Rakesh Goulikar and Shweta Bindal

          Pranav Modi added 1 comment

          Patchset-level comments
          File-level comment, Patchset 4 (Latest):
          Pranav Modi . resolved

          Hi @tk...@chromium.org San, please review!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Kent Tamura
          • Rakesh Goulikar
          • Shweta Bindal
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I7e9f05a3e049472b2855341d571d6df350821e6a
            Gerrit-Change-Number: 7266851
            Gerrit-PatchSet: 4
            Gerrit-Owner: Pranav Modi <prana...@microsoft.com>
            Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
            Gerrit-Reviewer: Pranav Modi <prana...@microsoft.com>
            Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
            Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
            Gerrit-CC: Shweta Bindal <shweta...@microsoft.com>
            Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>
            Gerrit-Attention: Kent Tamura <tk...@chromium.org>
            Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
            Gerrit-Comment-Date: Fri, 19 Dec 2025 07:20:32 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Pranav Modi (Gerrit)

            unread,
            12:33 AM (7 hours ago) 12:33 AM
            to Kent Tamura, Sambamurthy Bandaru, Shweta Bindal, Rakesh Goulikar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
            Attention needed from Kent Tamura, Rakesh Goulikar and Shweta Bindal

            Pranav Modi added 1 comment

            Patchset-level comments
            Pranav Modi . resolved

            Hi @tk...@chromium.org San, Gentle Reminder for reviewing the CL.

            Gerrit-Comment-Date: Tue, 23 Dec 2025 05:33:32 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages