[Masonry] Fix row/column-item-minmax-img-001.html [chromium/src : main]

0 views
Skip to first unread message

Alison Maher (Gerrit)

unread,
11:21 AM (10 hours ago) 11:21 AM
to Ian Kilpatrick, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick

Alison Maher added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Alison Maher . resolved

ikilpatrick@ - adding you for review on this one since you had suggested opting masonry out of this special replaced item logic originally. If you think it still makes sense for masonry to opt out of this, I can instead update the test expectations for this one

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7dd541989b2617924e76b3aac91c374e54f3659
Gerrit-Change-Number: 7043003
Gerrit-PatchSet: 5
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Wed, 15 Oct 2025 15:21:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kurt Catti-Schmidt (Gerrit)

unread,
11:40 AM (9 hours ago) 11:40 AM
to Alison Maher, Ian Kilpatrick, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Alison Maher and Ian Kilpatrick

Kurt Catti-Schmidt voted and added 1 comment

Votes added by Kurt Catti-Schmidt

Code-Review+1

1 comment

File third_party/blink/renderer/core/layout/grid/grid_item.cc
Line 140, Patchset 5 (Parent): // Don't apply special 'fit-content' behavior for replaced items in
// a masonry container.
Kurt Catti-Schmidt . unresolved

Might want to add a TODO here or link to a CSSWG bug for this behavior since it sounds like it's not decided

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib7dd541989b2617924e76b3aac91c374e54f3659
    Gerrit-Change-Number: 7043003
    Gerrit-PatchSet: 5
    Gerrit-Owner: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-Attention: Alison Maher <alm...@microsoft.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 15:39:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alison Maher (Gerrit)

    unread,
    11:46 AM (9 hours ago) 11:46 AM
    to Kurt Catti-Schmidt, Ian Kilpatrick, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
    Attention needed from Ian Kilpatrick and Kurt Catti-Schmidt

    Alison Maher added 1 comment

    File third_party/blink/renderer/core/layout/grid/grid_item.cc
    Line 140, Patchset 5 (Parent): // Don't apply special 'fit-content' behavior for replaced items in
    // a masonry container.
    Kurt Catti-Schmidt . unresolved

    Might want to add a TODO here or link to a CSSWG bug for this behavior since it sounds like it's not decided

    Alison Maher

    Yeah, we may still want this - I wasn't fully sure why we would or wouldn't want this for masonry. Will hold off on a TODO until Ian weighs in, and depending on the path forward, I can plan to add a TODO for this, too

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Kilpatrick
    • Kurt Catti-Schmidt
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib7dd541989b2617924e76b3aac91c374e54f3659
    Gerrit-Change-Number: 7043003
    Gerrit-PatchSet: 6
    Gerrit-Owner: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 15:45:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Kurt Catti-Schmidt <ksc...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kurt Catti-Schmidt (Gerrit)

    unread,
    11:47 AM (9 hours ago) 11:47 AM
    to Alison Maher, Ian Kilpatrick, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
    Attention needed from Alison Maher and Ian Kilpatrick

    Kurt Catti-Schmidt voted and added 1 comment

    Votes added by Kurt Catti-Schmidt

    Code-Review+1

    1 comment

    File third_party/blink/renderer/core/layout/grid/grid_item.cc
    Line 140, Patchset 5 (Parent): // Don't apply special 'fit-content' behavior for replaced items in
    // a masonry container.
    Kurt Catti-Schmidt . unresolved

    Might want to add a TODO here or link to a CSSWG bug for this behavior since it sounds like it's not decided

    Alison Maher

    Yeah, we may still want this - I wasn't fully sure why we would or wouldn't want this for masonry. Will hold off on a TODO until Ian weighs in, and depending on the path forward, I can plan to add a TODO for this, too

    Kurt Catti-Schmidt

    Yeah that works too, just want to make sure this is tracked somewhere

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alison Maher
    • Ian Kilpatrick
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib7dd541989b2617924e76b3aac91c374e54f3659
    Gerrit-Change-Number: 7043003
    Gerrit-PatchSet: 6
    Gerrit-Owner: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-Attention: Alison Maher <alm...@microsoft.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 15:46:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Alison Maher <alm...@microsoft.com>
    Comment-In-Reply-To: Kurt Catti-Schmidt <ksc...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages