[css-anchor-position] Fix anchors-visible on stacked children [chromium/src : main]

0 views
Skip to first unread message

Xianzhu Wang (Gerrit)

unread,
Apr 3, 2024, 4:12:52 PMApr 3
to Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cc03c30977f07aaddf0f87462a4e9770f94deff
Gerrit-Change-Number: 5421237
Gerrit-PatchSet: 1
Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Apr 2024 20:12:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Apr 3, 2024, 4:19:30 PMApr 3
to Xianzhu Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Xianzhu Wang

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Philip Rogers . resolved

lol!

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Xianzhu Wang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cc03c30977f07aaddf0f87462a4e9770f94deff
Gerrit-Change-Number: 5421237
Gerrit-PatchSet: 1
Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Attention: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Apr 2024 20:19:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Blink W3C Test Autoroller (Gerrit)

unread,
Apr 3, 2024, 4:26:22 PMApr 3
to Xianzhu Wang, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/45511.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cc03c30977f07aaddf0f87462a4e9770f94deff
Gerrit-Change-Number: 5421237
Gerrit-PatchSet: 1
Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Apr 2024 20:26:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Xianzhu Wang (Gerrit)

unread,
Apr 3, 2024, 4:26:49 PMApr 3
to Blink W3C Test Autoroller, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Xianzhu Wang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cc03c30977f07aaddf0f87462a4e9770f94deff
Gerrit-Change-Number: 5421237
Gerrit-PatchSet: 1
Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Apr 2024 20:26:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 3, 2024, 4:31:49 PMApr 3
to Xianzhu Wang, Blink W3C Test Autoroller, Philip Rogers, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[css-anchor-position] Fix anchors-visible on stacked children
Bug: 332678663
Change-Id: I7cc03c30977f07aaddf0f87462a4e9770f94deff
Commit-Queue: Xianzhu Wang <wangx...@chromium.org>
Reviewed-by: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282084}
Files:
  • M third_party/blink/renderer/core/paint/paint_layer.cc
  • A third_party/blink/web_tests/external/wpt/css/css-anchor-position/position-visibility-anchors-visible-stacked-child.tentative.html
Change size: M
Delta: 2 files changed, 61 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Rogers
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cc03c30977f07aaddf0f87462a4e9770f94deff
Gerrit-Change-Number: 5421237
Gerrit-PatchSet: 2
Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
open
diffy
satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,
Apr 3, 2024, 6:25:46 PMApr 3
to Xianzhu Wang, Chromium LUCI CQ, Philip Rogers, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/45511

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cc03c30977f07aaddf0f87462a4e9770f94deff
Gerrit-Change-Number: 5421237
Gerrit-PatchSet: 2
Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Apr 2024 22:25:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Blink W3C Test Autoroller (Gerrit)

unread,
Apr 24, 2024, 11:15:07 AMApr 24
to Xianzhu Wang, Chromium LUCI CQ, Philip Rogers, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/45877

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7cc03c30977f07aaddf0f87462a4e9770f94deff
Gerrit-Change-Number: 5421237
Gerrit-PatchSet: 2
Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Apr 2024 15:14:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages