Remove some includes of SkBitmap.h [chromium/src : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Dec 5, 2025, 8:54:57 PM (2 days ago) Dec 5
to David Sanders, Lei Zhang, Chromium LUCI CQ, Dirk Schulze, Stephen Chenney, AyeAye, pkotwic...@chromium.org, cc-...@chromium.org, permissio...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, kinuko...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org
Attention needed from David Sanders
Lei Zhang added 1 comment![]( "Open in Gerrit")
File cc/test/layer_tree_pixel_test.h
Line 23, Patchset 12 (Latest):
class SkBitmap;Lei Zhang . unresolved
Please remove the forward declaration here.
Related details
Attention is currently required from:
- David Sanders
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Sanders (Gerrit)
Dec 5, 2025, 9:19:05 PM (2 days ago) Dec 5
to Lei Zhang, Chromium LUCI CQ, Dirk Schulze, Stephen Chenney, AyeAye, pkotwic...@chromium.org, cc-...@chromium.org, permissio...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, kinuko...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org
Attention needed from Lei Zhang
David Sanders voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Sanders
| Commit-Queue | +1 |
1 comment
File cc/test/layer_tree_pixel_test.h
Please remove the forward declaration here.
David Sanders
Done.
This reminds me, at some point I'm going to look into making a more general version of the `bugprone-forward-declaration-namespace` check in `clang-tidy` to warn on any unused forward declaration. There's definitely a lot of dangling forward declarations in the Chromium code base that get created in situations like this where an include is added and a previous forward declaration goes unnoticed.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Dec 5, 2025, 9:27:00 PM (2 days ago) Dec 5
to David Sanders, Lei Zhang, Chromium LUCI CQ, Dirk Schulze, Stephen Chenney, AyeAye, pkotwic...@chromium.org, cc-...@chromium.org, permissio...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, kinuko...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org
Attention needed from David Sanders
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
1 comment
File cc/test/layer_tree_pixel_test.h
Line 23, Patchset 12:
class SkBitmap;Lei Zhang . resolved
David SandersPlease remove the forward declaration here.
Done.
This reminds me, at some point I'm going to look into making a more general version of the `bugprone-forward-declaration-namespace` check in `clang-tidy` to warn on any unused forward declaration. There's definitely a lot of dangling forward declarations in the Chromium code base that get created in situations like this where an include is added and a previous forward declaration goes unnoticed.
Lei Zhang
There's a presubmit that warns about unused forward declarations. This isn't that though. Rather, it's a redundant forward declaration.
Related details
Attention is currently required from:
- David Sanders
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 5, 2025, 10:43:51 PM (2 days ago) Dec 5
to David Sanders, Lei Zhang, Dirk Schulze, Stephen Chenney, AyeAye, pkotwic...@chromium.org, cc-...@chromium.org, permissio...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, kinuko...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove some includes of SkBitmap.h
Should save ~40 MiB of compiler input size.
Adds missing includes and forward decls as needed to fix the build.
Bug: 40318405, 429365675
Change-Id: I337f81b84a7c32dba3651e3e98ea192a6eb2bb66
Commit-Queue: David Sanders <dsand...@ucsbalum.com>
Reviewed-by: Lei Zhang <the...@chromium.org>
Owners-Override: Lei Zhang <the...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1555046}
Files:
- M cc/benchmarks/rasterize_and_record_benchmark_impl.cc
- M cc/layers/nine_patch_layer_impl_unittest.cc
- M cc/layers/painted_scrollbar_layer_impl_unittest.cc
- M cc/layers/ui_resource_layer_impl_unittest.cc
- M cc/resources/ui_resource_bitmap.cc
- M cc/resources/ui_resource_bitmap.h
- M cc/resources/ui_resource_manager.cc
- M cc/test/layer_tree_pixel_test.h
- M cc/tiles/tile_manager_unittest.cc
- M cc/trees/layer_tree_host_impl.cc
- M chrome/browser/permissions/prediction_service/permissions_ai_ui_selector.h
- M chrome/browser/thumbnail/cc/etc1_thumbnail_helper.cc
- M components/webapps/browser/banners/app_banner_manager.h
- M content/public/browser/render_widget_host_view.h
- M third_party/blink/public/web/web_element.h
- M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context.cc
- M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
- M third_party/blink/renderer/platform/graphics/canvas_resource_provider_test.cc
- M third_party/blink/renderer/platform/graphics/skia/skia_utils.h
Change size: S
Delta: 19 files changed, 16 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages