[Clipboard API] Enable ClipboardItemWithDOMStringSupport by default [chromium/src : main]

0 views
Skip to first unread message

Ayu Ishii (Gerrit)

unread,
Nov 12, 2024, 2:26:22 PMNov 12
to Sambamurthy Bandaru, Kent Tamura, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark, Kent Tamura, Rakesh Goulikar and Sambamurthy Bandaru

Ayu Ishii added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ayu Ishii . resolved

Change LG, but you'll need one more API owners LGTM (total of 3 LGTMs).

https://www.chromium.org/blink/guidelines/api-owners/procedures/

Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Kent Tamura
  • Rakesh Goulikar
  • Sambamurthy Bandaru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a1ea57d20cfe3e0b43e7a6d74e98f1626f12368
Gerrit-Change-Number: 6014375
Gerrit-PatchSet: 1
Gerrit-Owner: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 19:26:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dan Clark (Gerrit)

unread,
Nov 12, 2024, 2:36:26 PMNov 12
to Sambamurthy Bandaru, Kent Tamura, Chromium LUCI CQ, Rakesh Goulikar, Ayu Ishii, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ayu Ishii, Kent Tamura, Rakesh Goulikar and Sambamurthy Bandaru

Dan Clark added 1 comment

Patchset-level comments
Ayu Ishii . resolved

Change LG, but you'll need one more API owners LGTM (total of 3 LGTMs).

https://www.chromium.org/blink/guidelines/api-owners/procedures/

Dan Clark

In https://chromestatus.com/feature/4926138582040576 three owners have signed off, so I'd missed that there were only two on the thread. It looks like maybe Alex (slightlyoff@) signed off in the tool but forgot to reply to the thread. I'll ask for clarification there.

Open in Gerrit

Related details

Attention is currently required from:
  • Ayu Ishii
  • Kent Tamura
  • Rakesh Goulikar
  • Sambamurthy Bandaru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a1ea57d20cfe3e0b43e7a6d74e98f1626f12368
Gerrit-Change-Number: 6014375
Gerrit-PatchSet: 1
Gerrit-Owner: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Attention: Ayu Ishii <ay...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 19:36:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ayu Ishii <ay...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Ayu Ishii (Gerrit)

unread,
Nov 12, 2024, 4:01:08 PMNov 12
to Sambamurthy Bandaru, Kent Tamura, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark, Kent Tamura, Rakesh Goulikar and Sambamurthy Bandaru

Ayu Ishii voted and added 1 comment

Votes added by Ayu Ishii

Code-Review+1

1 comment

Patchset-level comments
Ayu Ishii . resolved

Change LG, but you'll need one more API owners LGTM (total of 3 LGTMs).

https://www.chromium.org/blink/guidelines/api-owners/procedures/

Dan Clark

In https://chromestatus.com/feature/4926138582040576 three owners have signed off, so I'd missed that there were only two on the thread. It looks like maybe Alex (slightlyoff@) signed off in the tool but forgot to reply to the thread. I'll ask for clarification there.

Ayu Ishii

Oh yes, I see. Thanks for pointing that out!

Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Kent Tamura
  • Rakesh Goulikar
  • Sambamurthy Bandaru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a1ea57d20cfe3e0b43e7a6d74e98f1626f12368
Gerrit-Change-Number: 6014375
Gerrit-PatchSet: 1
Gerrit-Owner: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 21:00:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ayu Ishii <ay...@chromium.org>
Comment-In-Reply-To: Dan Clark <dan...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Nov 12, 2024, 6:16:48 PMNov 12
to Sambamurthy Bandaru, Kent Tamura, Ayu Ishii, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark, Rakesh Goulikar and Sambamurthy Bandaru

Kent Tamura voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Rakesh Goulikar
  • Sambamurthy Bandaru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a1ea57d20cfe3e0b43e7a6d74e98f1626f12368
Gerrit-Change-Number: 6014375
Gerrit-PatchSet: 1
Gerrit-Owner: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 23:16:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sambamurthy Bandaru (Gerrit)

unread,
Nov 14, 2024, 2:05:56 AMNov 14
to Kent Tamura, Ayu Ishii, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark and Rakesh Goulikar

Sambamurthy Bandaru voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Rakesh Goulikar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a1ea57d20cfe3e0b43e7a6d74e98f1626f12368
Gerrit-Change-Number: 6014375
Gerrit-PatchSet: 1
Gerrit-Owner: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Attention: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Comment-Date: Thu, 14 Nov 2024 07:05:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sambamurthy Bandaru (Gerrit)

unread,
Nov 14, 2024, 10:31:54 AMNov 14
to Kent Tamura, Ayu Ishii, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Gerrit-Comment-Date: Thu, 14 Nov 2024 15:31:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 14, 2024, 10:35:15 AMNov 14
to Sambamurthy Bandaru, Kent Tamura, Ayu Ishii, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Clipboard API] Enable ClipboardItemWithDOMStringSupport by default

Enabling the feature after I2S approvals
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/w5kAP-CUyIU/m/uHDqBwoPBAAJ
Fixed: 40766145
Change-Id: I0a1ea57d20cfe3e0b43e7a6d74e98f1626f12368
Reviewed-by: Ayu Ishii <ay...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1382999}
Files:
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kent Tamura, +1 by Ayu Ishii
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a1ea57d20cfe3e0b43e7a6d74e98f1626f12368
Gerrit-Change-Number: 6014375
Gerrit-PatchSet: 2
Gerrit-Owner: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Rakesh Goulikar <rago...@microsoft.com>
Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages