[Clipboard API] Enable ClipboardItemWithDOMStringSupport by default [chromium/src : main]
0 views
Skip to first unread message
Ayu Ishii (Gerrit)
Nov 12, 2024, 2:26:22 PMNov 12
to Sambamurthy Bandaru, Kent Tamura, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark, Kent Tamura, Rakesh Goulikar and Sambamurthy Bandaru
Ayu Ishii added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ayu Ishii . resolved
Change LG, but you'll need one more API owners LGTM (total of 3 LGTMs).
https://www.chromium.org/blink/guidelines/api-owners/procedures/
Related details
Attention is currently required from:
- Dan Clark
- Kent Tamura
- Rakesh Goulikar
- Sambamurthy Bandaru
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dan Clark (Gerrit)
Nov 12, 2024, 2:36:26 PMNov 12
to Sambamurthy Bandaru, Kent Tamura, Chromium LUCI CQ, Rakesh Goulikar, Ayu Ishii, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ayu Ishii, Kent Tamura, Rakesh Goulikar and Sambamurthy Bandaru
Dan Clark added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Ayu Ishii . resolved
Change LG, but you'll need one more API owners LGTM (total of 3 LGTMs).
https://www.chromium.org/blink/guidelines/api-owners/procedures/
Dan Clark
In https://chromestatus.com/feature/4926138582040576 three owners have signed off, so I'd missed that there were only two on the thread. It looks like maybe Alex (slightlyoff@) signed off in the tool but forgot to reply to the thread. I'll ask for clarification there.
Related details
Attention is currently required from:
- Ayu Ishii
- Kent Tamura
- Rakesh Goulikar
- Sambamurthy Bandaru
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ayu Ishii (Gerrit)
Nov 12, 2024, 4:01:08 PMNov 12
to Sambamurthy Bandaru, Kent Tamura, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark, Kent Tamura, Rakesh Goulikar and Sambamurthy Bandaru
Ayu Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ayu Ishii
| Code-Review | +1 |
1 comment
Patchset-level comments
Ayu Ishii . resolved
Dan ClarkChange LG, but you'll need one more API owners LGTM (total of 3 LGTMs).
https://www.chromium.org/blink/guidelines/api-owners/procedures/
In https://chromestatus.com/feature/4926138582040576 three owners have signed off, so I'd missed that there were only two on the thread. It looks like maybe Alex (slightlyoff@) signed off in the tool but forgot to reply to the thread. I'll ask for clarification there.
Attention is currently required from:
- Dan Clark
- Kent Tamura
- Rakesh Goulikar
- Sambamurthy Bandaru
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Nov 12, 2024, 6:16:48 PMNov 12
to Sambamurthy Bandaru, Kent Tamura, Ayu Ishii, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark, Rakesh Goulikar and Sambamurthy Bandaru
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dan Clark
- Rakesh Goulikar
- Sambamurthy Bandaru
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sambamurthy Bandaru (Gerrit)
Nov 14, 2024, 2:05:56 AMNov 14
to Kent Tamura, Ayu Ishii, Chromium LUCI CQ, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark and Rakesh Goulikar
Sambamurthy Bandaru voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Dan Clark
- Rakesh Goulikar
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 14, 2024, 10:35:15 AMNov 14
to Sambamurthy Bandaru, Kent Tamura, Ayu Ishii, Rakesh Goulikar, Dan Clark, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Clipboard API] Enable ClipboardItemWithDOMStringSupport by default
Enabling the feature after I2S approvals
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/w5kAP-CUyIU/m/uHDqBwoPBAAJ
Fixed: 40766145
Change-Id: I0a1ea57d20cfe3e0b43e7a6d74e98f1626f12368
Reviewed-by: Ayu Ishii <ay...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Sambamurthy Bandaru <sambamurt...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1382999}
Files:
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura, +1 by Ayu Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages