[css-anchor-position] Remove crash tests using old APIs [chromium/src : main]
0 views
Skip to first unread message
Rune Lillesveen (Gerrit)
3:04 AM (3 hours ago) 3:04 AM
to Rune Lillesveen, Anders Hartvoll Ruud, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Rune Lillesveen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Rune Lillesveen . resolved
ptal
Since you added these tests, are you fine removing them, or do you want to rewrite them into something that would exercise this for the new APIs?
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
4:04 AM (2 hours ago) 4:04 AM
to Rune Lillesveen, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen
Anders Hartvoll Ruud voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
4:43 AM (2 hours ago) 4:43 AM
to Rune Lillesveen, Anders Hartvoll Ruud, chromium...@chromium.org, blink-...@chromium.org
Rune Lillesveen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:06 AM (1 hour ago) 5:06 AM
to Rune Lillesveen, Anders Hartvoll Ruud, chromium...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[css-anchor-position] Remove crash tests using old APIs
The alternative would be to adapt the tests to excercise the same code
with the new APIs and move the tests to wpt/.
Change-Id: I3db0d18c33fbb8d322f5f9ca1dd9dde5d21335fe
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Commit-Queue: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322658}
Files:
- D third_party/blink/web_tests/wpt_internal/css/css-anchor-position/anchor-in-multicol-crash.html
- D third_party/blink/web_tests/wpt_internal/css/css-anchor-position/anchor-in-multicol-inherit-crash.html
Change size: M
Delta: 2 files changed, 0 insertions(+), 101 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anders Hartvoll Ruud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages