RTCVDAdapter: Always delegate feature value in Vp9HWSupportForSL() [chromium/src : main]
Hirokazu Honda (Gerrit)
Attention is currently required from: Dale Curtis, Miguel Casas.
Hirokazu Honda would like Dale Curtis and Miguel Casas to review this change.
RTCVDAdapter: Always delegate feature value in Vp9HWSupportForSL()
Originally RTCVideoDecoderAdapter::Vp9HWSupportForSpatialLayers()
returns media::kVaapiVp9kSVCHWDecoding feature value on ChromeOS x86
devices and otherwise false.
Some ChromeOS ARM devices, but not all of them, are capable of
decoding SVC streams. So we need to handle this within a platform
VideoDecoders for ChromeOS ARM; if a VideoDecoder detects a VP9 SVC
stream is not supported, then it triggers a software decoder
fallback.
This CL changes the Vp9HWSupportForSpatialLayers() so that it returns
media::kVaapiVp9kSVCHWDecoding on all platforms. It enables keeping
the feature disabled on non ChromeOS platform and relies ChromeOS
video decoders for the judgement. This also drops "Vaapi" from the
feature name.
Bug: b:203747982
Test: Meet on volteer and trogdor
Change-Id: I422264229043e27b73022eb9bd65e6ad688cc046
---
M third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_adapter.cc
M media/base/media_switches.cc
M media/gpu/test/video_player/video_player_test_environment.cc
M media/gpu/vp9_decoder.cc
M media/base/media_switches.h
M media/gpu/v4l2/v4l2_stateful_workaround.cc
6 files changed, 70 insertions(+), 28 deletions(-)
To view, visit change 3230665. To unsubscribe, or for help writing mail filters, visit settings.
Hirokazu Honda (Gerrit)
Attention is currently required from: Dale Curtis, Miguel Casas.
1 comment:
Patchset:
PTAL.
To view, visit change 3230665. To unsubscribe, or for help writing mail filters, visit settings.
Dale Curtis (Gerrit)
Attention is currently required from: Hirokazu Honda, Miguel Casas.
Patch set 4:Code-Review +1
Hirokazu Honda (Gerrit)
Attention is currently required from: Miguel Casas.
1 comment:
Patchset:
Miguel, could you review this?
To view, visit change 3230665. To unsubscribe, or for help writing mail filters, visit settings.
Miguel Casas (Gerrit)
Attention is currently required from: Hirokazu Honda.
4 comments:
Patchset:
Oh I forgot to send the comments. Basically the only
Q is if it's OK to show the flag for all OSes, not
only for CrOS.
File media/base/media_switches.cc:
Patch Set #4, Line 552:
on ChromeOS.As the code stands, it'll be available to non-ChromeOS platforms,
is that intended? Or should it be availble only on CrOS, enabled
by default on X86 and disabled on ARM?
File media/gpu/test/video_player/video_player_test_environment.cc:
nit: indent?
File media/gpu/vp9_decoder.cc:
nit: remove {}
To view, visit change 3230665. To unsubscribe, or for help writing mail filters, visit settings.
Hirokazu Honda (Gerrit)
Attention is currently required from: Miguel Casas.
3 comments:
File media/base/media_switches.cc:
Patch Set #4, Line 552:
on ChromeOS.
As the code stands, it'll be available to non-ChromeOS platforms, […]
Removed.
Yes, it is intended to be visible on all OSs.
I do so for future development and also to reduces if-defined.
File media/gpu/test/video_player/video_player_test_environment.cc:
nit: indent?
Hmm, this is done by git-cl-format.
File media/gpu/vp9_decoder.cc:
nit: remove {}
Done
To view, visit change 3230665. To unsubscribe, or for help writing mail filters, visit settings.
Miguel Casas (Gerrit)
Attention is currently required from: Hirokazu Honda.
Patch set 5:Code-Review +1
Hirokazu Honda (Gerrit)
Patch set 5:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
RTCVDAdapter: Always delegate feature value in Vp9HWSupportForSL()
Originally RTCVideoDecoderAdapter::Vp9HWSupportForSpatialLayers()
returns media::kVaapiVp9kSVCHWDecoding feature value on ChromeOS x86
devices and otherwise false.
Some ChromeOS ARM devices, but not all of them, are capable of
decoding SVC streams. So we need to handle this within a platform
VideoDecoders for ChromeOS ARM; if a VideoDecoder detects a VP9 SVC
stream is not supported, then it triggers a software decoder
fallback.
This CL changes the Vp9HWSupportForSpatialLayers() so that it returns
media::kVaapiVp9kSVCHWDecoding on all platforms. It enables keeping
the feature disabled on non ChromeOS platform and relies ChromeOS
video decoders for the judgement. This also drops "Vaapi" from the
feature name.
Bug: b:203747982
Test: Meet on volteer and trogdor
Change-Id: I422264229043e27b73022eb9bd65e6ad688cc046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230665
Reviewed-by: Miguel Casas <mca...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Commit-Queue: Hirokazu Honda <hi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936257}
---
M third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_adapter.cc
M media/base/media_switches.cc
M media/gpu/test/video_player/video_player_test_environment.cc
M media/gpu/vp9_decoder.cc
M media/base/media_switches.h
M media/gpu/v4l2/v4l2_stateful_workaround.cc
6 files changed, 77 insertions(+), 30 deletions(-)