[Skeleton] Create a box for ::skeleton as a canvas background [chromium/src : main]

[Rune Lillesveen (Gerrit)]

Attention needed from Dave Tapuska and Morten Stenshorne

Rune Lillesveen voted and added 1 comment

Votes added by Rune Lillesveen

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Rune Lillesveen . resolved

dtapuska@ for audit_non_blink_usage.py

Open in Gerrit

Related details

Attention is currently required from:

• Dave Tapuska
• Morten Stenshorne

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8a7de189b077fe4c53eaee14e2aa765a33b73bb8

Gerrit-Change-Number: 7931650

Gerrit-PatchSet: 2

Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>

Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>

Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Jun 2026 12:32:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Dave Tapuska (Gerrit)]

Attention needed from Morten Stenshorne and Rune Lillesveen

Dave Tapuska voted and added 1 comment

Votes added by Dave Tapuska

Code-Review

+1

1 comment

File third_party/blink/renderer/core/skeleton/skeleton_pseudo_element.h

Line 8, Patchset 2 (Latest):#include "third_party/blink/public/mojom/frame/color_scheme.mojom-blink.h"

Dave Tapuska . unresolved

Use the blink-forward.h header here.

Open in Gerrit

Related details

Attention is currently required from:

• Morten Stenshorne
• Rune Lillesveen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8a7de189b077fe4c53eaee14e2aa765a33b73bb8

Gerrit-Change-Number: 7931650

Gerrit-PatchSet: 2

Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>

Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>

Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>

Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Jun 2026 17:40:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Morten Stenshorne (Gerrit)]

Attention needed from Rune Lillesveen

Morten Stenshorne voted and added 3 comments

Votes added by Morten Stenshorne

Code-Review

+1

3 comments

File third_party/blink/renderer/core/skeleton/skeleton_pseudo_element.cc

Line 28, Patchset 2 (Latest): // pseudo-element's box, and this pseudo0element's box will have LayoutView as

Morten Stenshorne . unresolved

```suggestion
  // pseudo-element's box, and this pseudo-element's box will have LayoutView as
```

Line 65, Patchset 2 (Latest):mojom::blink::ColorScheme SkeletonPseudoElement::SkeletonUsedColorScheme() {

Morten Stenshorne . unresolved

Mismatch between declaration order and definition order. SkeletonUsedColorScheme() comes last in the .h file.

Line 94, Patchset 2 (Latest): ComputedStyleBuilder builder =

Morten Stenshorne . unresolved

Perhaps a comment about what we're trying to achieve with this style?

Open in Gerrit

Related details

Attention is currently required from:

• Rune Lillesveen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8a7de189b077fe4c53eaee14e2aa765a33b73bb8

Gerrit-Change-Number: 7931650

Gerrit-PatchSet: 2

Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>

Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>

Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Jun 2026 18:02:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Rune Lillesveen (Gerrit)]

Rune Lillesveen added 4 comments

File third_party/blink/renderer/core/skeleton/skeleton_pseudo_element.h

Line 8, Patchset 2:#include "third_party/blink/public/mojom/frame/color_scheme.mojom-blink.h"

Dave Tapuska . resolved

Use the blink-forward.h header here.

Rune Lillesveen

Done

File third_party/blink/renderer/core/skeleton/skeleton_pseudo_element.cc

Line 28, Patchset 2: // pseudo-element's box, and this pseudo0element's box will have LayoutView as

Morten Stenshorne . resolved

```suggestion
  // pseudo-element's box, and this pseudo-element's box will have LayoutView as
```

Rune Lillesveen

Done

Line 65, Patchset 2:mojom::blink::ColorScheme SkeletonPseudoElement::SkeletonUsedColorScheme() {

Morten Stenshorne . resolved

Mismatch between declaration order and definition order. SkeletonUsedColorScheme() comes last in the .h file.

Rune Lillesveen

There were pre-existing ordering differences too. I'm typically not strict about this.

Line 94, Patchset 2: ComputedStyleBuilder builder =

Morten Stenshorne . resolved

Perhaps a comment about what we're trying to achieve with this style?

Rune Lillesveen

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8a7de189b077fe4c53eaee14e2aa765a33b73bb8

Gerrit-Change-Number: 7931650

Gerrit-PatchSet: 4

Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>

Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>

Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Mon, 15 Jun 2026 09:00:13 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Morten Stenshorne <mste...@chromium.org>

Comment-In-Reply-To: Dave Tapuska <dtap...@chromium.org>

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/renderer/core/skeleton/skeleton_pseudo_element.h
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/renderer/core/skeleton/skeleton_pseudo_element.cc
Insertions: 5, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[Skeleton] Create a box for ::skeleton as a canvas background

Previously, a skeleton without an opaque specified root or body
background would have the hosting page rendered behind it.

Use the used color-scheme value of the skeleton root element to set the
background color.

Bug: 513276602

Change-Id: I8a7de189b077fe4c53eaee14e2aa765a33b73bb8

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7931650

Reviewed-by: Dave Tapuska <dtap...@chromium.org>

Reviewed-by: Morten Stenshorne <mste...@chromium.org>

Commit-Queue: Rune Lillesveen <fut...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1646695}

Files:

• M third_party/blink/renderer/core/dom/pseudo_element.h
• M third_party/blink/renderer/core/skeleton/skeleton_loader_test.cc
• M third_party/blink/renderer/core/skeleton/skeleton_pseudo_element.cc
• M third_party/blink/renderer/core/skeleton/skeleton_pseudo_element.h
• M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py

Change size: M

Delta: 5 files changed, 154 insertions(+), 23 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Morten Stenshorne, +1 by Dave Tapuska

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8a7de189b077fe4c53eaee14e2aa765a33b73bb8

Gerrit-Change-Number: 7931650

Gerrit-PatchSet: 5

Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>

Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: chromium...@chromium.org