Reland "Implement border-shape hit testing" [chromium/src : main]

0 views
Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 1, 2025, 3:13:38 PM12/1/25
to Daniil Sakhapov, Chromium LUCI CQ, Philip Rogers, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job win-11-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15981c59310000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 3
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 20:13:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
Dec 1, 2025, 3:37:42 PM12/1/25
to chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, Philip Rogers, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov, Noam Rosenthal and Philip Rogers

Message from Daniil Sakhapov

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Noam Rosenthal
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 3
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 20:37:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 1, 2025, 3:39:14 PM12/1/25
to Daniil Sakhapov, Chromium LUCI CQ, Philip Rogers, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov, Noam Rosenthal and Philip Rogers

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17706772310000

Gerrit-Comment-Date: Mon, 01 Dec 2025 20:39:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 1, 2025, 3:58:39 PM12/1/25
to Daniil Sakhapov, Chromium LUCI CQ, Philip Rogers, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov, Noam Rosenthal and Philip Rogers

Message from chrom...@appspot.gserviceaccount.com

📍 Job android-pixel4-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15348f06310000

Gerrit-Comment-Date: Mon, 01 Dec 2025 20:58:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Dec 1, 2025, 8:13:53 PM12/1/25
to Daniil Sakhapov, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Noam Rosenthal

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Philip Rogers . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 3
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 01:13:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Blink W3C Test Autoroller (Gerrit)

unread,
Dec 1, 2025, 8:27:03 PM12/1/25
to Daniil Sakhapov, Philip Rogers, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, Noam Rosenthal, AyeAye, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Noam Rosenthal

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/56394.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Gerrit-Comment-Date: Tue, 02 Dec 2025 01:26:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Dec 2, 2025, 12:25:44 PM12/2/25
to Daniil Sakhapov, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Noam Rosenthal

Philip Rogers voted and added 2 comments

Votes added by Philip Rogers

Code-Review+0

2 comments

Patchset-level comments
Philip Rogers . unresolved

Hi Daniil, sorry, I +1'd because I thought the pinpoints were good, but I see they are not.

The perf test is third_party/blink/perf_tests/layout/hittest-block-children.html. Can you open this in a regular profiler and determine where it is slow? I took a quick look with this patch (https://screenshot.googleplex.com/AzLACuh6F25c2d9) and I don't see anything obviously wrong, so I think you will need to compare profiles with patch vs without patch. One possibility is that HitTestChildren is called more, maybe due to skip_children changes in LayoutBox::NodeAtPoint?

File third_party/blink/renderer/core/layout/layout_box_hot.cc
Line 5, Patchset 3 (Parent):#include "third_party/blink/renderer/core/layout/layout_box.h"
Philip Rogers . unresolved

Why this change?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 3
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 17:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 3, 2025, 5:06:33 PM12/3/25
to Daniil Sakhapov, Philip Rogers, Chromium LUCI CQ, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Noam Rosenthal

Message from chrom...@appspot.gserviceaccount.com

📍 Job win-11-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11b39181310000

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 4
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 22:06:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 3, 2025, 5:22:33 PM12/3/25
to Daniil Sakhapov, Philip Rogers, Chromium LUCI CQ, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Noam Rosenthal

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17db973d310000

Gerrit-Comment-Date: Wed, 03 Dec 2025 22:22:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 3, 2025, 5:37:12 PM12/3/25
to Daniil Sakhapov, Philip Rogers, Chromium LUCI CQ, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Noam Rosenthal

Message from chrom...@appspot.gserviceaccount.com

📍 Job android-pixel4-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/179979c9310000

Gerrit-Comment-Date: Wed, 03 Dec 2025 22:37:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Dec 3, 2025, 5:38:16 PM12/3/25
to Daniil Sakhapov, Philip Rogers, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Noam Rosenthal

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/core/layout/scrollable_overflow_calculator.cc
Line 276, Patchset 4 (Latest): }
Ian Kilpatrick . unresolved

Where is this specified?

Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 22:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Dec 3, 2025, 5:39:09 PM12/3/25
to Daniil Sakhapov, Philip Rogers, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, Noam Rosenthal, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Noam Rosenthal

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/core/layout/scrollable_overflow_calculator.cc
Line 267, Patchset 4 (Latest): }
Ian Kilpatrick . unresolved

This is also incorrect if fragmented.

Gerrit-Comment-Date: Wed, 03 Dec 2025 22:38:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 3, 2025, 7:40:48 PM12/3/25
to Daniil Sakhapov, Ian Kilpatrick, Philip Rogers, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/153a7a43310000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 5
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Dec 2025 00:40:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Dec 3, 2025, 7:45:00 PM12/3/25
to Daniil Sakhapov, Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov

Philip Rogers added 1 comment

File third_party/blink/renderer/core/layout/layout_box_hot.cc
Line 74, Patchset 4: if (HasHitTestableOverflow()) {
Philip Rogers . unresolved

This looks a little suspicious. With hit testable overflow and clip, the old code would do:
overflow_box = VisualOverflowRect();
overflow_box.Intersect(OverflowClipRect(PhysicalOffset()));
overflow_box.Unite(PhysicalBorderBoxRect());

The new code does:
overflow_box = PhysicalBorderBoxRect();
PhysicalRect visual_overflow = VisualOverflowRect();
visual_overflow.Intersect(OverflowClipRect(PhysicalOffset()));
overflow_box.Unite(visual_overflow);

I didn't verify this is different, just seems like it may be.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 5
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Dec 2025 00:44:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 3, 2025, 7:53:44 PM12/3/25
to Daniil Sakhapov, Ian Kilpatrick, Philip Rogers, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov

Message from chrom...@appspot.gserviceaccount.com

📍 Job android-pixel4-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10926db5310000

Gerrit-Comment-Date: Thu, 04 Dec 2025 00:53:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
Jan 16, 2026, 7:46:08 AM (yesterday) Jan 16
to Ian Kilpatrick, Philip Rogers, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Ian Kilpatrick and Philip Rogers

Daniil Sakhapov voted and added 4 comments

Votes added by Daniil Sakhapov

Commit-Queue+1

4 comments

File third_party/blink/renderer/core/layout/layout_box_hot.cc
Line 5, Patchset 3 (Parent):#include "third_party/blink/renderer/core/layout/layout_box.h"
Philip Rogers . unresolved

Why this change?

Daniil Sakhapov

ah, git cl format keeps moving that thing for me 😊

Line 74, Patchset 4: if (HasHitTestableOverflow()) {
Philip Rogers . resolved

This looks a little suspicious. With hit testable overflow and clip, the old code would do:
overflow_box = VisualOverflowRect();
overflow_box.Intersect(OverflowClipRect(PhysicalOffset()));
overflow_box.Unite(PhysicalBorderBoxRect());

The new code does:
overflow_box = PhysicalBorderBoxRect();
PhysicalRect visual_overflow = VisualOverflowRect();
visual_overflow.Intersect(OverflowClipRect(PhysicalOffset()));
overflow_box.Unite(visual_overflow);

I didn't verify this is different, just seems like it may be.

Daniil Sakhapov

updated back to the correct way now

File third_party/blink/renderer/core/layout/scrollable_overflow_calculator.cc
Ian Kilpatrick . unresolved

This is also incorrect if fragmented.

Daniil Sakhapov

yes, but we decided to start with a simple case and improve afterwards

Ian Kilpatrick . unresolved

Where is this specified?

Daniil Sakhapov

it's not yet specced, but we agreed with Morten and Noam that having overscroll for border-shape would make the most sense here.

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 6
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 12:45:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Philip Rogers <p...@chromium.org>
Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jan 16, 2026, 8:51:25 AM (yesterday) Jan 16
to Daniil Sakhapov, Ian Kilpatrick, Philip Rogers, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov, Ian Kilpatrick and Philip Rogers

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1562b67c710000

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Ian Kilpatrick
  • Philip Rogers
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 13:51:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jan 16, 2026, 9:16:14 AM (yesterday) Jan 16
to Daniil Sakhapov, Ian Kilpatrick, Philip Rogers, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov, Ian Kilpatrick and Philip Rogers

Message from chrom...@appspot.gserviceaccount.com

📍 Job android-pixel4-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/120288b8710000

Gerrit-Comment-Date: Fri, 16 Jan 2026 14:15:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Jan 16, 2026, 4:13:07 PM (21 hours ago) Jan 16
to Daniil Sakhapov, Philip Rogers, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov and Philip Rogers

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/core/layout/scrollable_overflow_calculator.cc
Ian Kilpatrick . unresolved

Where is this specified?

Daniil Sakhapov

it's not yet specced, but we agreed with Morten and Noam that having overscroll for border-shape would make the most sense here.

Ian Kilpatrick

So I'm not sure it does, e.g. we don't for other decoration like things such as box-shadow.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Philip Rogers
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 21:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>
Comment-In-Reply-To: Daniil Sakhapov <sakh...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Jan 16, 2026, 8:35:34 PM (16 hours ago) Jan 16
to Daniil Sakhapov, Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, AI Code Reviewer, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Daniil Sakhapov

Philip Rogers added 1 comment

File third_party/blink/renderer/core/layout/layout_box_hot.cc
Line 66, Patchset 6 (Latest): if (StyleRef().HasBorderShape()) {
Philip Rogers . unresolved

Theory: is accessing this StyleRef() causing us to pull a big object into the cache? Previously, this function didn't need to use StyleRef, but now it does. Can we use a bitfield check like `HasScrollableOverflow` to avoid accessing data on styleref in the common case?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I645f92710256c2004b3655bd2b4a0e958659f95b
Gerrit-Change-Number: 7204017
Gerrit-PatchSet: 6
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Comment-Date: Sat, 17 Jan 2026 01:35:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages