[Indigo] Anchor toolbar by tracking image bounds [chromium/src : main]

1 view
Skip to first unread message

Jeremy Roman (Gerrit)

unread,
May 25, 2026, 6:25:23 PM (9 hours ago) May 25
to Jeremy Roman, Adithya Srinivasan, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-re...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Adithya Srinivasan

Jeremy Roman added 1 comment

Patchset-level comments
File-level comment, Patchset 18 (Latest):
Jeremy Roman . resolved

This doesn't deal with headers that occlude the content (the next CL in the chain does -- it needs additional cleanup but I've ran the basic idea by Khushal). But it does do most of the indigo toolbar changes to make it start to track the element.

Open in Gerrit

Related details

Attention is currently required from:
  • Adithya Srinivasan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I568a710e329d54949ab7be5b7e1fcd314eac9b24
Gerrit-Change-Number: 7871317
Gerrit-PatchSet: 18
Gerrit-Owner: Jeremy Roman <jbr...@chromium.org>
Gerrit-Reviewer: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Comment-Date: Mon, 25 May 2026 22:25:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages