[Clank] Propagate focused web element HTML metadata to EditorInfo [chromium/src : main]

1 view
Skip to first unread message

Darren Shen (Gerrit)

unread,
May 19, 2026, 10:54:03 PM (6 days ago) May 19
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Zhe Su, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Darren Shen voted Commit-Queue+1

Uploaded PS5 with fixes for:
1. C++ compilation errors in input_method_controller.cc (const violation and missing include).
2. JNI Optional-to-String bug in ime_adapter_android.cc (passing null instead of empty string for absent optionals to preserve Java fallback logic).
3. Verified locally with JUnit tests.

Triggering CQ dry run.

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic890c0f635c5076901d8db30273ece3fffcfa2fe
Gerrit-Change-Number: 7859134
Gerrit-PatchSet: 5
Gerrit-Owner: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
Gerrit-CC: Zhe Su <su...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 02:53:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Darren Shen (Gerrit)

unread,
May 20, 2026, 2:25:44 AM (6 days ago) May 20
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Zhe Su, alexmit...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Darren Shen voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic890c0f635c5076901d8db30273ece3fffcfa2fe
Gerrit-Change-Number: 7859134
Gerrit-PatchSet: 7
Gerrit-Comment-Date: Wed, 20 May 2026 06:25:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chuong Ho (Gerrit)

unread,
May 22, 2026, 2:05:46 AM (4 days ago) May 22
to Darren Shen, Michael Cui, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Zhe Su, alexmit...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Darren Shen and Michael Cui

Chuong Ho voted and added 3 comments

Votes added by Chuong Ho

Code-Review+1

3 comments

File content/browser/android/ime_adapter_android.cc
Line 229, Patchset 9 (Latest): ScopedJavaLocalRef<jstring> jstring_html_label =
Chuong Ho . unresolved

can you follow `jstring_text` for consistency?

File content/public/android/java/src/org/chromium/content/browser/input/ImeAdapterImpl.java
Line 190, Patchset 9 (Latest): private @Nullable String mHtmlLabel;
private @Nullable String mHtmlName;
private @Nullable String mHtmlId;
private @Nullable String mHtmlPlaceholder;
Chuong Ho . resolved

feel like these often come together, probably can package them in a class.

Line 769, Patchset 9 (Latest): mHtmlLabel = htmlLabel;
mHtmlName = htmlName;
mHtmlId = htmlId;
mHtmlPlaceholder = htmlPlaceholder;
Chuong Ho . unresolved

Can we move these to around line 825-811 for consistency?

Open in Gerrit

Related details

Attention is currently required from:
  • Darren Shen
  • Michael Cui
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic890c0f635c5076901d8db30273ece3fffcfa2fe
    Gerrit-Change-Number: 7859134
    Gerrit-PatchSet: 9
    Gerrit-Owner: Darren Shen <sh...@chromium.org>
    Gerrit-Reviewer: Chuong Ho <hdch...@chromium.org>
    Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
    Gerrit-Reviewer: Michael Cui <ml...@google.com>
    Gerrit-Attention: Darren Shen <sh...@chromium.org>
    Gerrit-Attention: Michael Cui <ml...@google.com>
    Gerrit-Comment-Date: Fri, 22 May 2026 06:05:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Chuong Ho (Gerrit)

    unread,
    May 22, 2026, 2:12:43 AM (4 days ago) May 22
    to Darren Shen, Bo Liu, Michael Cui, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Zhe Su, alexmit...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Bo Liu, Darren Shen and Michael Cui

    Chuong Ho added 1 comment

    Patchset-level comments
    File-level comment, Patchset 9 (Latest):
    Chuong Ho . resolved

    LGTM but please loop @bo...@chromium.org to review this CL as well.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bo Liu
    • Darren Shen
    • Michael Cui
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic890c0f635c5076901d8db30273ece3fffcfa2fe
    Gerrit-Change-Number: 7859134
    Gerrit-PatchSet: 9
    Gerrit-Owner: Darren Shen <sh...@chromium.org>
    Gerrit-Reviewer: Chuong Ho <hdch...@chromium.org>
    Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
    Gerrit-Reviewer: Michael Cui <ml...@google.com>
    Gerrit-CC: Bo Liu <bo...@chromium.org>
    Gerrit-CC: Zhe Su <su...@chromium.org>
    Gerrit-Attention: Darren Shen <sh...@chromium.org>
    Gerrit-Attention: Michael Cui <ml...@google.com>
    Gerrit-Attention: Bo Liu <bo...@chromium.org>
    Gerrit-Comment-Date: Fri, 22 May 2026 06:12:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Bo Liu (Gerrit)

    unread,
    May 25, 2026, 10:58:15 PM (4 hours ago) May 25
    to Darren Shen, Bo Liu, Chuong Ho, Michael Cui, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Zhe Su, alexmit...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Darren Shen and Michael Cui

    Bo Liu added 6 comments

    File content/browser/android/ime_adapter_android.cc
    Line 229, Patchset 9 (Latest): ScopedJavaLocalRef<jstring> jstring_html_label =
    Chuong Ho . unresolved

    can you follow `jstring_text` for consistency?

    Bo Liu

    as in use value_or?

    value_or one will return empty string for nullopt, but this will return null, which appears to be intentional?

    File content/public/android/java/src/org/chromium/content/browser/input/ImeAdapterImpl.java
    Line 755, Patchset 9 (Latest): String htmlLabel,
    Bo Liu . unresolved

    these are @Nullable, as implemented on native side

    File content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
    Line 64, Patchset 9 (Latest): if (htmlLabel != null) {
    Bo Liu . unresolved

    how will these be used? does it make any sense to put some length limit on any of these? (maybe before it gets to java to be slightly more efficient)

    Line 64, Patchset 9 (Latest): if (htmlLabel != null) {
    Bo Liu . unresolved

    are the null checks necessary?

    Line 69, Patchset 9 (Latest): } else if (htmlId != null) {
    Bo Liu . unresolved

    I guess if only one is needed, more efficient to only send up one of them through jni

    File ui/base/ime/mojom/text_input_state.mojom
    Line 82, Patchset 9 (Latest): mojo_base.mojom.String16? html_label;
    Bo Liu . unresolved

    should any of these be BigString?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Darren Shen
    • Michael Cui
    Gerrit-Comment-Date: Tue, 26 May 2026 02:58:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Chuong Ho <hdch...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages