[MSan] Fix use-after-dtor error in DeskSyncBridgeTest [chromium/src : main]
0 views
Skip to first unread message
Daniel Cheng (Gerrit)
Jul 2, 2024, 1:25:38 PMJul 2
to Daniel Cheng, Matthew Zhu, Chromium LUCI CQ, chromium...@chromium.org, ajayramamurthy...@google.com, alemat...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, dullweb...@chromium.org, hansberry+wa...@chromium.org, jackshira+wa...@google.com, joeantonetti+...@google.com, jonmann+wat...@chromium.org, msrame...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rhalava...@chromium.org, rrsilva+wat...@google.com
Attention needed from Matthew Zhu
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Matthew Zhu
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Zhu (Gerrit)
Jul 2, 2024, 1:33:35 PMJul 2
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, ajayramamurthy...@google.com, alemat...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, dullweb...@chromium.org, hansberry+wa...@chromium.org, jackshira+wa...@google.com, joeantonetti+...@google.com, jonmann+wat...@chromium.org, msrame...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rhalava...@chromium.org, rrsilva+wat...@google.com
Attention needed from Daniel Cheng
Matthew Zhu voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jul 3, 2024, 1:04:01 AMJul 3
to Daniel Cheng, Enterprise Policy Reviews, Matthew Zhu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ajayramamurthy...@google.com, alemat...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, dullweb...@chromium.org, hansberry+wa...@chromium.org, jackshira+wa...@google.com, joeantonetti+...@google.com, jonmann+wat...@chromium.org, msrame...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rhalava...@chromium.org, rrsilva+wat...@google.com
Daniel Cheng voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 3, 2024, 1:07:23 AMJul 3
to Daniel Cheng, Enterprise Policy Reviews, Matthew Zhu, chromium...@chromium.org, feature-me...@chromium.org, ajayramamurthy...@google.com, alemat...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, dullweb...@chromium.org, hansberry+wa...@chromium.org, jackshira+wa...@google.com, joeantonetti+...@google.com, jonmann+wat...@chromium.org, msrame...@chromium.org, print-rev...@chromium.org, pushi+watc...@google.com, rhalava...@chromium.org, rrsilva+wat...@google.com
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[MSan] Fix use-after-dtor error in DeskSyncBridgeTest
Destroying DeskSyncBridge notifies its observers, so the test fixture's
observer (MockDeskModelObserver) must outlive the DeskSyncBridge.
Bug: 40222690
Change-Id: I17ce3d51bd64a4710c09d43ae949105859776ba0
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Matthew Zhu <zhuma...@google.com>
Cr-Commit-Position: refs/heads/main@{#1322580}
Files:
- M components/desks_storage/core/desk_sync_bridge_unittest.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matthew Zhu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages