Move blink WebID mojom bindings to a dedicated target [chromium/src : main]

[Adem Derinel (Gerrit)]

Attention needed from Daniel Cheng

Adem Derinel added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Adem Derinel . resolved

Hi Daniel could you PTAL at the blink changes? Thanks in advance!

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d5406e79dbd115de15f0969f0a0a709e832d888

Gerrit-Change-Number: 7531775

Gerrit-PatchSet: 11

Gerrit-Owner: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Thu, 29 Jan 2026 15:23:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Daniel Cheng (Gerrit)]

Attention needed from Adem Derinel

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Daniel Cheng . unresolved

Does this otherwise result in some sort of circular dependency? The CL description does state what this is for, but it's less clear to me why this needs to happen.

Open in Gerrit

Related details

Attention is currently required from:

• Adem Derinel

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d5406e79dbd115de15f0969f0a0a709e832d888

Gerrit-Change-Number: 7531775

Gerrit-PatchSet: 11

Gerrit-Owner: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Adem Derinel <der...@google.com>

Gerrit-Comment-Date: Thu, 29 Jan 2026 18:03:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Adem Derinel (Gerrit)]

Attention needed from Daniel Cheng

Adem Derinel added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Daniel Cheng . unresolved

Does this otherwise result in some sort of circular dependency? The CL description does state what this is for, but it's less clear to me why this needs to happen.

Adem Derinel

We don't want to depend on `:mojom_platform` from `:authenticator_mojo_bindings`. That'd be a circular dependency.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d5406e79dbd115de15f0969f0a0a709e832d888

Gerrit-Change-Number: 7531775

Gerrit-PatchSet: 11

Gerrit-Owner: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Fri, 30 Jan 2026 07:29:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>

[Daniel Cheng (Gerrit)]

Attention needed from Adem Derinel

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Daniel Cheng . unresolved

Does this otherwise result in some sort of circular dependency? The CL description does state what this is for, but it's less clear to me why this needs to happen.

Adem Derinel

We don't want to depend on `:mojom_platform` from `:authenticator_mojo_bindings`. That'd be a circular dependency.

Daniel Cheng

I think mention something about this being a circular dependency otherwise in the CL description then.

Open in Gerrit

Related details

Attention is currently required from:

• Adem Derinel

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d5406e79dbd115de15f0969f0a0a709e832d888

Gerrit-Change-Number: 7531775

Gerrit-PatchSet: 11

Gerrit-Owner: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Adem Derinel <der...@google.com>

Gerrit-Comment-Date: Fri, 30 Jan 2026 07:39:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Adem Derinel <der...@google.com>

Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>

[Adem Derinel (Gerrit)]

Attention needed from Yi Gu

Adem Derinel added 2 comments

Patchset-level comments

File-level comment, Patchset 11:

Daniel Cheng . resolved

Does this otherwise result in some sort of circular dependency? The CL description does state what this is for, but it's less clear to me why this needs to happen.

Adem Derinel

We don't want to depend on `:mojom_platform` from `:authenticator_mojo_bindings`. That'd be a circular dependency.

Daniel Cheng

I think mention something about this being a circular dependency otherwise in the CL description then.

Adem Derinel

Sure, done :)

File-level comment, Patchset 11:

Adem Derinel . resolved

Hi Yi, could you PTAL at c/b/**/webid/ ? Thanks in advance!

Open in Gerrit

Related details

Attention is currently required from:

• Yi Gu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d5406e79dbd115de15f0969f0a0a709e832d888

Gerrit-Change-Number: 7531775

Gerrit-PatchSet: 12

Gerrit-Owner: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Yi Gu <yi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Yi Gu <yi...@chromium.org>

Gerrit-Comment-Date: Fri, 30 Jan 2026 08:47:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Yi Gu (Gerrit)]

Attention needed from Adem Derinel and Christian Biesinger

Yi Gu added 1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Yi Gu . resolved

Hi Christian could you take a look?

Open in Gerrit

Related details

Attention is currently required from:

• Adem Derinel
• Christian Biesinger

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d5406e79dbd115de15f0969f0a0a709e832d888

Gerrit-Change-Number: 7531775

Gerrit-PatchSet: 12

Gerrit-Owner: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Yi Gu <yi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>

Gerrit-Attention: Adem Derinel <der...@google.com>

Gerrit-Comment-Date: Fri, 30 Jan 2026 14:42:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Christian Biesinger (Gerrit)]

Attention needed from Adem Derinel

Christian Biesinger voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adem Derinel

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d5406e79dbd115de15f0969f0a0a709e832d888

Gerrit-Change-Number: 7531775

Gerrit-PatchSet: 12

Gerrit-Owner: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Yi Gu <yi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Adem Derinel <der...@google.com>

Gerrit-Comment-Date: Fri, 30 Jan 2026 15:28:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Adem Derinel (Gerrit)]

Adem Derinel abandoned this change.

View Change

Abandoned

Adem Derinel abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3d5406e79dbd115de15f0969f0a0a709e832d888

Gerrit-Change-Number: 7531775

Gerrit-PatchSet: 13

Gerrit-Owner: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Adem Derinel <der...@google.com>

Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Yi Gu <yi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>