[DirectSockets] Relax the CrossOriginCapability requirement for workers [chromium/src : main]

0 views
Skip to first unread message

Andrew Rayskiy (Gerrit)

unread,
Apr 7, 2025, 6:14:35 AM4/7/25
to Simon Hangl, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, rmcelra...@chromium.org
Attention needed from Simon Hangl

Andrew Rayskiy voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Simon Hangl
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1d90879d5fc954c3f749b1dcba1d11dd4bdd1f0
Gerrit-Change-Number: 6434162
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-Attention: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Mon, 07 Apr 2025 10:14:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simon Hangl (Gerrit)

unread,
Apr 7, 2025, 6:16:05 AM4/7/25
to Andrew Rayskiy, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy

Simon Hangl voted and added 1 comment

Votes added by Simon Hangl

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1d90879d5fc954c3f749b1dcba1d11dd4bdd1f0
Gerrit-Change-Number: 6434162
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-Attention: Andrew Rayskiy <green...@google.com>
Gerrit-Comment-Date: Mon, 07 Apr 2025 10:15:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Rayskiy (Gerrit)

unread,
Apr 7, 2025, 8:39:37 AM4/7/25
to Simon Hangl, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, rmcelra...@chromium.org

Andrew Rayskiy voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1d90879d5fc954c3f749b1dcba1d11dd4bdd1f0
Gerrit-Change-Number: 6434162
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Mon, 07 Apr 2025 12:39:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 7, 2025, 8:44:27 AM4/7/25
to Andrew Rayskiy, Simon Hangl, AyeAye, chromium...@chromium.org, blink-...@chromium.org, rmcelra...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[DirectSockets] Relax the CrossOriginCapability requirement for workers

Chrome Apps are allowed to use Direct Sockets even without specifying
cross-origin isolation in the manifest; for this reason we have to
check just the permissions-policy feature and not the entire capability.
Bug: 407883159
Change-Id: Ie1d90879d5fc954c3f749b1dcba1d11dd4bdd1f0
Commit-Queue: Andrew Rayskiy <green...@google.com>
Auto-Submit: Andrew Rayskiy <green...@google.com>
Reviewed-by: Simon Hangl <sim...@google.com>
Cr-Commit-Position: refs/heads/main@{#1443405}
Files:
  • M chrome/browser/direct_sockets/direct_sockets_apitest.cc
  • M third_party/blink/renderer/modules/direct_sockets/socket.cc
Change size: M
Delta: 2 files changed, 80 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Simon Hangl
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1d90879d5fc954c3f749b1dcba1d11dd4bdd1f0
Gerrit-Change-Number: 6434162
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages