CHECK token type in ConsumeVariableName [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Mar 7, 2026, 1:35:07 PMMar 7
to Daniel Rubery, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Daniel Rubery
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Daniel Rubery
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Mar 7, 2026, 6:59:39 PMMar 7
to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Daniel Rubery voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Mar 9, 2026, 6:14:03 AMMar 9
to Daniel Rubery, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 9, 2026, 7:07:12 AMMar 9
to Anders Hartvoll Ruud, Daniel Rubery, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CHECK token type in ConsumeVariableName
CL:7595347, CL:7600415, and CL:7606599 already fixed Issue 484751092,
however they are too complicated to backport safely.
Using a CHECK here eliminates any security issues that could
arise from failing the DCHECK.
Bug: 484751092
Change-Id: I676362a5009259652b973abaafd7f3ee35435abc
Reviewed-by: Daniel Rubery <dru...@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1596248}
Files:
- M third_party/blink/renderer/core/css/resolver/style_cascade.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Rubery
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages