Add keywords for min-inline-size [chromium/src : main]
0 views
Skip to first unread message
Samiya Caur (Gerrit)
Jun 15, 2026, 3:51:08 AM (9 days ago) Jun 15
to Rune Lillesveen, Alex Rudenko, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Attention needed from Alex Rudenko and Rune Lillesveen
Samiya Caur voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alex Rudenko
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Jun 15, 2026, 3:53:04 AM (9 days ago) Jun 15
to Samiya Caur, Chromium LUCI CQ, Rune Lillesveen, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen and Samiya Caur
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rune Lillesveen
- Samiya Caur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Jun 15, 2026, 4:06:44 AM (9 days ago) Jun 15
to Samiya Caur, Alex Rudenko, Chromium LUCI CQ, Rune Lillesveen, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Attention needed from Samiya Caur
Rune Lillesveen added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/css/css_properties.json5
Line 8088, Patchset 1 (Latest):
keywords: ["auto", "min-content", "max-content", "fit-content"],Rune Lillesveen . unresolved
Our parser accepts 'stretch', it seems?
Tip: follow the code from ::ParseSingleValue() for the respective property to see what we're actually supporting.
You may combine multiple properties in the same CL, in particular if they support the same basic types. My comment in the first CL was about fully finish the list for a given property in a single CL.
Related details
Attention is currently required from:
- Samiya Caur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samiya Caur (Gerrit)
Jun 15, 2026, 5:36:10 AM (9 days ago) Jun 15
to Alex Rudenko, Chromium LUCI CQ, Rune Lillesveen, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Attention needed from Alex Rudenko and Rune Lillesveen
Samiya Caur voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samiya Caur
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File third_party/blink/renderer/core/css/css_properties.json5
Line 8088, Patchset 1:
keywords: ["auto", "min-content", "max-content", "fit-content"],Rune Lillesveen . resolved
Our parser accepts 'stretch', it seems?
Tip: follow the code from ::ParseSingleValue() for the respective property to see what we're actually supporting.
You may combine multiple properties in the same CL, in particular if they support the same basic types. My comment in the first CL was about fully finish the list for a given property in a single CL.
Attention is currently required from:
- Alex Rudenko
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Jun 15, 2026, 5:38:57 AM (9 days ago) Jun 15
to Samiya Caur, Chromium LUCI CQ, Rune Lillesveen, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen and Samiya Caur
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rune Lillesveen
- Samiya Caur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Jun 15, 2026, 6:18:30 AM (9 days ago) Jun 15
to Samiya Caur, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Attention needed from Samiya Caur
Rune Lillesveen voted![]( "Open in Gerrit")
Attention is currently required from:
- Samiya Caur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 15, 2026, 6:47:07 AM (8 days ago) Jun 15
to Samiya Caur, Rune Lillesveen, Alex Rudenko, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add keywords for min-inline-size
Bug: 446108436
Change-Id: Id62cf35fceadd6252e15a1ecac34c2d160288fde
Auto-Submit: Samiya Caur <sam...@chromium.org>
Commit-Queue: Rune Lillesveen <fut...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Commit-Queue: Samiya Caur <sam...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1646702}
Files:
- M third_party/blink/renderer/core/css/css_properties.json5
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko, +1 by Rune Lillesveen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages