Pass const BasicShape& to Shape::CreateShape() [chromium/src : main]
0 views
Skip to first unread message
Fredrik Söderquist (Gerrit)
4:18 AM (10 hours ago) 4:18 AM
to Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
12:08 PM (2 hours ago) 12:08 PM
to Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist
Ian Kilpatrick voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
12:38 PM (2 hours ago) 12:38 PM
to Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Fredrik Söderquist voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:00 PM (1 hour ago) 1:00 PM
to Fredrik Söderquist, Ian Kilpatrick, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Pass const BasicShape& to Shape::CreateShape()
Matches the current assumption. Rewrite dereferences and simplify
casting.
Change-Id: I00d6a0d733a0b2d65ed409804d55b39761223e8e
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1625521}
Files:
- M third_party/blink/renderer/core/layout/shapes/shape.cc
- M third_party/blink/renderer/core/layout/shapes/shape.h
- M third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc
Change size: S
Delta: 3 files changed, 19 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages