RTC encoder/decoder factory support for H.265 behind flag. [chromium/src : main]
3 views
Skip to first unread message
Jianlin Qiu (Gerrit)
Apr 17, 2024, 9:15:49 AMApr 17
to Sergey Silkin, Sergey Silkin, Dale Curtis, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Dale Curtis, Ilya Nikolaevskiy, Philip Eliasson, Sergey Silkin and Sergey Silkin
Jianlin Qiu added 6 comments![]( "Open in Gerrit")
File media/webrtc/webrtc_features.h
Line 47, Patchset 10:
BASE_DECLARE_FEATURE(kExperimentalWebRtcH265);Sergey Silkin . resolved
Jianlin QiuLet's make naming consistent with other WebRTC related features. kWebRtcAllowH265 ?
Sergey SilkinHow do you think about we have 2 flags for this：
kWebRtcAllowH265Send
kWebRtcAllowH265ReceiveI would assume we probably does not have the intention to allow encode by default, but the capability of receiving H.265 streams improves interop with native applications in the future?
Jianlin QiuYes, I think it makes sense to split the flag into send/recv.
Done
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_adapter.cc
Line 520, Patchset 10:
if (!resolution_monitor && config.codec() != media::VideoCodec::kHEVC) {Sergey Silkin . resolved
Jianlin QiuShould HasSoftwareFallback() be used here (and in other similar places) instead?
Done
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory.cc
Line 51, Patchset 10:
// To support H.265 level 3.1, the default size is set to 1920x1080.Sergey Silkin . resolved
Jianlin QiuSounds slightly misleading. Unlike in the case of H264 there is no SW decoder we need to align max supported level with. I guess we simply want to signal support of 1080p and derive necessary min level for this resolution.
Done
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory_test.cc
Line 241, Patchset 10:
true /*reference_scaling*/),Sergey Silkin . resolved
Jianlin Qiushould this be false?
Done
File third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc
Line 1938, Patchset 10:
if ((profile_ < media::HEVCPROFILE_MIN ||
profile_ > media::HEVCPROFILE_MAX) &&Sergey Silkin . unresolved
Jianlin QiuAny reason not to use codec_settings->codecType here?
No specific reason. I'm just following the code at line 1953 & 1954 for consistency.
File third_party/blink/renderer/platform/peerconnection/rtc_video_encoder_factory.cc
Line 35, Patchset 10:
#if BUILDFLAG(RTC_USE_H265)
#endif // BUILDFLAG(RTC_USE_H265)Sergey Silkin . resolved
Jianlin Qiuremove?
Done
Related details
Attention is currently required from:
- Dale Curtis
- Ilya Nikolaevskiy
- Philip Eliasson
- Sergey Silkin
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Apr 17, 2024, 1:24:32 PMApr 17
to Jianlin Qiu, Sergey Silkin, Sergey Silkin, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Ilya Nikolaevskiy, Jianlin Qiu, Philip Eliasson, Sergey Silkin and Sergey Silkin
Dale Curtis added 6 comments![]( "Open in Gerrit")
Patchset-level comments
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_adapter.cc
Line 107, Patchset 12 (Latest):
bool HasSoftwareFallback(media::VideoCodec video_codec) {Dale Curtis . unresolved
Maybe clearer just as:
```
if (video_codec == HEVC) {
return false;
}
```
outside of the buildflags.
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory.cc
Line 29, Patchset 12 (Latest):
#if BUILDFLAG(RTC_USE_H265)Dale Curtis . unresolved
Move build flag includes below others generally.
Line 48, Patchset 12 (Latest):
const int kDefaultFps = 30;Dale Curtis . unresolved
constexpr all these.
File third_party/blink/renderer/platform/peerconnection/rtc_video_encoder_factory.cc
Line 22, Patchset 12 (Latest):
#if BUILDFLAG(RTC_USE_H265)Dale Curtis . unresolved
Move below other includes.
Line 235, Patchset 12 (Latest):
SupportedFormats supported_h265_formats;Dale Curtis . unresolved
You could choose something more generic like `low_priority_formats` so more of the code doesn't need to be behind a buildflag.
Related details
Attention is currently required from:
- Ilya Nikolaevskiy
- Jianlin Qiu
Jianlin Qiu (Gerrit)
Apr 17, 2024, 9:57:14 PMApr 17
to Sergey Silkin, Sergey Silkin, Dale Curtis, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Dale Curtis, Ilya Nikolaevskiy, Philip Eliasson, Sergey Silkin and Sergey Silkin
Jianlin Qiu added 5 comments![]( "Open in Gerrit")
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_adapter.cc
Line 107, Patchset 12:
bool HasSoftwareFallback(media::VideoCodec video_codec) {Dale Curtis . resolved
Maybe clearer just as:
```
if (video_codec == HEVC) {
return false;
}
```outside of the buildflags.
Jianlin Qiu
Done
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory.cc
Move build flag includes below others generally.
Jianlin Qiu
Done
Line 48, Patchset 12:
const int kDefaultFps = 30;Dale Curtis . resolved
Jianlin Qiuconstexpr all these.
Done
File third_party/blink/renderer/platform/peerconnection/rtc_video_encoder_factory.cc
Line 22, Patchset 12:
#if BUILDFLAG(RTC_USE_H265)Dale Curtis . resolved
Jianlin QiuMove below other includes.
Done
You could choose something more generic like `low_priority_formats` so more of the code doesn't need to be behind a buildflag.
Attention is currently required from:
- Dale Curtis
- Ilya Nikolaevskiy
- Philip Eliasson
- Sergey Silkin
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sergey Silkin (Gerrit)
Apr 19, 2024, 6:46:32 AMApr 19
to Jianlin Qiu, Sergey Silkin, Dale Curtis, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Ilya Nikolaevskiy, Jianlin Qiu, Philip Eliasson and Sergey Silkin
Sergey Silkin added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory_test.cc
Line 188, Patchset 14 (Latest):
#if BUILDFLAG(RTC_USE_H265)Sergey Silkin . unresolved
Seems that this #if is not really needed.
File third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc
Line 1938, Patchset 10:
if ((profile_ < media::HEVCPROFILE_MIN ||
profile_ > media::HEVCPROFILE_MAX) &&Sergey Silkin . unresolved
Jianlin QiuAny reason not to use codec_settings->codecType here?
No specific reason. I'm just following the code at line 1953 & 1954 for consistency.
Sergey Silkin
Profile-based conditions were added in https://chromium-review.googlesource.com/c/chromium/src/+/3351622. The tests added in the same CL explicitly set codecType. For example: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/peerconnection/rtc_video_encoder_test.cc;l=802-805
Not sure why profile was used. codecType seems to be a better option in both places.
Related details
Attention is currently required from:
- Ilya Nikolaevskiy
- Jianlin Qiu
- Philip Eliasson
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianlin Qiu (Gerrit)
Apr 19, 2024, 10:01:23 AMApr 19
to Sergey Silkin, Sergey Silkin, Dale Curtis, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Ilya Nikolaevskiy, Philip Eliasson, Sergey Silkin and Sergey Silkin
Jianlin Qiu added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory_test.cc
Seems that this #if is not really needed.
Jianlin Qiu
Done
File third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc
Line 1938, Patchset 10:
if ((profile_ < media::HEVCPROFILE_MIN ||
profile_ > media::HEVCPROFILE_MAX) &&Sergey Silkin . resolved
Jianlin QiuAny reason not to use codec_settings->codecType here?
Sergey SilkinNo specific reason. I'm just following the code at line 1953 & 1954 for consistency.
Profile-based conditions were added in https://chromium-review.googlesource.com/c/chromium/src/+/3351622. The tests added in the same CL explicitly set codecType. For example: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/peerconnection/rtc_video_encoder_test.cc;l=802-805
Not sure why profile was used. codecType seems to be a better option in both places.
Attention is currently required from:
- Ilya Nikolaevskiy
- Philip Eliasson
- Sergey Silkin
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sergey Silkin (Gerrit)
Apr 19, 2024, 10:17:11 AMApr 19
to Jianlin Qiu, Chromium LUCI CQ, Sergey Silkin, Dale Curtis, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Ilya Nikolaevskiy, Jianlin Qiu, Philip Eliasson and Sergey Silkin
Sergey Silkin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ilya Nikolaevskiy
- Jianlin Qiu
- Philip Eliasson
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianlin Qiu (Gerrit)
Apr 19, 2024, 12:47:59 PMApr 19
to Daniel Cheng, Sergey Silkin, Chromium LUCI CQ, Sergey Silkin, Dale Curtis, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Dale Curtis, Daniel Cheng, Harald Alvestrand, Ilya Nikolaevskiy, Jianlin Qiu, Philip Eliasson, Sergey Silkin and Sergey Silkin
Message from Jianlin Qiu![]( "Open in Gerrit")
Attention is currently required from:
- Dale Curtis
- Daniel Cheng
- Harald Alvestrand
- Ilya Nikolaevskiy
- Jianlin Qiu
- Philip Eliasson
- Sergey Silkin
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Apr 19, 2024, 4:05:19 PMApr 19
to Jianlin Qiu, Mirko Bonadei, Daniel Cheng, Sergey Silkin, Chromium LUCI CQ, Sergey Silkin, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Daniel Cheng, Harald Alvestrand, Ilya Nikolaevskiy, Jianlin Qiu, Mirko Bonadei, Philip Eliasson, Sergey Silkin and Sergey Silkin
Dale Curtis added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 19 (Latest):
Dale Curtis . unresolved
Jianlin, can you pare down to just the required reviewers?
Related details
Attention is currently required from:
- Daniel Cheng
- Harald Alvestrand
- Ilya Nikolaevskiy
- Jianlin Qiu
- Mirko Bonadei
- Philip Eliasson
- Sergey Silkin
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Apr 19, 2024, 4:12:57 PMApr 19
to Jianlin Qiu, Mirko Bonadei, Daniel Cheng, Sergey Silkin, Chromium LUCI CQ, Sergey Silkin, Dale Curtis, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Harald Alvestrand, Ilya Nikolaevskiy, Jianlin Qiu, Mirko Bonadei, Philip Eliasson, Sergey Silkin and Sergey Silkin
Daniel Cheng added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/platform/peerconnection/DEPS
Line 59, Patchset 19 (Latest):
"rtc_video_encoder_factory.cc": [Daniel Cheng . unresolved
Probably easier to just add this in include rules rather than specific include rules, unless there's a specific reason to scope this?
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory.cc
Line 62, Patchset 19 (Latest):
constexpr std::array<CodecConfig, 11> kCodecConfigs = {{Daniel Cheng . unresolved
This std::array needs to be sized according to how many elements are in it.
Unfortunately, CTAD requires specifying all or nothing.
We can:
- use a regular C array, i.e. constexpr CodecConfig kCodecConfigs[] = {{ ... }};
- or we can try to dynamically set the size here.
I would probably just use a regular C array.
Related details
Attention is currently required from:
Daniel Cheng (Gerrit)
Apr 19, 2024, 4:19:07 PMApr 19
to Jianlin Qiu, Mirko Bonadei, Daniel Cheng, Sergey Silkin, Chromium LUCI CQ, Sergey Silkin, Dale Curtis, Harald Alvestrand, Ilya Nikolaevskiy, Philip Eliasson, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Harald Alvestrand, Ilya Nikolaevskiy, Jianlin Qiu, Mirko Bonadei, Philip Eliasson, Sergey Silkin and Sergey Silkin
Daniel Cheng added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory.cc
Line 62, Patchset 19 (Latest):
constexpr std::array<CodecConfig, 11> kCodecConfigs = {{Daniel Cheng . unresolved
This std::array needs to be sized according to how many elements are in it.
Unfortunately, CTAD requires specifying all or nothing.
We can:
- use a regular C array, i.e. constexpr CodecConfig kCodecConfigs[] = {{ ... }};
- or we can try to dynamically set the size here.
I would probably just use a regular C array.
Daniel Cheng
Alternatively a CTAD variant:
```
constexpr std::array kCodecConfigs = {
CodecConfig{...},
CodecConfig{...},
...
};
```
Jianlin Qiu (Gerrit)
Apr 19, 2024, 7:31:35 PMApr 19
to Ilya Nikolaevskiy, Harald Alvestrand, Philip Eliasson, Mirko Bonadei, Daniel Cheng, Sergey Silkin, Chromium LUCI CQ, Sergey Silkin, Dale Curtis, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Daniel Cheng, Mirko Bonadei, Sergey Silkin and Sergey Silkin
Jianlin Qiu added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/platform/peerconnection/DEPS
Probably easier to just add this in include rules rather than specific include rules, unless there's a specific reason to scope this?
Jianlin Qiu
Done
File third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory.cc
Line 62, Patchset 19:
constexpr std::array<CodecConfig, 11> kCodecConfigs = {{Daniel Cheng . resolved
Daniel ChengThis std::array needs to be sized according to how many elements are in it.
Unfortunately, CTAD requires specifying all or nothing.
We can:
- use a regular C array, i.e. constexpr CodecConfig kCodecConfigs[] = {{ ... }};
- or we can try to dynamically set the size here.
I would probably just use a regular C array.
Alternatively a CTAD variant:
```
constexpr std::array kCodecConfigs = {
CodecConfig{...},
CodecConfig{...},
...
};
```
Attention is currently required from:
- Daniel Cheng
- Mirko Bonadei
- Sergey Silkin
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sergey Silkin (Gerrit)
Apr 22, 2024, 3:19:18 AMApr 22
to Jianlin Qiu, Sergey Silkin, Ilya Nikolaevskiy, Harald Alvestrand, Philip Eliasson, Mirko Bonadei, Daniel Cheng, Chromium LUCI CQ, Dale Curtis, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Daniel Cheng, Mirko Bonadei and Sergey Silkin
Sergey Silkin removed Sergey Silkin from this change![]( "Open in Gerrit")
Deleted Reviewers:
- Sergey Silkin
Related details
Attention is currently required from:
- Daniel Cheng
- Mirko Bonadei
- Sergey Silkin
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sergey Silkin (Gerrit)
Apr 22, 2024, 3:19:38 AMApr 22
to Jianlin Qiu, Ilya Nikolaevskiy, Harald Alvestrand, Philip Eliasson, Mirko Bonadei, Daniel Cheng, Chromium LUCI CQ, Dale Curtis, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Daniel Cheng, Jianlin Qiu and Mirko Bonadei
Sergey Silkin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
- Jianlin Qiu
- Mirko Bonadei
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Apr 22, 2024, 1:56:45 PMApr 22
to Jianlin Qiu, Daniel Cheng, Sergey Silkin, Ilya Nikolaevskiy, Harald Alvestrand, Philip Eliasson, Mirko Bonadei, Chromium LUCI CQ, Dale Curtis, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Jianlin Qiu and Mirko Bonadei
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jianlin Qiu
- Mirko Bonadei
Jianlin Qiu (Gerrit)
Apr 23, 2024, 3:50:23 AMApr 23
to Daniel Cheng, Sergey Silkin, Ilya Nikolaevskiy, Harald Alvestrand, Philip Eliasson, Mirko Bonadei, Chromium LUCI CQ, Dale Curtis, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Dale Curtis and Mirko Bonadei
Jianlin Qiu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jianlin Qiu . resolved
Hi, dalecurtis@ could you please help to review */webrtc_features.*,
mbonadei@ could you please help to review webrtc_overries/BUILD.gn? Thanks!
Related details
Attention is currently required from:
- Dale Curtis
- Mirko Bonadei
Mirko Bonadei (Gerrit)
Apr 24, 2024, 11:13:22 AMApr 24
to Jianlin Qiu, Daniel Cheng, Sergey Silkin, Ilya Nikolaevskiy, Harald Alvestrand, Philip Eliasson, Chromium LUCI CQ, Dale Curtis, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Dale Curtis and Jianlin Qiu
Mirko Bonadei voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mirko Bonadei
| Code-Review | +1 |
1 comment
Patchset-level comments
Jianlin Qiu . resolved
Hi, dalecurtis@ could you please help to review */webrtc_features.*,
mbonadei@ could you please help to review webrtc_overries/BUILD.gn? Thanks!
Mirko Bonadei
mbonadei@ could you please help to review webrtc_overries/BUILD.gn? Thanks!
Attention is currently required from:
- Dale Curtis
- Jianlin Qiu
Dale Curtis (Gerrit)
Apr 24, 2024, 3:48:59 PMApr 24
to Jianlin Qiu, Mirko Bonadei, Daniel Cheng, Sergey Silkin, Ilya Nikolaevskiy, Harald Alvestrand, Philip Eliasson, Chromium LUCI CQ, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Jianlin Qiu
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jianlin Qiu
Dale Curtis (Gerrit)
Apr 24, 2024, 3:49:04 PMApr 24
to Jianlin Qiu, Mirko Bonadei, Daniel Cheng, Sergey Silkin, Ilya Nikolaevskiy, Harald Alvestrand, Philip Eliasson, Chromium LUCI CQ, Erik Språng, Hirokazu Honda, Tricium, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, poscia...@chromium.org, video-networking...@google.com
Attention needed from Jianlin Qiu
Dale Curtis added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jianlin, can you pare down to just the required reviewers?
Dale Curtis
Acknowledged
Related details
Attention is currently required from:
- Jianlin Qiu
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianlin Qiu (Gerrit)
Apr 24, 2024, 5:18:16 PMApr 24