Fix reference filter rect mapping with a single filter [chromium/src : main]

1 view
Skip to first unread message

Philip Rogers (Gerrit)

unread,
May 24, 2026, 5:35:25 PM (2 days ago) May 24
to Fredrik Söderquist, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist

Philip Rogers voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icddcf21bd4607ddbcd1364325886bf2bc5ed7dc5
Gerrit-Change-Number: 7871868
Gerrit-PatchSet: 10
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Sun, 24 May 2026 21:34:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
May 25, 2026, 5:18:14 AM (22 hours ago) May 25
to Philip Rogers, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Philip Rogers

Fredrik Söderquist voted and added 4 comments

Votes added by Fredrik Söderquist

Code-Review+1

4 comments

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Fredrik Söderquist . resolved

LGTM w/ nits/suggestions

File third_party/blink/renderer/core/layout/svg/svg_resources.cc
Line 221, Patchset 10 (Latest): filter_ ? filter_->LastEffect() : nullptr, kInterpolationSpaceSRGB);
Fredrik Söderquist . unresolved

Maybe add a `LastEffect()` accessor to reduce the noise a bit here?

Line 395, Patchset 10 (Latest): if (filter_data_) {
Fredrik Söderquist . unresolved

Could this be merged with one of the existing blocks? (The one below seems like the prime candidate.)

Line 396, Patchset 10 (Latest): FilterOperation* op = filter.Operations()[0].Get();
To<ReferenceFilterOperation>(*op).SetFilter(filter_data_->GetFilter());
Fredrik Söderquist . unresolved
Why not just:
```suggestion
      To<ReferenceFilterOperation>(*filter.at(0)).SetFilter(filter_data_->GetFilter());
```
to keep accesses consistent with the above ones (and shorter)?
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icddcf21bd4607ddbcd1364325886bf2bc5ed7dc5
    Gerrit-Change-Number: 7871868
    Gerrit-PatchSet: 10
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Comment-Date: Mon, 25 May 2026 09:18:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Philip Rogers (Gerrit)

    unread,
    May 25, 2026, 8:37:01 PM (6 hours ago) May 25
    to Fredrik Söderquist, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org

    Philip Rogers voted and added 3 comments

    Votes added by Philip Rogers

    Auto-Submit+1
    Commit-Queue+1

    3 comments

    File third_party/blink/renderer/core/layout/svg/svg_resources.cc
    Line 221, Patchset 10: filter_ ? filter_->LastEffect() : nullptr, kInterpolationSpaceSRGB);
    Fredrik Söderquist . resolved

    Maybe add a `LastEffect()` accessor to reduce the noise a bit here?

    Philip Rogers

    Done

    Line 395, Patchset 10: if (filter_data_) {
    Fredrik Söderquist . resolved

    Could this be merged with one of the existing blocks? (The one below seems like the prime candidate.)

    Philip Rogers

    Done

    Line 396, Patchset 10: FilterOperation* op = filter.Operations()[0].Get();
    To<ReferenceFilterOperation>(*op).SetFilter(filter_data_->GetFilter());
    Fredrik Söderquist . resolved
    Why not just:
    ```suggestion
          To<ReferenceFilterOperation>(*filter.at(0)).SetFilter(filter_data_->GetFilter());
    ```
    to keep accesses consistent with the above ones (and shorter)?
    Philip Rogers

    This is due to filter.at returning a const filter operation. Using `filter.Operations()` is following the same pattern as is used by `BuildFilterOperations`.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icddcf21bd4607ddbcd1364325886bf2bc5ed7dc5
      Gerrit-Change-Number: 7871868
      Gerrit-PatchSet: 11
      Gerrit-Owner: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Comment-Date: Tue, 26 May 2026 00:36:37 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Fredrik Söderquist <f...@opera.com>
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages