Add Source-Specific Multicast (SSM) support to Direct Sockets API [chromium/src : main]

0 views
Skip to first unread message

Harald Alvestrand (Gerrit)

unread,
Nov 17, 2025, 9:23:39 AM11/17/25
to Omar Ramadan, Reilly Grant, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
Attention needed from Omar Ramadan and Reilly Grant

Harald Alvestrand voted and added 2 comments

Votes added by Harald Alvestrand

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 3:
Harald Alvestrand . resolved

I don't think I have owners on any of these files, but I approve anyway.
(I'm assuming I got added because I spoke positively about SSM in email :-)

File services/network/multicast_group_controller.cc
Line 109, Patchset 3: if (active_memberships_.count(key)) {
Harald Alvestrand . unresolved

nit: active_memberships_.contains(key) (we're on C++20 and this is more idiomatic).

Open in Gerrit

Related details

Attention is currently required from:
  • Omar Ramadan
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8
Gerrit-Change-Number: 7160820
Gerrit-PatchSet: 3
Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Omar Ramadan <om...@blockcast.net>
Gerrit-Comment-Date: Mon, 17 Nov 2025 14:23:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Omar Ramadan (Gerrit)

unread,
Nov 17, 2025, 1:27:28 PM11/17/25
to Vlad Krot, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
Attention needed from Harald Alvestrand, Reilly Grant and Vlad Krot

Omar Ramadan added 2 comments

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Omar Ramadan . resolved

thanks @h...@chromium.org updated to C++20 conventions

File services/network/multicast_group_controller.cc
Line 109, Patchset 3: if (active_memberships_.count(key)) {
Harald Alvestrand . resolved

nit: active_memberships_.contains(key) (we're on C++20 and this is more idiomatic).

Omar Ramadan

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Harald Alvestrand
  • Reilly Grant
  • Vlad Krot
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8
    Gerrit-Change-Number: 7160820
    Gerrit-PatchSet: 8
    Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
    Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
    Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Comment-Date: Mon, 17 Nov 2025 18:27:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Harald Alvestrand <h...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vlad Krot (Gerrit)

    unread,
    Nov 18, 2025, 11:51:44 AM11/18/25
    to Omar Ramadan, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
    Attention needed from Harald Alvestrand, Omar Ramadan and Reilly Grant

    Vlad Krot added 7 comments

    Commit Message
    Line 9, Patchset 8 (Latest):This CL implements Source-Specific Multicast (SSM) for the Direct
    Vlad Krot . unresolved

    This CL does not have any Web API explainer/spec/design document which is a must, since it targets to be a change to existing web api.

    https://www.chromium.org/blink/launching-features

    File net/socket/udp_socket_posix.cc
    Line 998, Patchset 8 (Latest): return ERR_ADDRESS_INVALID;
    Vlad Krot . unresolved

    unreachable line.

    File services/network/multicast_group_controller.h
    Line 43, Patchset 8 (Latest): void JoinGroup(const net::IPAddress& group_address,
    Vlad Krot . unresolved

    Why is it implemented as a separate code instead of modifying already existing one for joining multicast group of udp socket? So we end up with 2 implementation?

    File services/network/multicast_group_controller.cc
    Line 48, Patchset 8 (Latest):bool MulticastGroupController::IsValidMulticastAddress(
    Vlad Krot . unresolved

    The better place for such checks and logic of keeping memberships is the renderer side. In case in browser process IP is invalid, means that renderer is malicious and mojo pipe can be killed.
    See third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc

    File services/network/public/mojom/restricted_udp_socket.mojom
    Line 49, Patchset 8 (Latest):interface MulticastGroupController {
    Vlad Krot . unresolved

    Is there a reason to create a separate MulticastGroupController instead of adding to RestrictedUDPSocket?

    File third_party/blink/public/mojom/direct_sockets/direct_sockets.mojom
    Line 123, Patchset 8 (Latest):struct DirectMulticastGroupOptions {
    Vlad Krot . unresolved

    There's already api to join multicast groups without source_address in RestrictedUDPSocket.

    Line 132, Patchset 8 (Latest):interface DirectMulticastController {
    Vlad Krot . unresolved

    This duplicates the introduced functions of services/network/public/mojom/restricted_udp_socket.mojom

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Harald Alvestrand
    • Omar Ramadan
    • Reilly Grant
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8
      Gerrit-Change-Number: 7160820
      Gerrit-PatchSet: 8
      Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
      Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
      Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-Reviewer: Vlad Krot <vk...@google.com>
      Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
      Gerrit-Attention: Reilly Grant <rei...@chromium.org>
      Gerrit-Attention: Omar Ramadan <om...@blockcast.net>
      Gerrit-Comment-Date: Tue, 18 Nov 2025 16:51:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Omar Ramadan (Gerrit)

      unread,
      Nov 18, 2025, 4:52:26 PM11/18/25
      to Vlad Krot, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
      Attention needed from Harald Alvestrand, Reilly Grant and Vlad Krot

      Omar Ramadan added 7 comments

      Patchset-level comments
      File-level comment, Patchset 8:
      Omar Ramadan . resolved

      thank you so much Vlad for the quick review!

      File net/socket/udp_socket_posix.cc
      Line 998, Patchset 8: return ERR_ADDRESS_INVALID;
      Vlad Krot . resolved

      unreachable line.

      Omar Ramadan

      Done

      File services/network/multicast_group_controller.h
      Line 43, Patchset 8: void JoinGroup(const net::IPAddress& group_address,
      Vlad Krot . resolved

      Why is it implemented as a separate code instead of modifying already existing one for joining multicast group of udp socket? So we end up with 2 implementation?

      Omar Ramadan

      Done

      File services/network/multicast_group_controller.cc
      Line 48, Patchset 8:bool MulticastGroupController::IsValidMulticastAddress(
      Vlad Krot . resolved

      The better place for such checks and logic of keeping memberships is the renderer side. In case in browser process IP is invalid, means that renderer is malicious and mojo pipe can be killed.
      See third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc

      Omar Ramadan

      Done

      File services/network/public/mojom/restricted_udp_socket.mojom
      Line 49, Patchset 8:interface MulticastGroupController {
      Vlad Krot . resolved

      Is there a reason to create a separate MulticastGroupController instead of adding to RestrictedUDPSocket?

      Omar Ramadan

      Done

      File third_party/blink/public/mojom/direct_sockets/direct_sockets.mojom
      Line 123, Patchset 8:struct DirectMulticastGroupOptions {
      Vlad Krot . resolved

      There's already api to join multicast groups without source_address in RestrictedUDPSocket.

      Omar Ramadan

      Done

      Line 132, Patchset 8:interface DirectMulticastController {
      Vlad Krot . resolved

      This duplicates the introduced functions of services/network/public/mojom/restricted_udp_socket.mojom

      Omar Ramadan

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Harald Alvestrand
      • Reilly Grant
      • Vlad Krot
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8
      Gerrit-Change-Number: 7160820
      Gerrit-PatchSet: 9
      Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
      Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
      Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-Reviewer: Vlad Krot <vk...@google.com>
      Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
      Gerrit-Attention: Reilly Grant <rei...@chromium.org>
      Gerrit-Attention: Vlad Krot <vk...@google.com>
      Gerrit-Comment-Date: Tue, 18 Nov 2025 21:52:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Vlad Krot <vk...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Omar Ramadan (Gerrit)

      unread,
      Nov 18, 2025, 5:05:54 PM11/18/25
      to Andrew Rayskiy, Simon Hangl, Vlad Krot, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, rmcelra...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
      Attention needed from Harald Alvestrand, Reilly Grant and Vlad Krot

      Omar Ramadan added 1 comment

      Commit Message
      Line 9, Patchset 8:This CL implements Source-Specific Multicast (SSM) for the Direct
      Vlad Krot . unresolved

      This CL does not have any Web API explainer/spec/design document which is a must, since it targets to be a change to existing web api.

      https://www.chromium.org/blink/launching-features

      Omar Ramadan

      Ah gotcha thanks for the heads up! I have an explainer at https://github.com/WICG/direct-sockets/issues/80 I've sent an email to webstatu...@google.com and will upload as soon as I have access to "Add new feature".

      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
      Gerrit-Attention: Reilly Grant <rei...@chromium.org>
      Gerrit-Attention: Vlad Krot <vk...@google.com>
      Gerrit-Comment-Date: Tue, 18 Nov 2025 22:05:35 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mike Taylor (Gerrit)

      unread,
      Nov 18, 2025, 7:50:54 PM11/18/25
      to Omar Ramadan, Andrew Rayskiy, Simon Hangl, Vlad Krot, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, rmcelra...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
      Attention needed from Harald Alvestrand, Omar Ramadan, Reilly Grant and Vlad Krot

      Mike Taylor added 1 comment

      Commit Message
      Line 9, Patchset 8:This CL implements Source-Specific Multicast (SSM) for the Direct
      Vlad Krot . unresolved

      This CL does not have any Web API explainer/spec/design document which is a must, since it targets to be a change to existing web api.

      https://www.chromium.org/blink/launching-features

      Omar Ramadan

      Ah gotcha thanks for the heads up! I have an explainer at https://github.com/WICG/direct-sockets/issues/80 I've sent an email to webstatu...@google.com and will upload as soon as I have access to "Add new feature".

      Mike Taylor

      Drive-by comment: you'll also need to send an Intent to Ship and get it approved before landing this CL (or, ideally, land this CL behind a disabled-by-default feature flag, then enable the flag once it's approved).

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Harald Alvestrand
      • Omar Ramadan
      • Reilly Grant
      • Vlad Krot
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8
      Gerrit-Change-Number: 7160820
      Gerrit-PatchSet: 9
      Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
      Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
      Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-Reviewer: Vlad Krot <vk...@google.com>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Mike Taylor <mike...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
      Gerrit-Attention: Reilly Grant <rei...@chromium.org>
      Gerrit-Attention: Omar Ramadan <om...@blockcast.net>
      Gerrit-Attention: Vlad Krot <vk...@google.com>
      Gerrit-Comment-Date: Wed, 19 Nov 2025 00:50:48 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Omar Ramadan <om...@blockcast.net>
      Comment-In-Reply-To: Vlad Krot <vk...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Omar Ramadan (Gerrit)

      unread,
      Nov 18, 2025, 7:54:55 PM11/18/25
      to Mike Taylor, Andrew Rayskiy, Simon Hangl, Vlad Krot, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, rmcelra...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
      Attention needed from Harald Alvestrand, Omar Ramadan, Reilly Grant and Vlad Krot

      Omar Ramadan added 1 comment

      Commit Message
      Line 9, Patchset 8:This CL implements Source-Specific Multicast (SSM) for the Direct
      Vlad Krot . resolved

      This CL does not have any Web API explainer/spec/design document which is a must, since it targets to be a change to existing web api.

      https://www.chromium.org/blink/launching-features

      Omar Ramadan

      Ah gotcha thanks for the heads up! I have an explainer at https://github.com/WICG/direct-sockets/issues/80 I've sent an email to webstatu...@google.com and will upload as soon as I have access to "Add new feature".

      Omar Ramadan

      Added here, https://chromestatus.com/feature/6208452397498368 still trying to navigate the process so appreciate any further guidance

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Harald Alvestrand
      • Omar Ramadan
      • Reilly Grant
      • Vlad Krot
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8
        Gerrit-Change-Number: 7160820
        Gerrit-PatchSet: 9
        Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
        Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
        Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>
        Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
        Gerrit-Reviewer: Vlad Krot <vk...@google.com>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        Gerrit-CC: Mike Taylor <mike...@chromium.org>
        Gerrit-CC: Simon Hangl <sim...@google.com>
        Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
        Gerrit-Attention: Reilly Grant <rei...@chromium.org>
        Gerrit-Attention: Omar Ramadan <om...@blockcast.net>
        Gerrit-Attention: Vlad Krot <vk...@google.com>
        Gerrit-Comment-Date: Wed, 19 Nov 2025 00:54:33 +0000
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Mike Taylor (Gerrit)

        unread,
        Nov 18, 2025, 8:07:29 PM11/18/25
        to Omar Ramadan, Andrew Rayskiy, Simon Hangl, Vlad Krot, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, rmcelra...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
        Attention needed from Harald Alvestrand, Omar Ramadan, Reilly Grant and Vlad Krot

        Mike Taylor added 1 comment

        Commit Message
        Line 9, Patchset 8:This CL implements Source-Specific Multicast (SSM) for the Direct
        Vlad Krot . resolved

        This CL does not have any Web API explainer/spec/design document which is a must, since it targets to be a change to existing web api.

        https://www.chromium.org/blink/launching-features

        Omar Ramadan

        Ah gotcha thanks for the heads up! I have an explainer at https://github.com/WICG/direct-sockets/issues/80 I've sent an email to webstatu...@google.com and will upload as soon as I have access to "Add new feature".

        Omar Ramadan

        Added here, https://chromestatus.com/feature/6208452397498368 still trying to navigate the process so appreciate any further guidance

        Mike Taylor

        That's great (and I appreciate the process might feel like a lot, especially for the first time). With that, and https://chromium.googlesource.com/chromium/src/+/main/docs/flag_guarding_guidelines.md - it's sufficient to land the code (disabled by default), once the code owners are happy with it.

        https://www.chromium.org/blink/launching-features/#prototyping covers that as well as sending an Intent to Prototype email to blink-dev (typically this is done before landing the feature). Once you get past that, and want to move to the Intent to Ship stage, feel free to email me, I'm happy to help answer any questions.

        Gerrit-Comment-Date: Wed, 19 Nov 2025 01:07:21 +0000
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Vlad Krot (Gerrit)

        unread,
        Nov 19, 2025, 7:47:06 AM11/19/25
        to Omar Ramadan, Mike Taylor, Andrew Rayskiy, Simon Hangl, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, rmcelra...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
        Attention needed from Harald Alvestrand, Omar Ramadan and Reilly Grant

        Vlad Krot voted and added 1 comment

        Votes added by Vlad Krot

        Code-Review-1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 10 (Latest):
        Vlad Krot . resolved

        Do not submit unless intent to prototype is approved.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Harald Alvestrand
        • Omar Ramadan
        • Reilly Grant
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is blockingCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8
          Gerrit-Change-Number: 7160820
          Gerrit-PatchSet: 10
          Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
          Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
          Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>
          Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
          Gerrit-Reviewer: Vlad Krot <vk...@google.com>
          Gerrit-CC: Andrew Rayskiy <green...@google.com>
          Gerrit-CC: Mike Taylor <mike...@chromium.org>
          Gerrit-CC: Simon Hangl <sim...@google.com>
          Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
          Gerrit-Attention: Reilly Grant <rei...@chromium.org>
          Gerrit-Attention: Omar Ramadan <om...@blockcast.net>
          Gerrit-Comment-Date: Wed, 19 Nov 2025 12:46:45 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          blocking_requirement
          open
          diffy

          Vlad Krot (Gerrit)

          unread,
          Nov 19, 2025, 7:52:58 AM11/19/25
          to Omar Ramadan, Mike Taylor, Andrew Rayskiy, Simon Hangl, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, rmcelra...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
          Attention needed from Harald Alvestrand, Omar Ramadan and Reilly Grant

          Vlad Krot added 3 comments

          File net/socket/udp_socket_unittest.cc
          Line 2138, Patchset 10 (Latest):TEST_F(UDPSocketTest, JoinSourceGroupIPv4) {
          Vlad Krot . unresolved

          I would split the CL into multiple. The /net/socket/ directory should be in a separate CL from other layers to simplify job of the reviewers.

          File third_party/blink/public/mojom/direct_sockets/direct_sockets.mojom
          Line 113, Patchset 10 (Latest):// Result codes for Direct Sockets operations.
          Vlad Krot . unresolved

          unused?

          File third_party/blink/renderer/modules/direct_sockets/multicast_controller.h
          Line 31, Patchset 10 (Latest): public:
          Vlad Krot . unresolved

          If blink layer is modified, then it must be tested.
          First of all unit tests: third_party/blink/renderer/modules/direct_sockets/multicast_controller_unittest.cc

          Second, e2e tests on chrome or content layer:
          content/browser/direct_sockets/direct_sockets_udp_browsertest.cc,
          chrome/browser/direct_sockets/direct_sockets_apitest.cc

          There should be complete cases, checking that source filtering works, and many other corner cases.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Harald Alvestrand
          • Omar Ramadan
          • Reilly Grant
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is blockingCode-Review
            • requirement is not satisfiedNo-Unresolved-Comments
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8
            Gerrit-Change-Number: 7160820
            Gerrit-PatchSet: 10
            Gerrit-Owner: Omar Ramadan <om...@blockcast.net>
            Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
            Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>
            Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
            Gerrit-Reviewer: Vlad Krot <vk...@google.com>
            Gerrit-CC: Andrew Rayskiy <green...@google.com>
            Gerrit-CC: Mike Taylor <mike...@chromium.org>
            Gerrit-CC: Simon Hangl <sim...@google.com>
            Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
            Gerrit-Attention: Reilly Grant <rei...@chromium.org>
            Gerrit-Attention: Omar Ramadan <om...@blockcast.net>
            Gerrit-Comment-Date: Wed, 19 Nov 2025 12:52:42 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            unsatisfied_requirement
            blocking_requirement
            open
            diffy

            Vlad Krot (Gerrit)

            unread,
            Nov 19, 2025, 7:57:39 AM11/19/25
            to Omar Ramadan, Mike Taylor, Andrew Rayskiy, Simon Hangl, Harald Alvestrand, Reilly Grant, Chromium LUCI CQ, AyeAye, rmcelra...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, net-r...@chromium.org
            Attention needed from Harald Alvestrand, Omar Ramadan and Reilly Grant

            Vlad Krot added 1 comment

            Commit Message
            Line 7, Patchset 10 (Latest):Add Source-Specific Multicast (SSM) support to Direct Sockets API
            Vlad Krot . unresolved

            Attach link to chrome entry for other reviewers.

            Gerrit-Comment-Date: Wed, 19 Nov 2025 12:57:24 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            unsatisfied_requirement
            blocking_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages