[iOS] Add signature fields to X509CertificateModel for page info [chromium/src : main]

0 views
Skip to first unread message

Filipa Senra (Gerrit)

unread,
Jun 15, 2026, 6:08:24 AM (8 days ago) Jun 15
to Tian Ye, Menard, Alexis, android-bu...@system.gserviceaccount.com, Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, siashah+au...@chromium.org, omnibox-...@chromium.org, gcasto+w...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ios-rev...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com, niharm...@google.com, zol...@webkit.org, osaul+aut...@google.com, blink-revi...@chromium.org, browser-comp...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, shgar+aut...@google.com, blink-...@chromium.org, chrome-intell...@chromium.org, vasilii+watchlis...@chromium.org, siyua+aut...@chromium.org, armalhotra+a...@google.com, blink-revie...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Matt Mueller and Tian Ye

Filipa Senra voted and added 1 comment

Votes added by Filipa Senra

Code-Review+1

1 comment

File ios/chrome/browser/page_info/certificate/model/x509_certificate_model.cc
Line 147, Patchset 9 (Latest): std::optional<bssl::der::Input> null_value;
Filipa Senra . unresolved

nit: It can be slightly confusing to use `null_value` in c++ because it might be mistaken for a null pointer or a null std::optional. That's how I read it originally.

Since ReadOptionalTag populates the optional with the contents of the tag, and for an `ASN1_NULL` those contents are always empty, a more descriptive name might be `null_contents` or simply `null_tag`.

Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
  • Tian Ye
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1de94cafebe31ea8609c0fe7132f86433eedf1cf
Gerrit-Change-Number: 7875853
Gerrit-PatchSet: 9
Gerrit-Owner: Tian Ye <tia...@microsoft.com>
Gerrit-Reviewer: Filipa Senra <fse...@google.com>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Tian Ye <tia...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Tian Ye <tia...@microsoft.com>
Gerrit-Attention: Matt Mueller <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Jun 2026 10:07:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tian Ye (Gerrit)

unread,
Jun 15, 2026, 8:20:17 AM (8 days ago) Jun 15
to Menard, Alexis, Filipa Senra, android-bu...@system.gserviceaccount.com, Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, siashah+au...@chromium.org, omnibox-...@chromium.org, gcasto+w...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ios-rev...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com, niharm...@google.com, zol...@webkit.org, osaul+aut...@google.com, blink-revi...@chromium.org, browser-comp...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, shgar+aut...@google.com, blink-...@chromium.org, chrome-intell...@chromium.org, vasilii+watchlis...@chromium.org, siyua+aut...@chromium.org, armalhotra+a...@google.com, blink-revie...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Matt Mueller and Tian Ye

Tian Ye removed Menard, Alexis from this change

Deleted Reviewers:
  • Menard, Alexis
Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
  • Tian Ye
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1de94cafebe31ea8609c0fe7132f86433eedf1cf
Gerrit-Change-Number: 7875853
Gerrit-PatchSet: 9
Gerrit-Owner: Tian Ye <tia...@microsoft.com>
Gerrit-Reviewer: Filipa Senra <fse...@google.com>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Tian Ye <tia...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Tian Ye (Gerrit)

unread,
Jun 15, 2026, 9:25:49 AM (8 days ago) Jun 15
to blink-re...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, chrome-intell...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, shgar+aut...@google.com, gcasto+w...@chromium.org, vinnypersky+...@google.com, marq+...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, siashah+au...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, ios-rev...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, niharm...@google.com
Attention needed from Matt Mueller

Tian Ye has uploaded the change for review

Commit message

[iOS] Add signature fields to X509CertificateModel for page info

Implement GetSignatureAlgorithm, GetSignatureParameters, and
GetSignatureData on the iOS X509CertificateModel subclass.
Bug: 476855848
Change-Id: I1de94cafebe31ea8609c0fe7132f86433eedf1cf

Change diff


Change information

Files:
  • M ios/chrome/browser/page_info/certificate/model/BUILD.gn
  • M ios/chrome/browser/page_info/certificate/model/x509_certificate_model.cc
  • M ios/chrome/browser/page_info/certificate/model/x509_certificate_model.h
  • M ios/chrome/browser/page_info/certificate/model/x509_certificate_model_unittest.cc
Change size: M
Delta: 4 files changed, 95 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newchange
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1de94cafebe31ea8609c0fe7132f86433eedf1cf
    Gerrit-Change-Number: 7875853
    Gerrit-PatchSet: 9
    Gerrit-Owner: Tian Ye <tia...@microsoft.com>
    Gerrit-Reviewer: Filipa Senra <fse...@google.com>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Tian Ye <tia...@microsoft.com>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Matt Mueller <ma...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages