LinkPreview: Introduce feature flag `LinkPreview` [chromium/src : main]

Ken Okada (Gerrit)

unread,

Jul 24, 2023, 10:27:57 PM7/24/23

to Takashi Toyoshima, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention is currently required from: Takashi Toyoshima.

Ken Okada would like Takashi Toyoshima to review this change.

LinkPreview: Introduce feature flag `LinkPreview`

Design doc: https://docs.google.com/document/d/1hrWfVIDrPkrBlf8A576dDBH7Q34ESMLvOObt0j9i0SU

Bug: b/291842539
Change-Id: If06ba79188780ab723620cdf15311df256916112
---
M third_party/blink/common/features.cc
M third_party/blink/public/common/features.h
2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/features.cc
index d8fa7e9..2760911 100644
--- a/third_party/blink/common/features.cc
+++ b/third_party/blink/common/features.cc
@@ -1004,6 +1004,8 @@
 #endif
 );
 
+BASE_FEATURE(kLinkPreview, "LinkPreview", base::FEATURE_ENABLED_BY_DEFAULT);
+
 // Makes network loading tasks unfreezable so that they can be processed while
 // the page is frozen.
 BASE_FEATURE(kLoadingTasksUnfreezable,
diff --git a/third_party/blink/public/common/features.h b/third_party/blink/public/common/features.h
index fe669b4..6cfe306 100644
--- a/third_party/blink/public/common/features.h
+++ b/third_party/blink/public/common/features.h
@@ -531,6 +531,10 @@
 
 BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kLightweightNoStatePrefetch);
 
+// Enables the Link Preview.
+// Tracking bug: https://b.corp.google.com/issues/291715868
+BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kLinkPreview);
+
 BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kLoadingTasksUnfreezable);
 
 BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Ken Okada (Gerrit)

unread,

Jul 24, 2023, 10:28:03 PM7/24/23

to blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Takashi Toyoshima, chromium...@chromium.org

Attention is currently required from: Takashi Toyoshima.

Patch set 1:Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  Could you have a look?

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Hiroki Nakagawa (Gerrit)

unread,

Jul 24, 2023, 10:52:24 PM7/24/23

to blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, prerendering-reviews, Ken Okada, Takashi Toyoshima

Attention is currently required from: Ken Okada, Takashi Toyoshima.

Ken Okada has uploaded this change for review.

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Hiroki Nakagawa (Gerrit)

unread,

Jul 24, 2023, 10:52:29 PM7/24/23

to Ken Okada, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, prerendering-reviews, Chromium LUCI CQ, Takashi Toyoshima, chromium...@chromium.org

Attention is currently required from: Ken Okada, Takashi Toyoshima.

Patch set 1:Code-Review +1

View Change

2 comments:

Patchset:
- Patch Set #1:
  Blink core owner LGTM
File third_party/blink/common/features.cc:
- Patch Set #1, Line 1007: FEATURE_ENABLED_BY_DEFAULT
  This should be DISABLED_BY_DEFAULT.

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Takashi Toyoshima (Gerrit)

unread,

Jul 24, 2023, 11:14:21 PM7/24/23

to Ken Okada, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Hiroki Nakagawa, prerendering-reviews, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Ken Okada.

View Change

1 comment:

File third_party/blink/public/common/features.h:
- Patch Set #1, Line 535: https://b.corp.google.com/issues/
  Maybe using https://issuetracker.google.com/issues/291715868 is better when the tracker gets to be in public?

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Ken Okada (Gerrit)

unread,

Jul 24, 2023, 11:23:54 PM7/24/23

to blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Hiroki Nakagawa, prerendering-reviews, Chromium LUCI CQ, Takashi Toyoshima, chromium...@chromium.org

Attention is currently required from: Takashi Toyoshima.

View Change

2 comments:

File third_party/blink/common/features.cc:

- Patch Set #1, Line 1007: FEATURE_ENABLED_BY_DEFAULT
  This should be DISABLED_BY_DEFAULT.

- Thanks! Done.
File third_party/blink/public/common/features.h:

- Patch Set #1, Line 535: https://b.corp.google.com/issues/

- Maybe using https://issuetracker.google. […]
  sg (For the record, there are URLs like I wrote.)

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Takashi Toyoshima (Gerrit)

unread,

Jul 24, 2023, 11:55:14 PM7/24/23

to Ken Okada, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Hiroki Nakagawa, prerendering-reviews, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Ken Okada.

Patch set 4:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #4:
  ok, lgtm for now, but let me continue discussing on what's the best URL to be in the public repo.

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Ken Okada (Gerrit)

unread,

Jul 25, 2023, 1:56:30 AM7/25/23

to blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Takashi Toyoshima, Hiroki Nakagawa, prerendering-reviews, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Ken Okada.

Patch set 4:Commit-Queue +2

View Change

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jul 25, 2023, 2:00:34 AM7/25/23

to Ken Okada, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, Takashi Toyoshima, Hiroki Nakagawa, prerendering-reviews, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Hiroki Nakagawa: Looks good to me
  Ken Okada: Commit
  Takashi Toyoshima: Looks good to me

LinkPreview: Introduce feature flag `LinkPreview`

Design doc: https://docs.google.com/document/d/1hrWfVIDrPkrBlf8A576dDBH7Q34ESMLvOObt0j9i0SU

Bug: b/291842539
Change-Id: If06ba79188780ab723620cdf15311df256916112

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4705803
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Commit-Queue: Ken Okada <ken...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1174645}


---
M third_party/blink/common/features.cc
M third_party/blink/public/common/features.h
2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/features.cc
index d348718..2cf613b 100644
--- a/third_party/blink/common/features.cc
+++ b/third_party/blink/common/features.cc
@@ -1014,6 +1014,8 @@
 #endif
 );
 
+BASE_FEATURE(kLinkPreview, "LinkPreview", base::FEATURE_DISABLED_BY_DEFAULT);


+
 // Makes network loading tasks unfreezable so that they can be processed while
 // the page is frozen.
 BASE_FEATURE(kLoadingTasksUnfreezable,
diff --git a/third_party/blink/public/common/features.h b/third_party/blink/public/common/features.h

index 7ceb60ef5..d5c4801 100644
--- a/third_party/blink/public/common/features.h
+++ b/third_party/blink/public/common/features.h
@@ -537,6 +537,10 @@


 
 BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kLightweightNoStatePrefetch);
 
+// Enables the Link Preview.

+// Tracking bug: go/launch/4269184


+BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kLinkPreview);
+
 BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kLoadingTasksUnfreezable);
 
 BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(

To view, visit change 4705803. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward