[soft navs] LCP WPT -> LCP SoftNav WPT 4-6 (alphabetically) [chromium/src : main]
0 views
Skip to first unread message
Johannes Henkel (Gerrit)
Jun 17, 2025, 4:26:17 PMJun 17
to Scott Haseley, Blink W3C Test Autoroller, Annie Sullivan, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Annie Sullivan
Johannes Henkel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Johannes Henkel . resolved
PTAL:
I've removed first-letter-background for now, because:
1) I'm no longer convinced the original test works as intended.
2) The test when ported in a naive way has problems because the dom is modified from within the test logic, as opposed to the click handler. And therefore, it may not generate an LCP entry as originally designed / intended.
3) The test is a bit messy so it's difficult to debug / get it to pass, which defeats some of its purpose.
Instead, I've sent a test regarding a raf loop that we discussed (crrev.com/c/6651298).
Related details
Attention is currently required from:
- Annie Sullivan
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Jun 17, 2025, 4:29:48 PMJun 17
to Johannes Henkel, Scott Haseley, Blink W3C Test Autoroller, Annie Sullivan, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Annie Sullivan and Johannes Henkel
Michal Mocny voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Annie Sullivan
- Johannes Henkel
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Annie Sullivan (Gerrit)
Jun 17, 2025, 4:29:50 PMJun 17
to Johannes Henkel, Michal Mocny, Scott Haseley, Blink W3C Test Autoroller, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Johannes Henkel
Annie Sullivan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Johannes Henkel
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Jun 17, 2025, 4:30:49 PMJun 17
to Annie Sullivan, Michal Mocny, Scott Haseley, Blink W3C Test Autoroller, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Johannes Henkel voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Jun 17, 2025, 4:31:13 PMJun 17
to Annie Sullivan, Michal Mocny, Scott Haseley, Blink W3C Test Autoroller, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Johannes Henkel
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Commit-Queue | +2 |
1 comment
File third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/first-letter-background.html
Line 85, Patchset 6:
// Now change the div content to proceed to the second part of the test.
beforeLoad = performance.now();
const div = document.createElement("div");
div.id = "target2";
div.innerHTML = "long text will now be LCP";
document.body.appendChild(div);
observedFirstLetter = true;Johannes Henkel . resolved
Johannes HenkelPerhaps the reason why this isn't observed as LCP candidate is that it's not caused by the click, so we're now (past crrev.com/c/6638389) ignoring it based on task attribution.
Acknowledged
Related details
Attention is currently required from:
- Johannes Henkel
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 17, 2025, 5:41:22 PMJun 17
to Johannes Henkel, Annie Sullivan, Michal Mocny, Scott Haseley, Blink W3C Test Autoroller, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[soft navs] LCP WPT -> LCP SoftNav WPT 4-6 (alphabetically)
4) cross-origin-image
5) element-only-when-fully-active
6) expanded image
Patch set 1 is the copy from the largest-contentful-paint directory for
diffing.
Bug: 424467008
Change-Id: Ic8d954f0a92c579602547ae89fbcabe44e9e0798
Reviewed-by: Annie Sullivan <sull...@chromium.org>
Reviewed-by: Michal Mocny <mmo...@chromium.org>
Commit-Queue: Johannes Henkel <joha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1475242}
Files:
- A third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/cross-origin-image.sub.html
- A third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/element-only-when-fully-active.html
- A third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/expanded-image.html
Change size: M
Delta: 3 files changed, 176 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michal Mocny, +1 by Annie Sullivan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 17, 2025, 7:00:25 PMJun 17
to Chromium LUCI CQ, Johannes Henkel, Annie Sullivan, Michal Mocny, Scott Haseley, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/53181
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages