Do IWYU for event_listener_map.h [chromium/src : main]

0 views
Skip to first unread message

David Sanders (Gerrit)

unread,
Jun 17, 2025, 7:34:39 PMJun 17
to Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org
Attention needed from Dmitry Gozman

David Sanders voted and added 1 comment

Votes added by David Sanders

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
David Sanders . resolved

Should save ~14 MB of compiler input size according to the compile-size job.

Open in Gerrit

Related details

Attention is currently required from:
  • Dmitry Gozman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id95d6623e257c57b63961d9e979e5eba5dcda940
Gerrit-Change-Number: 6653937
Gerrit-PatchSet: 4
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Jun 2025 23:34:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitry Gozman (Gerrit)

unread,
Jun 18, 2025, 3:35:32 AMJun 18
to David Sanders, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org
Attention needed from David Sanders

Dmitry Gozman voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id95d6623e257c57b63961d9e979e5eba5dcda940
Gerrit-Change-Number: 6653937
Gerrit-PatchSet: 4
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Wed, 18 Jun 2025 07:35:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Sanders (Gerrit)

unread,
Jun 18, 2025, 3:49:39 AMJun 18
to Dmitry Gozman, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org

David Sanders voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id95d6623e257c57b63961d9e979e5eba5dcda940
Gerrit-Change-Number: 6653937
Gerrit-PatchSet: 4
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Jun 2025 07:49:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 18, 2025, 3:52:35 AMJun 18
to David Sanders, Dmitry Gozman, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Do IWYU for event_listener_map.h

Adds missing includes as needed to fix the build.
Bug: 40318405
Change-Id: Id95d6623e257c57b63961d9e979e5eba5dcda940
Reviewed-by: Dmitry Gozman <dgo...@chromium.org>
Commit-Queue: David Sanders <dsand...@ucsbalum.com>
Cr-Commit-Position: refs/heads/main@{#1475429}
Files:
  • M third_party/blink/renderer/core/dom/events/event_listener_map.h
  • M third_party/blink/renderer/core/dom/subscriber.h
  • M third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.h
Change size: XS
Delta: 3 files changed, 7 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dmitry Gozman
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id95d6623e257c57b63961d9e979e5eba5dcda940
Gerrit-Change-Number: 6653937
Gerrit-PatchSet: 5
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages