SupportsFocus() shouldn't traverse children [chromium/src : main]

2 views

Skip to first unread message

Di Zhang (Gerrit)

unread,

Nov 6, 2023, 12:37:43 PM11/6/23

to blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention is currently required from: Di Zhang.

Di Zhang uploaded patch set #4 to this change.

View Change

SupportsFocus() shouldn't traverse children

For feature KeyboardFocusableScrollers, SupportsFocus() call IsScrollableContainerThatShouldBeKeyboardFocusable which can potentially
traverse through the scroller's children to find focusable child.

This isn't necessary to check if an element should support focus as
all scrollers should be focusable. Instead, we call IsScrollableNode().

Change-Id: Iaa6b4fc754a5b15978c3ebfa4d006b5a491b3e7d
Bug: 1499038
---
M third_party/blink/renderer/core/dom/element.cc
M third_party/blink/renderer/core/dom/element.h
M third_party/blink/renderer/core/page/focus_controller.cc
M third_party/blink/renderer/platform/runtime_enabled_features.json5
4 files changed, 26 insertions(+), 21 deletions(-)

To view, visit change 5001904. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages