[mq-4] Transport MediaQueryResultLists in a single object [chromium/src : main]

0 views
Skip to first unread message

Anders Hartvoll Ruud (Gerrit)

unread,
Oct 26, 2021, 11:00:12 AM10/26/21
to Kevin Babbitt, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org

Attention is currently required from: Kevin Babbitt.

Anders Hartvoll Ruud would like Kevin Babbitt to review this change.

View Change

[mq-4] Transport MediaQueryResultLists in a single object

We currently evaluate a MediaQuery by going though a list of
MediaQueryExp objects, and record the viewport/device-dependent
results during that process.

The evaluation will soon switch to using MediaQueryExpNode instead,
but we will still need the capability of recording viewport/device-
dependent results. This means we'll need to plumb the two result-
pointers [1] in more places than we do today.

To make future code more readable, we can pass a single "Results"
object which transports both pointers.

[1] viewport_dependent_media_query_results and
device_dependent_media_query_results

Bug: 962417
Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
---
M third_party/blink/renderer/core/css/rule_set.cc
M third_party/blink/renderer/core/css/css_style_sheet.cc
M third_party/blink/renderer/core/css/media_query_evaluator.h
M third_party/blink/renderer/core/css/media_query_evaluator.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
5 files changed, 59 insertions(+), 28 deletions(-)


To view, visit change 3245536. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
Gerrit-Change-Number: 3245536
Gerrit-PatchSet: 1
Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Yoav Weiss <yoav...@chromium.org>
Gerrit-Attention: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-MessageType: newchange

Anders Hartvoll Ruud (Gerrit)

unread,
Oct 26, 2021, 11:00:25 AM10/26/21
to apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, Kevin Babbitt, Alexis Menard, chromium...@chromium.org, Kenneth Rohde Christiansen, Yoav Weiss

Attention is currently required from: Kevin Babbitt.

View Change

    To view, visit change 3245536. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
    Gerrit-Change-Number: 3245536
    Gerrit-PatchSet: 1
    Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Attention: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Comment-Date: Tue, 26 Oct 2021 15:00:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Kevin Babbitt (Gerrit)

    unread,
    Oct 28, 2021, 12:52:35 AM10/28/21
    to Anders Hartvoll Ruud, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, Alexis Menard, chromium...@chromium.org, Kenneth Rohde Christiansen, Yoav Weiss

    Attention is currently required from: Anders Hartvoll Ruud.

    Patch set 1:Code-Review +1

    View Change

    1 comment:

    To view, visit change 3245536. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
    Gerrit-Change-Number: 3245536
    Gerrit-PatchSet: 1
    Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 Oct 2021 04:52:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Anders Hartvoll Ruud (Gerrit)

    unread,
    Oct 28, 2021, 4:56:51 AM10/28/21
    to apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, Kevin Babbitt, Alexis Menard, chromium...@chromium.org, Kenneth Rohde Christiansen, Yoav Weiss

    Attention is currently required from: Anders Hartvoll Ruud.

    Patch set 1:Commit-Queue +2

    View Change

      To view, visit change 3245536. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
      Gerrit-Change-Number: 3245536
      Gerrit-PatchSet: 1
      Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
      Gerrit-CC: Yoav Weiss <yoav...@chromium.org>
      Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Comment-Date: Thu, 28 Oct 2021 08:56:40 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Chromium LUCI CQ (Gerrit)

      unread,
      Oct 28, 2021, 6:53:27 AM10/28/21
      to Anders Hartvoll Ruud, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, Kevin Babbitt, Alexis Menard, chromium...@chromium.org, Kenneth Rohde Christiansen, Yoav Weiss

      Chromium LUCI CQ submitted this change.

      View Change


      Approvals: Kevin Babbitt: Looks good to me Anders Hartvoll Ruud: Commit
      [mq-4] Transport MediaQueryResultLists in a single object

      We currently evaluate a MediaQuery by going though a list of
      MediaQueryExp objects, and record the viewport/device-dependent
      results during that process.

      The evaluation will soon switch to using MediaQueryExpNode instead,
      but we will still need the capability of recording viewport/device-
      dependent results. This means we'll need to plumb the two result-
      pointers [1] in more places than we do today.

      To make future code more readable, we can pass a single "Results"
      object which transports both pointers.

      [1] viewport_dependent_media_query_results and
      device_dependent_media_query_results

      Bug: 962417
      Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245536
      Reviewed-by: Kevin Babbitt <kbab...@microsoft.com>
      Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#935822}

      ---
      M third_party/blink/renderer/core/css/rule_set.cc
      M third_party/blink/renderer/core/css/css_style_sheet.cc
      M third_party/blink/renderer/core/css/media_query_evaluator.h
      M third_party/blink/renderer/core/css/media_query_evaluator.cc
      M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
      5 files changed, 63 insertions(+), 28 deletions(-)


      To view, visit change 3245536. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
      Gerrit-Change-Number: 3245536
      Gerrit-PatchSet: 2
      Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
      Gerrit-CC: Yoav Weiss <yoav...@chromium.org>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages