Attention is currently required from: Kevin Babbitt.
Anders Hartvoll Ruud would like Kevin Babbitt to review this change.
[mq-4] Transport MediaQueryResultLists in a single object
We currently evaluate a MediaQuery by going though a list of
MediaQueryExp objects, and record the viewport/device-dependent
results during that process.
The evaluation will soon switch to using MediaQueryExpNode instead,
but we will still need the capability of recording viewport/device-
dependent results. This means we'll need to plumb the two result-
pointers [1] in more places than we do today.
To make future code more readable, we can pass a single "Results"
object which transports both pointers.
[1] viewport_dependent_media_query_results and
device_dependent_media_query_results
Bug: 962417
Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
---
M third_party/blink/renderer/core/css/rule_set.cc
M third_party/blink/renderer/core/css/css_style_sheet.cc
M third_party/blink/renderer/core/css/media_query_evaluator.h
M third_party/blink/renderer/core/css/media_query_evaluator.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
5 files changed, 59 insertions(+), 28 deletions(-)
To view, visit change 3245536. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Kevin Babbitt.
Attention is currently required from: Anders Hartvoll Ruud.
Patch set 1:Code-Review +1
1 comment:
Patchset:
lgtm
To view, visit change 3245536. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Anders Hartvoll Ruud.
Patch set 1:Commit-Queue +2
Chromium LUCI CQ submitted this change.
[mq-4] Transport MediaQueryResultLists in a single object
We currently evaluate a MediaQuery by going though a list of
MediaQueryExp objects, and record the viewport/device-dependent
results during that process.
The evaluation will soon switch to using MediaQueryExpNode instead,
but we will still need the capability of recording viewport/device-
dependent results. This means we'll need to plumb the two result-
pointers [1] in more places than we do today.
To make future code more readable, we can pass a single "Results"
object which transports both pointers.
[1] viewport_dependent_media_query_results and
device_dependent_media_query_results
Bug: 962417
Change-Id: I623cc91910b0919f701c85cefe21d9abf6b70344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245536
Reviewed-by: Kevin Babbitt <kbab...@microsoft.com>
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935822}
---
M third_party/blink/renderer/core/css/rule_set.cc
M third_party/blink/renderer/core/css/css_style_sheet.cc
M third_party/blink/renderer/core/css/media_query_evaluator.h
M third_party/blink/renderer/core/css/media_query_evaluator.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
5 files changed, 63 insertions(+), 28 deletions(-)