Bhaskar Sharma (Gerrit)

unread,

Nov 13, 2025, 5:07:14 AM11/13/25

to Simon Hangl, Olga Korokhina, Vlad Krot, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Simon Hangl and Vlad Krot

Bhaskar Sharma voted and added 6 comments

Votes added by Bhaskar Sharma

Commit-Queue

+1

6 comments

File third_party/blink/renderer/core/inspector/inspector_network_agent.cc

Line 2330, Patchset 10: String::Number(inspector_id), ipAddress);

Vlad Krot . resolved

Why inspector_id is passed not like in other functions?
IdentifiersFactory::SubresourceRequestId(identifier)

Bhaskar Sharma

Done

File third_party/blink/renderer/modules/direct_sockets/multicast_controller.h

Line 80, Patchset 9: const uint64_t inspector_id_;

Vlad Krot . resolved

Copy please comment from udp socket what is this inspector_id_

Bhaskar Sharma

Done

File third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc

Line 168, Patchset 9: String::Number(inspector_id_),

Vlad Krot . resolved

String::Number(inspector_id_) this conversion is not needed. Just inspector_id_.
Here and elsewhere.

Bhaskar Sharma

Done

File third_party/blink/renderer/modules/direct_sockets/multicast_controller_unittest.cc

Line 95, Patchset 9: scope.GetExecutionContext(), udp_socket, /*inspector_id=*/12345);

Vlad Krot . resolved

Why not just 0? To prevent people asking about meaning of this number.

Bhaskar Sharma

Done

File third_party/blink/web_tests/VirtualTestSuites

Line 1800, Patchset 9:

          "--enable-features=IsolatedWebApps,IsolatedWebAppDevMode,MulticastInDirectSockets,DirectSocketsInServiceWorkers,DirectSocketsInSharedWorkers"

Vlad Krot . resolved

Not needed. Multicast is enabled by default.

Bhaskar Sharma

Done

File third_party/blink/web_tests/http/tests/inspector-protocol/network/direct-sockets/resources/udp-socket-multicast.php

Line 4, Patchset 9:header("Permissions-Policy: direct-sockets=(self)");

Vlad Krot . resolved

More permissions policies are needed: direct-sockets-private, direct-sockets-multicast.

Bhaskar Sharma

Done

Open in Gerrit

Related details

Attention is currently required from:

Simon Hangl
Vlad Krot

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vlad Krot (Gerrit)

unread,

Nov 13, 2025, 6:34:04 AM11/13/25

to Bhaskar Sharma, Simon Hangl, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma and Simon Hangl

Vlad Krot voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simon Hangl (Gerrit)

unread,

Nov 14, 2025, 12:04:40 AM11/14/25

to Bhaskar Sharma, Vlad Krot, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma

Simon Hangl voted and added 3 comments

Votes added by Simon Hangl

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Simon Hangl . resolved

LGTM

Commit Message

Line 9, Patchset 13 (Latest):The dependency of Chromium -> devtools_frontend will be updated in the

Simon Hangl . unresolved

provide a bit more detail on what exactly you are adding. what do the attributes mean that you are adding below?

Line 11, Patchset 13 (Latest):https://b.corp.google.com/issues/441890670

Simon Hangl . unresolved

we usually link to bugs this way: crbug.com/441890670

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Bhaskar Sharma (Gerrit)

unread,

Nov 14, 2025, 5:55:42 AM11/14/25

to Simon Hangl, Vlad Krot, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Bhaskar Sharma added 2 comments

Commit Message

Line 9, Patchset 13:The dependency of Chromium -> devtools_frontend will be updated in the

Simon Hangl . resolved

provide a bit more detail on what exactly you are adding. what do the attributes mean that you are adding below?

Bhaskar Sharma

Done

Line 11, Patchset 13:https://b.corp.google.com/issues/441890670

Simon Hangl . resolved

we usually link to bugs this way: crbug.com/441890670

Bhaskar Sharma

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Danil Somsikov (Gerrit)

unread,

Nov 14, 2025, 8:27:54 AM11/14/25

to Bhaskar Sharma, Benedikt Meurer, Simon Hangl, Vlad Krot, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Benedikt Meurer and Bhaskar Sharma

Danil Somsikov added 2 comments

File third_party/blink/public/devtools_protocol/domains/Network.pdl

Line 1742, Patchset 14 (Latest): experimental event directUDPSocketJoinedMulticastGroup

Danil Somsikov . unresolved

Let's add tests for the new events

File third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc

Line 168, Patchset 14 (Latest): GetExecutionContext(), inspector_id_, normalized_ip_address);

Danil Somsikov . unresolved

Should the probe be called after the `push_back`?

Open in Gerrit

Related details

Attention is currently required from:

Benedikt Meurer
Bhaskar Sharma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vlad Krot (Gerrit)

unread,

Nov 14, 2025, 8:35:01 AM11/14/25

to Bhaskar Sharma, Danil Somsikov, Benedikt Meurer, Simon Hangl, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Benedikt Meurer, Bhaskar Sharma and Simon Hangl

Vlad Krot added 1 comment

File third_party/blink/public/devtools_protocol/domains/Network.pdl

Line 1742, Patchset 14: experimental event directUDPSocketJoinedMulticastGroup

Danil Somsikov . unresolved

Let's add tests for the new events

Vlad Krot

Unfortunately, the multicast does not work in WPT tests 😞 I created an issue for it.
Is there other way to test it?

Open in Gerrit

Related details

Attention is currently required from:

Benedikt Meurer
Bhaskar Sharma
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Danil Somsikov (Gerrit)

unread,

Nov 14, 2025, 10:08:50 AM11/14/25

to Bhaskar Sharma, Benedikt Meurer, Simon Hangl, Vlad Krot, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Benedikt Meurer, Bhaskar Sharma and Simon Hangl

Danil Somsikov added 1 comment

File third_party/blink/public/devtools_protocol/domains/Network.pdl

Line 1742, Patchset 14: experimental event directUDPSocketJoinedMulticastGroup

Danil Somsikov . unresolved

Let's add tests for the new events

Vlad Krot

Unfortunately, the multicast does not work in WPT tests 😞 I created an issue for it.
Is there other way to test it?

Danil Somsikov

chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc

Open in Gerrit

Related details

Attention is currently required from:

Benedikt Meurer
Bhaskar Sharma
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jethro AI Services (Gerrit)

unread,

Nov 14, 2025, 10:31:33 AM11/14/25

to Bhaskar Sharma, Danil Somsikov, Benedikt Meurer, Simon Hangl, Vlad Krot, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Benedikt Meurer, Bhaskar Sharma and Simon Hangl

Jethro AI Services added 1 comment

Patchset-level comments

File-level comment, Patchset 18 (Latest):

Jethro AI Services . resolved

Tell me what is your requirements indicate all what you want then I'll prove it to you that my tools are capable to fix your system I will tic tack toe in a minute without manipulation of both side Raymund De Vera Ico from Philippines Jethro A.I www.jethroaiservices.com Gerrit API-to-Go Developer

satisfied_requirement

unsatisfied_requirement

open

diffy

Philip Pfaffe (Gerrit)

unread,

Nov 17, 2025, 4:16:21 AM11/17/25

to Bhaskar Sharma, Jethro AI Services, Danil Somsikov, Simon Hangl, Vlad Krot, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma and Simon Hangl

Philip Pfaffe added 1 comment

File third_party/blink/renderer/core/inspector/inspector_network_agent.h

Line 268, Patchset 18 (Latest): void DirectUDPSocketJoinedMulticastGroup(uint64_t inspector_id,

Philip Pfaffe . unresolved

here and in most of the other new functions: This is called `identifier` in the other APIs. `inspector_id` confused me for a second since I read it as an identifier of the insepctor and not an identifier of the request. `request_id`? `devtools_request_id`? or just `identifier` as in the other APIs?

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Bhaskar Sharma (Gerrit)

unread,

Nov 18, 2025, 9:38:45 AM11/18/25

to Philip Pfaffe, Jethro AI Services, Danil Somsikov, Simon Hangl, Vlad Krot, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Danil Somsikov, Philip Pfaffe, Simon Hangl and Vlad Krot

Bhaskar Sharma added 3 comments

File third_party/blink/public/devtools_protocol/domains/Network.pdl

Line 1742, Patchset 14: experimental event directUDPSocketJoinedMulticastGroup

Danil Somsikov . resolved

Let's add tests for the new events

Vlad Krot

Unfortunately, the multicast does not work in WPT tests 😞 I created an issue for it.
Is there other way to test it?

Danil Somsikov

chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc

Bhaskar Sharma

Done

File third_party/blink/renderer/core/inspector/inspector_network_agent.h

Line 268, Patchset 18: void DirectUDPSocketJoinedMulticastGroup(uint64_t inspector_id,

Philip Pfaffe . resolved

here and in most of the other new functions: This is called `identifier` in the other APIs. `inspector_id` confused me for a second since I read it as an identifier of the insepctor and not an identifier of the request. `request_id`? `devtools_request_id`? or just `identifier` as in the other APIs?

Bhaskar Sharma

Done

File third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc

Line 168, Patchset 14: GetExecutionContext(), inspector_id_, normalized_ip_address);

Danil Somsikov . resolved

Should the probe be called after the `push_back`?

Bhaskar Sharma

Done

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Philip Pfaffe
Simon Hangl
Vlad Krot

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Danil Somsikov (Gerrit)

unread,

Nov 18, 2025, 10:01:56 AM11/18/25

to Bhaskar Sharma, Philip Pfaffe, Jethro AI Services, Simon Hangl, Vlad Krot, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma, Philip Pfaffe, Simon Hangl and Vlad Krot

Danil Somsikov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma

Philip Pfaffe
Simon Hangl
Vlad Krot

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vlad Krot (Gerrit)

unread,

Nov 18, 2025, 10:19:26 AM11/18/25

to Bhaskar Sharma, Mustaq Ahmed, Danil Somsikov, Philip Pfaffe, Jethro AI Services, Simon Hangl, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma, Mustaq Ahmed, Philip Pfaffe and Simon Hangl

Vlad Krot voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma
Mustaq Ahmed
Philip Pfaffe
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mustaq Ahmed (Gerrit)

unread,

Nov 18, 2025, 10:42:44 AM11/18/25

to Bhaskar Sharma, Vlad Krot, Danil Somsikov, Philip Pfaffe, Jethro AI Services, Simon Hangl, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma, Philip Pfaffe and Simon Hangl

Mustaq Ahmed added 1 comment

Patchset-level comments

File-level comment, Patchset 20 (Latest):

Mustaq Ahmed . unresolved

Someone from [renderer/core/probe/OWNERS](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/probe/OWNERS) should approve the changes in that folder. Do you need my approval for any other change here?

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma
Philip Pfaffe
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

Magdalena Skarbińska (Gerrit)

unread,

Nov 18, 2025, 10:50:34 AM11/18/25

to Bhaskar Sharma, Vlad Krot, Mustaq Ahmed, Danil Somsikov, Philip Pfaffe, Jethro AI Services, Simon Hangl, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma, Philip Pfaffe and Simon Hangl

Magdalena Skarbińska added 3 comments

File chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc

Line 95, Patchset 20 (Latest):#include "third_party/blink/public/common/switches.h"

Magdalena Skarbińska . unresolved

Is this import necessary?

Line 2158, Patchset 20 (Latest):

    auto manifest_builder =
        web_app::ManifestBuilder().AddPermissionsPolicyWildcard(
            PermissionsPolicyFeature::kDirectSockets);
    manifest_builder.AddPermissionsPolicyWildcard(
        PermissionsPolicyFeature::kDirectSocketsPrivate);
    manifest_builder.AddPermissionsPolicyWildcard(
        PermissionsPolicyFeature::kMulticastInDirectSockets);

Magdalena Skarbińska . unresolved

nit: The repeated calls to manifest_builder.AddPermissionsPolicyWildcard(...) can be chained for a slightly cleaner look

```auto manifest_builder =
     web_app::ManifestBuilder()
         .AddPermissionsPolicyWildcard(PermissionsPolicyFeature::kDirectSockets)
         .AddPermissionsPolicyWildcard(
             PermissionsPolicyFeature::kDirectSocketsPrivate)
         .AddPermissionsPolicyWildcard(
             PermissionsPolicyFeature::kMulticastInDirectSockets);
             ```

Line 2235, Patchset 20 (Latest):

      auto it = notifications_.find(method);
      if (it != notifications_.end() && !it->second.empty()) {

Magdalena Skarbińska . unresolved

If the `it` variable is only used within the `if` statement then you might consider initializing it directly inside the `if` condition like this: `if(auto it = ...; it != notifications_.end()) {...}` (Cool article on it -> go/totw/165).

satisfied_requirement

unsatisfied_requirement

open

diffy

Bhaskar Sharma (Gerrit)

unread,

Nov 18, 2025, 10:39:33 PM11/18/25

to Benedikt Meurer, Magdalena Skarbińska, Vlad Krot, Danil Somsikov, Philip Pfaffe, Jethro AI Services, Simon Hangl, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Benedikt Meurer, Philip Pfaffe and Simon Hangl

Bhaskar Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 20 (Latest):

Mustaq Ahmed . resolved

Someone from [renderer/core/probe/OWNERS](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/probe/OWNERS) should approve the changes in that folder. Do you need my approval for any other change here?

Bhaskar Sharma

Done

Open in Gerrit

Related details

Attention is currently required from:

Benedikt Meurer
Philip Pfaffe
Simon Hangl

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Bhaskar Sharma (Gerrit)

unread,

Nov 18, 2025, 10:48:06 PM11/18/25

to Benedikt Meurer, Magdalena Skarbińska, Vlad Krot, Danil Somsikov, Philip Pfaffe, Jethro AI Services, Simon Hangl, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Benedikt Meurer, Danil Somsikov, Magdalena Skarbińska, Philip Pfaffe, Simon Hangl and Vlad Krot

Bhaskar Sharma added 3 comments

File chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc

Line 95, Patchset 20:#include "third_party/blink/public/common/switches.h"

Magdalena Skarbińska . resolved

Is this import necessary?

Bhaskar Sharma

Done

Line 2158, Patchset 20: auto manifest_builder =


        web_app::ManifestBuilder().AddPermissionsPolicyWildcard(
            PermissionsPolicyFeature::kDirectSockets);
    manifest_builder.AddPermissionsPolicyWildcard(
        PermissionsPolicyFeature::kDirectSocketsPrivate);
    manifest_builder.AddPermissionsPolicyWildcard(
        PermissionsPolicyFeature::kMulticastInDirectSockets);

Magdalena Skarbińska . resolved

nit: The repeated calls to manifest_builder.AddPermissionsPolicyWildcard(...) can be chained for a slightly cleaner look

```auto manifest_builder =
     web_app::ManifestBuilder()
         .AddPermissionsPolicyWildcard(PermissionsPolicyFeature::kDirectSockets)
         .AddPermissionsPolicyWildcard(
             PermissionsPolicyFeature::kDirectSocketsPrivate)
         .AddPermissionsPolicyWildcard(
             PermissionsPolicyFeature::kMulticastInDirectSockets);
             ```

Bhaskar Sharma

Done

Line 2235, Patchset 20: auto it = notifications_.find(method);


      if (it != notifications_.end() && !it->second.empty()) {

Magdalena Skarbińska . resolved

If the `it` variable is only used within the `if` statement then you might consider initializing it directly inside the `if` condition like this: `if(auto it = ...; it != notifications_.end()) {...}` (Cool article on it -> go/totw/165).

Bhaskar Sharma

Done

Open in Gerrit

Related details

Attention is currently required from:

Benedikt Meurer
Danil Somsikov
Magdalena Skarbińska

Philip Pfaffe
Simon Hangl
Vlad Krot

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Benedikt Meurer (Gerrit)

unread,

Nov 19, 2025, 1:07:49 AM11/19/25

to Bhaskar Sharma, Magdalena Skarbińska, Vlad Krot, Danil Somsikov, Jethro AI Services, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma, Danil Somsikov, Magdalena Skarbińska and Vlad Krot

Benedikt Meurer voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma
Danil Somsikov
Magdalena Skarbińska
Vlad Krot

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Paulina Gacek (Gerrit)

unread,

Nov 19, 2025, 6:38:05 AM11/19/25

to Bhaskar Sharma, Magdalena Skarbińska, Vlad Krot, Danil Somsikov, Jethro AI Services, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma, Danil Somsikov, Magdalena Skarbińska and Vlad Krot

Paulina Gacek voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma
Danil Somsikov
Magdalena Skarbińska
Vlad Krot

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Bhaskar Sharma (Gerrit)

unread,

Nov 19, 2025, 6:38:30 AM11/19/25

to Dominik Bylica, Paulina Gacek, Magdalena Skarbińska, Vlad Krot, Danil Somsikov, Jethro AI Services, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Danil Somsikov, Magdalena Skarbińska and Vlad Krot

Bhaskar Sharma voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov
Magdalena Skarbińska
Vlad Krot

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dominik Bylica (Gerrit)

unread,

Nov 19, 2025, 6:38:31 AM11/19/25

to Bhaskar Sharma, Paulina Gacek, Magdalena Skarbińska, Vlad Krot, Danil Somsikov, Jethro AI Services, Olga Korokhina, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Attention needed from Bhaskar Sharma, Danil Somsikov, Magdalena Skarbińska and Vlad Krot

Dominik Bylica voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bhaskar Sharma

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 19, 2025, 6:41:31 AM11/19/25

to Bhaskar Sharma, Dominik Bylica, Paulina Gacek, Benedikt Meurer, Magdalena Skarbińska, Vlad Krot, Danil Somsikov, Jethro AI Services, Olga Korokhina, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, pwa-com...@google.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

DevTools protocol for DirectSockets Multicast Capabilities.

CDP has been updated to include necessary multicast options. 2 new
events have been added for a UDP Socket joining and leaving a multicast
group. The dependency of Chromium -> devtools_frontend will be updated
in the future CL's. WPT tests don't work in multicast as of now:
http://crbug.com/441890670

Change-Id: I809e98210daa15942af4acbfe7469233c8bbe6a0

Bug: 449948650

Low-Coverage-Reason: COVERAGE_UNDERREPORTED

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130659

Reviewed-by: Dominik Bylica <byl...@google.com>

Reviewed-by: Benedikt Meurer <bme...@chromium.org>

Reviewed-by: Paulina Gacek <paulin...@google.com>

Commit-Queue: Bhaskar Sharma <bhaska...@google.com>

Cr-Commit-Position: refs/heads/main@{#1547084}

Files:

M chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc
M third_party/blink/public/devtools_protocol/domains/Network.pdl
M third_party/blink/renderer/core/inspector/inspector_network_agent.cc
M third_party/blink/renderer/core/inspector/inspector_network_agent.h
M third_party/blink/renderer/core/probe/core_probes.json5
M third_party/blink/renderer/core/probe/core_probes.pidl
M third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc
M third_party/blink/renderer/modules/direct_sockets/multicast_controller.h
M third_party/blink/renderer/modules/direct_sockets/multicast_controller_unittest.cc
M third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
M third_party/blink/web_tests/http/tests/inspector-protocol/network/direct-sockets/resources/socket-default.php
M third_party/blink/web_tests/http/tests/inspector-protocol/network/direct-sockets/resources/udp-socket-success.php
M third_party/blink/web_tests/http/tests/inspector-protocol/network/direct-sockets/udp-socket-abort.js
M third_party/blink/web_tests/http/tests/inspector-protocol/network/direct-sockets/udp-socket-success-expected.txt

Change size: L

Delta: 14 files changed, 249 insertions(+), 10 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Paulina Gacek, +1 by Dominik Bylica, +1 by Benedikt Meurer

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

DevTools protocol for DirectSockets Multicast Capabilities. [chromium/src : main]

Bhaskar Sharma (Gerrit)

Bhaskar Sharma voted and added 6 comments

Votes added by Bhaskar Sharma

6 comments

Related details

Vlad Krot (Gerrit)

Vlad Krot voted Code-Review+1

Related details

Simon Hangl (Gerrit)

Simon Hangl voted and added 3 comments

Votes added by Simon Hangl

3 comments

Related details

Bhaskar Sharma (Gerrit)

Bhaskar Sharma added 2 comments

Related details

Danil Somsikov (Gerrit)

Danil Somsikov added 2 comments

Related details

Vlad Krot (Gerrit)

Vlad Krot added 1 comment

Related details

Danil Somsikov (Gerrit)

Danil Somsikov added 1 comment

Related details

Jethro AI Services (Gerrit)

Jethro AI Services added 1 comment

Philip Pfaffe (Gerrit)

Philip Pfaffe added 1 comment

Related details

Bhaskar Sharma (Gerrit)

Bhaskar Sharma added 3 comments

Related details

Danil Somsikov (Gerrit)

Danil Somsikov voted Code-Review+1

Related details

Vlad Krot (Gerrit)

Vlad Krot voted Code-Review+1

Related details

Mustaq Ahmed (Gerrit)

Mustaq Ahmed added 1 comment

Related details

Magdalena Skarbińska (Gerrit)

Magdalena Skarbińska added 3 comments

Bhaskar Sharma (Gerrit)

Bhaskar Sharma added 1 comment

Related details

Bhaskar Sharma (Gerrit)

Bhaskar Sharma added 3 comments

Related details

Benedikt Meurer (Gerrit)

Benedikt Meurer voted Code-Review+1

Related details

Paulina Gacek (Gerrit)

Paulina Gacek voted Code-Review+1

Related details

Bhaskar Sharma (Gerrit)

Bhaskar Sharma voted Commit-Queue+2

Related details

Dominik Bylica (Gerrit)

Dominik Bylica voted Code-Review+1

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information