[WebAudio] Discard playback stats collected while page is hidden [chromium/src : main]
0 views
Skip to first unread message
Hongchan Choi (Gerrit)
May 1, 2026, 12:58:49 PM (4 days ago) May 1
to Fredrik Hernqvist, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Fredrik Hernqvist
Hongchan Choi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Hernqvist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Hernqvist (Gerrit)
5:07 AM (9 hours ago) 5:07 AM
to Hongchan Choi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi
Fredrik Hernqvist voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fredrik Hernqvist
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/modules/webaudio/audio_context_test.cc
Line 1441, Patchset 1 (Latest):
int glitches_after = playback_stats->underrunEvents(script_state);Fredrik Hernqvist . unresolved
Can we verify that totalDuration has also been frozen while hidden? Since it's used as a reference for the glitches, we don't want them to get out of sync.
Related details
Attention is currently required from:
- Hongchan Choi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongchan Choi (Gerrit)
1:09 PM (1 hour ago) 1:09 PM
to Fredrik Hernqvist, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Fredrik Hernqvist
Hongchan Choi added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/webaudio/audio_context_test.cc
Line 1441, Patchset 1:
int glitches_after = playback_stats->underrunEvents(script_state);Fredrik Hernqvist . unresolved
Can we verify that totalDuration has also been frozen while hidden? Since it's used as a reference for the glitches, we don't want them to get out of sync.
Attention is currently required from:
- Fredrik Hernqvist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages