Fix unsafe buffer usage in atomic_operations_test.cc [chromium/src : main]

0 views
Skip to first unread message

Kentaro Hara (Gerrit)

unread,
3:02 AM (11 hours ago) 3:02 AM
to Xiang Ji, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Xiang Ji

Kentaro Hara voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Xiang Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I43de2faf4a2616cc5f3cc0f6a5eb749936a82e58
Gerrit-Change-Number: 7812589
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-Attention: Xiang Ji <jxi...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 07:02:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Xiang Ji (Gerrit)

unread,
11:58 AM (2 hours ago) 11:58 AM
to Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Xiang Ji voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I43de2faf4a2616cc5f3cc0f6a5eb749936a82e58
Gerrit-Change-Number: 7812589
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 15:58:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
12:53 PM (1 hour ago) 12:53 PM
to Xiang Ji, Kentaro Hara, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix unsafe buffer usage in atomic_operations_test.cc

Resolved unsafe pointer patterns and operations by transitioning to safe
structures, adhering to Chromium's modern memory safety rules.

Generated with Gemini CLI.
Bug: 435317390
Change-Id: I43de2faf4a2616cc5f3cc0f6a5eb749936a82e58
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Xiang Ji <jxi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1625510}
Files:
  • M third_party/blink/renderer/platform/wtf/atomic_operations_test.cc
Change size: S
Delta: 1 file changed, 16 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kentaro Hara
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I43de2faf4a2616cc5f3cc0f6a5eb749936a82e58
Gerrit-Change-Number: 7812589
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages