Cleanup: No longer need for RepeatedFooter [chromium/src : main]

Morten Stenshorne (Gerrit)

unread,

Jun 24, 2022, 8:21:59 AM6/24/22

to Alison Maher, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org

Attention is currently required from: Alison Maher.

Morten Stenshorne would like Alison Maher to review this change.

View Change

Cleanup: No longer need for RepeatedFooter

Since we need to walk all the way to the repeated table footer anyway
(as of CL:3723260), we don't need to store a lot of information about it
when pre-scanning. All we need is the block-size.

Change-Id: I3ab435a933cdd50242e9d13155ad2e8ca9e1b303
---
M third_party/blink/renderer/core/layout/ng/table/ng_table_layout_algorithm.cc
1 file changed, 39 insertions(+), 44 deletions(-)

To view, visit change 3721009. To unsubscribe, or for help writing mail filters, visit settings.

Morten Stenshorne (Gerrit)

unread,

Jun 24, 2022, 8:22:03 AM6/24/22

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Alison Maher, chromium...@chromium.org

Attention is currently required from: Alison Maher.

View Change

To view, visit change 3721009. To unsubscribe, or for help writing mail filters, visit settings.

Alison Maher (Gerrit)

unread,

Jun 27, 2022, 11:42:28 AM6/27/22

to Morten Stenshorne, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, chromium...@chromium.org

Attention is currently required from: Morten Stenshorne.

Patch set 1:Code-Review +1

View Change

To view, visit change 3721009. To unsubscribe, or for help writing mail filters, visit settings.

Morten Stenshorne (Gerrit)

unread,

Jun 27, 2022, 6:33:04 PM6/27/22

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Alison Maher, chromium...@chromium.org

Attention is currently required from: Morten Stenshorne.

Patch set 2:Commit-Queue +2

View Change

To view, visit change 3721009. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jun 27, 2022, 8:32:58 PM6/27/22

to Morten Stenshorne, atotic+...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Alison Maher, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals:
  Alison Maher: Looks good to me
  Morten Stenshorne: Commit

Cleanup: No longer need for RepeatedFooter

Since we need to walk all the way to the repeated table footer anyway
(as of CL:3723260), we don't need to store a lot of information about it
when pre-scanning. All we need is the block-size.

Change-Id: I3ab435a933cdd50242e9d13155ad2e8ca9e1b303

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721009
Reviewed-by: Alison Maher <alm...@microsoft.com>
Commit-Queue: Morten Stenshorne <mste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1018480}
---
M third_party/blink/renderer/core/layout/ng/table/ng_table_layout_algorithm.cc
1 file changed, 43 insertions(+), 44 deletions(-)

To view, visit change 3721009. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward