Remove the legacy ShapeCache [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Dec 12, 2025, 5:00:15 AMDec 12
to Kent Tamura, Ian Kilpatrick, Koji Ishii, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, fuzzin...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick and Koji Ishii

Kent Tamura added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kent Tamura . resolved

ikilpatrick@ or kojii@, would you review this please?
I'd like to merge this at the end of this month.

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3da3d52585b818d9e2cd41be6464d1e63c171ff2
Gerrit-Change-Number: 7255754
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 09:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Dec 12, 2025, 10:38:15 AMDec 12
to Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, fuzzin...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura and Koji Ishii

Ian Kilpatrick voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
  • Koji Ishii
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3da3d52585b818d9e2cd41be6464d1e63c171ff2
    Gerrit-Change-Number: 7255754
    Gerrit-PatchSet: 5
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Attention: Koji Ishii <ko...@chromium.org>
    Gerrit-Comment-Date: Fri, 12 Dec 2025 15:38:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Koji Ishii (Gerrit)

    unread,
    Dec 17, 2025, 2:42:48 PM (11 days ago) Dec 17
    to Kent Tamura, Ian Kilpatrick, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, fuzzin...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Kent Tamura

    Koji Ishii voted and added 1 comment

    Votes added by Koji Ishii

    Code-Review+1

    1 comment

    Patchset-level comments
    Koji Ishii . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kent Tamura
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3da3d52585b818d9e2cd41be6464d1e63c171ff2
    Gerrit-Change-Number: 7255754
    Gerrit-PatchSet: 5
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Dec 2025 19:42:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kent Tamura (Gerrit)

    unread,
    Dec 25, 2025, 10:59:29 PM (2 days ago) Dec 25
    to Kent Tamura, Koji Ishii, Ian Kilpatrick, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, fuzzin...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

    Kent Tamura voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3da3d52585b818d9e2cd41be6464d1e63c171ff2
    Gerrit-Change-Number: 7255754
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Comment-Date: Fri, 26 Dec 2025 03:58:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 25, 2025, 11:02:18 PM (2 days ago) Dec 25
    to Kent Tamura, Koji Ishii, Ian Kilpatrick, AyeAye, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, fuzzin...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    5 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Remove the legacy ShapeCache

    The code paths using blink::ShapeCache have never been used since M143.
    This CL has no behavior changes.
    Bug: 448683997
    Change-Id: I3da3d52585b818d9e2cd41be6464d1e63c171ff2
    Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
    Reviewed-by: Koji Ishii <ko...@chromium.org>
    Commit-Queue: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1562668}
    Files:
    • M third_party/blink/renderer/core/css/threaded/font_object_threaded_test.cc
    • M third_party/blink/renderer/core/css/threaded/text_renderer_threaded_test.cc
    • M third_party/blink/renderer/core/html/canvas/text_metrics.cc
    • M third_party/blink/renderer/core/html/canvas/text_metrics.h
    • M third_party/blink/renderer/core/layout/mathml/math_token_layout_algorithm.cc
    • M third_party/blink/renderer/core/paint/text_combine_painter.cc
    • M third_party/blink/renderer/platform/BUILD.gn
    • D third_party/blink/renderer/platform/fonts/fallback_list_composite_key.h
    • D third_party/blink/renderer/platform/fonts/fallback_list_composite_key_test.cc
    • M third_party/blink/renderer/platform/fonts/font.cc
    • M third_party/blink/renderer/platform/fonts/font.h
    • M third_party/blink/renderer/platform/fonts/font_cache.cc
    • M third_party/blink/renderer/platform/fonts/font_cache.h
    • M third_party/blink/renderer/platform/fonts/font_fallback_list.cc
    • M third_party/blink/renderer/platform/fonts/font_fallback_list.h
    • M third_party/blink/renderer/platform/fonts/plain_text_node_test.cc
    • M third_party/blink/renderer/platform/fonts/plain_text_painter.cc
    • M third_party/blink/renderer/platform/fonts/plain_text_painter_test.cc
    • M third_party/blink/renderer/platform/fonts/shaping/frame_shape_cache_test.cc
    • M third_party/blink/renderer/platform/fonts/shaping/harfbuzz_shaper_fuzzer.cc
    • D third_party/blink/renderer/platform/fonts/shaping/shape_cache.h
    • M third_party/blink/renderer/platform/fonts/shaping/shape_result_bloberizer_test.cc
    • M third_party/blink/renderer/platform/graphics/graphics_context.cc
    • M third_party/blink/renderer/platform/graphics/graphics_context.h
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • D third_party/blink/renderer/platform/text/text_run.cc
    • M third_party/blink/renderer/platform/text/text_run.h
    Change size: L
    Delta: 27 files changed, 18 insertions(+), 788 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ian Kilpatrick, +1 by Koji Ishii
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3da3d52585b818d9e2cd41be6464d1e63c171ff2
    Gerrit-Change-Number: 7255754
    Gerrit-PatchSet: 7
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages