Add a feature flag and about_flags entry to disable KeyboardFocusableScrollers [chromium/src : main]

0 views
Skip to first unread message

Di Zhang (Gerrit)

unread,
May 6, 2024, 6:57:15 PM5/6/24
to Mason Freed, Chromium Metrics Reviews, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Nektarios Paisios, abigailbk...@google.com, aleventhal...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, chromiumme...@microsoft.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Mason Freed

Di Zhang added 2 comments

File third_party/blink/renderer/modules/accessibility/ax_object.cc
Line 7784, Patchset 1 (Latest): GetDocument()->GetExecutionContext())) &&
Di Zhang . unresolved

This change feels awkward. I am not sure how necessary it is to guard this A11Y code behind the opt out flag.

File tools/metrics/histograms/histograms_xml_files.gni
Line 1, Patchset 1 (Latest):histograms_xml_files = [
Di Zhang . unresolved

This file got regenerated by the tools/metrics/histograms/histogram_paths.py script.

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6ff7d3b289d02a2a74502900ea207f02a14f3026
Gerrit-Change-Number: 5519624
Gerrit-PatchSet: 1
Gerrit-Owner: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Mon, 06 May 2024 22:57:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages