Add keywords for contain-intrinsic-block-size [chromium/src : main]

0 views
Skip to first unread message

Alex Rudenko (Gerrit)

unread,
Jun 15, 2026, 4:00:08 AM (12 days ago) Jun 15
to Samiya Caur, Rune Lillesveen, Menard, Alexis, android-bu...@system.gserviceaccount.com, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
Attention needed from Rune Lillesveen and Samiya Caur

Alex Rudenko voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
  • Samiya Caur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I08507b4dcc549bd698abfc465d4298aec225c977
Gerrit-Change-Number: 7938668
Gerrit-PatchSet: 1
Gerrit-Owner: Samiya Caur <sam...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Samiya Caur <sam...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Jun 2026 07:59:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Jun 15, 2026, 4:01:23 AM (12 days ago) Jun 15
to Samiya Caur, Alex Rudenko, Rune Lillesveen, Menard, Alexis, android-bu...@system.gserviceaccount.com, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
Attention needed from Samiya Caur

Rune Lillesveen added 1 comment

File third_party/blink/renderer/core/css/css_properties.json5
Line 9165, Patchset 1 (Latest): keywords: ["none"],
Rune Lillesveen . unresolved

And 'auto'?

Open in Gerrit

Related details

Attention is currently required from:
  • Samiya Caur
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I08507b4dcc549bd698abfc465d4298aec225c977
    Gerrit-Change-Number: 7938668
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samiya Caur <sam...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Samiya Caur <sam...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Jun 2026 08:00:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Samiya Caur (Gerrit)

    unread,
    Jun 15, 2026, 4:32:24 AM (12 days ago) Jun 15
    to Alex Rudenko, Rune Lillesveen, Menard, Alexis, android-bu...@system.gserviceaccount.com, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
    Attention needed from Rune Lillesveen

    Samiya Caur voted and added 1 comment

    Votes added by Samiya Caur

    Auto-Submit+1
    Commit-Queue+1

    1 comment

    File third_party/blink/renderer/core/css/css_properties.json5
    Rune Lillesveen . resolved

    And 'auto'?

    Samiya Caur

    I did not add `auto` since it doesn't seem to work on its own - it needs a second `<length>` value

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rune Lillesveen
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I08507b4dcc549bd698abfc465d4298aec225c977
      Gerrit-Change-Number: 7938668
      Gerrit-PatchSet: 1
      Gerrit-Owner: Samiya Caur <sam...@chromium.org>
      Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
      Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Comment-Date: Mon, 15 Jun 2026 08:31:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rune Lillesveen (Gerrit)

      unread,
      Jun 15, 2026, 4:32:51 AM (12 days ago) Jun 15
      to Samiya Caur, Rune Lillesveen, Chromium LUCI CQ, Alex Rudenko, Menard, Alexis, android-bu...@system.gserviceaccount.com, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org
      Attention needed from Samiya Caur

      Rune Lillesveen voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Samiya Caur
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I08507b4dcc549bd698abfc465d4298aec225c977
      Gerrit-Change-Number: 7938668
      Gerrit-PatchSet: 1
      Gerrit-Owner: Samiya Caur <sam...@chromium.org>
      Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
      Gerrit-Attention: Samiya Caur <sam...@chromium.org>
      Gerrit-Comment-Date: Mon, 15 Jun 2026 08:32:30 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jun 15, 2026, 6:04:27 AM (12 days ago) Jun 15
      to Samiya Caur, Rune Lillesveen, Alex Rudenko, Menard, Alexis, android-bu...@system.gserviceaccount.com, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Add keywords for contain-intrinsic-block-size
      Bug: 446108436
      Change-Id: I08507b4dcc549bd698abfc465d4298aec225c977
      Reviewed-by: Rune Lillesveen <fut...@chromium.org>
      Commit-Queue: Rune Lillesveen <fut...@chromium.org>
      Commit-Queue: Samiya Caur <sam...@chromium.org>
      Reviewed-by: Alex Rudenko <alexr...@chromium.org>
      Auto-Submit: Samiya Caur <sam...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1646683}
      Files:
      • M third_party/blink/renderer/core/css/css_properties.json5
      Change size: XS
      Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Rune Lillesveen, +1 by Alex Rudenko
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I08507b4dcc549bd698abfc465d4298aec225c977
      Gerrit-Change-Number: 7938668
      Gerrit-PatchSet: 2
      Gerrit-Owner: Samiya Caur <sam...@chromium.org>
      Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages