Add Digital Credentials to WebDx Feature [chromium/src : main]

0 views
Skip to first unread message

Mohamed Amir Yosef (Gerrit)

unread,
3:48 AM (6 hours ago) 3:48 AM
to Tejas Dhagawkar, suresh potti, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Tejas Dhagawkar and suresh potti

Mohamed Amir Yosef added 1 comment

File third_party/blink/common/use_counter/webdx_feature_maps.cc
Line 482, Patchset 5 (Latest): {WebFeature::kIdentityDigitalCredentials,
Mohamed Amir Yosef . unresolved

This is used only for digital credential presentation, should we make this explicit not to be confused with issuance?

Open in Gerrit

Related details

Attention is currently required from:
  • Tejas Dhagawkar
  • suresh potti
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic469d7954d5052c238ca17ffc2bb86b9dd9199b5
Gerrit-Change-Number: 7731802
Gerrit-PatchSet: 5
Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>
Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>
Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
Gerrit-Attention: suresh potti <sures...@microsoft.com>
Gerrit-Comment-Date: Mon, 13 Apr 2026 07:48:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tejas Dhagawkar (Gerrit)

unread,
7:24 AM (2 hours ago) 7:24 AM
to Mohamed Amir Yosef, suresh potti, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Mohamed Amir Yosef and suresh potti

Tejas Dhagawkar added 1 comment

File third_party/blink/common/use_counter/webdx_feature_maps.cc
Line 482, Patchset 5: {WebFeature::kIdentityDigitalCredentials,
Mohamed Amir Yosef . resolved

This is used only for digital credential presentation, should we make this explicit not to be confused with issuance?

Tejas Dhagawkar

Thanks! WebDXFeature::kDigitalCredentials name is picked from https://github.com/web-platform-dx/web-features/blob/main/features/digital-credentials.yml similar to other webdx entries in this map. But we can map multiple WebFeatures to same WebDXfeature.

for example
{WebFeature::kAsyncClipboardAPIRead, WebDXFeature::kAsyncClipboard},
{WebFeature::kAsyncClipboardAPIWrite, WebDXFeature::kAsyncClipboard},
{WebFeature::kAsyncClipboardAPIReadText, WebDXFeature::kAsyncClipboard},
{WebFeature::kAsyncClipboardAPIWriteText, WebDXFeature::kAsyncClipboard},

Hence I added mapping for kIdentityDigitalCredentialsCreation as well to kDigitalCredentials.

Open in Gerrit

Related details

Attention is currently required from:
  • Mohamed Amir Yosef
  • suresh potti
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic469d7954d5052c238ca17ffc2bb86b9dd9199b5
    Gerrit-Change-Number: 7731802
    Gerrit-PatchSet: 6
    Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>
    Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
    Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>
    Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: suresh potti <sures...@microsoft.com>
    Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 11:24:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mohamed Amir Yosef <ma...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mohamed Amir Yosef (Gerrit)

    unread,
    9:32 AM (11 minutes ago) 9:32 AM
    to Tejas Dhagawkar, suresh potti, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
    Attention needed from Tejas Dhagawkar and suresh potti

    Mohamed Amir Yosef voted and added 1 comment

    Votes added by Mohamed Amir Yosef

    Code-Review+1

    1 comment

    Patchset-level comments
    Mohamed Amir Yosef . resolved

    LGTM

    Thank you!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tejas Dhagawkar
    • suresh potti
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic469d7954d5052c238ca17ffc2bb86b9dd9199b5
    Gerrit-Change-Number: 7731802
    Gerrit-PatchSet: 6
    Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>
    Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
    Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>
    Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
    Gerrit-Attention: suresh potti <sures...@microsoft.com>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 13:32:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mohamed Amir Yosef (Gerrit)

    unread,
    9:33 AM (10 minutes ago) 9:33 AM
    to Tejas Dhagawkar, Mike West, suresh potti, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
    Attention needed from Mike West, Tejas Dhagawkar and suresh potti

    Mohamed Amir Yosef added 1 comment

    Patchset-level comments
    Mohamed Amir Yosef . resolved

    Hi Mike,

    Could you please take a look on
    third_party/blink/common/use_counter/webdx_feature_maps.cc
    ?
    Does this make sense?

    Thank you,
    Mohamed

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mike West
    • Tejas Dhagawkar
    • suresh potti
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic469d7954d5052c238ca17ffc2bb86b9dd9199b5
    Gerrit-Change-Number: 7731802
    Gerrit-PatchSet: 6
    Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
    Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>
    Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>
    Gerrit-Attention: suresh potti <sures...@microsoft.com>
    Gerrit-Attention: Mike West <mk...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 13:33:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages