Feature for Cookie Store API `maxAge` attribute [chromium/src : main]

0 views
Skip to first unread message

Anusha Muley (Gerrit)

unread,
Jul 10, 2025, 10:32:47 AMJul 10
to Dylan Cutler, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, net-r...@chromium.org
Attention needed from Dylan Cutler

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Dylan Cutler
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I884a00c390cb9754ed36da344534b77329704ba1
Gerrit-Change-Number: 6707788
Gerrit-PatchSet: 8
Gerrit-Owner: Anusha Muley <anush...@google.com>
Gerrit-Reviewer: Anusha Muley <anush...@google.com>
Gerrit-Reviewer: Dylan Cutler <dylan...@google.com>
Gerrit-Attention: Dylan Cutler <dylan...@google.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 14:32:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dylan Cutler (Gerrit)

unread,
Jul 10, 2025, 12:14:47 PMJul 10
to Anusha Muley, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, net-r...@chromium.org
Attention needed from Anusha Muley

Dylan Cutler added 1 comment

File net/base/features.h
Line 854, Patchset 9 (Latest):NET_EXPORT BASE_DECLARE_FEATURE(kCookieStoreAPIMaxAge);
Dylan Cutler . unresolved

Consider making this a Blink feature instead of a feature in net/, since this flag only toggles support of `maxAge` in the Blink API, not the cookie attribute in general https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/common/features.h

Open in Gerrit

Related details

Attention is currently required from:
  • Anusha Muley
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I884a00c390cb9754ed36da344534b77329704ba1
    Gerrit-Change-Number: 6707788
    Gerrit-PatchSet: 9
    Gerrit-Owner: Anusha Muley <anush...@google.com>
    Gerrit-Reviewer: Anusha Muley <anush...@google.com>
    Gerrit-Reviewer: Dylan Cutler <dylan...@google.com>
    Gerrit-Attention: Anusha Muley <anush...@google.com>
    Gerrit-Comment-Date: Thu, 10 Jul 2025 16:14:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Anusha Muley (Gerrit)

    unread,
    Nov 13, 2025, 1:44:44 PM (yesterday) Nov 13
    to AyeAye, Dylan Cutler, Chromium LUCI CQ, chromium...@chromium.org, storage...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, net-r...@chromium.org
    Attention needed from Dylan Cutler

    Anusha Muley added 1 comment

    File net/base/features.h
    Line 854, Patchset 9:NET_EXPORT BASE_DECLARE_FEATURE(kCookieStoreAPIMaxAge);
    Dylan Cutler . unresolved

    Consider making this a Blink feature instead of a feature in net/, since this flag only toggles support of `maxAge` in the Blink API, not the cookie attribute in general https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/common/features.h

    Anusha Muley

    ok gotcha, made it a blink feature and its autogenerated based on the addition to runtime_enabled_features.json. Lmk if thats reasonable

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dylan Cutler
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I884a00c390cb9754ed36da344534b77329704ba1
      Gerrit-Change-Number: 6707788
      Gerrit-PatchSet: 11
      Gerrit-Owner: Anusha Muley <anush...@google.com>
      Gerrit-Reviewer: Anusha Muley <anush...@google.com>
      Gerrit-Reviewer: Dylan Cutler <dylan...@google.com>
      Gerrit-Attention: Dylan Cutler <dylan...@google.com>
      Gerrit-Comment-Date: Thu, 13 Nov 2025 18:44:38 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dylan Cutler <dylan...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dylan Cutler (Gerrit)

      unread,
      Nov 13, 2025, 2:42:19 PM (yesterday) Nov 13
      to Anusha Muley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, storage...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, net-r...@chromium.org
      Attention needed from Anusha Muley

      Dylan Cutler voted and added 2 comments

      Votes added by Dylan Cutler

      Code-Review+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 11:
      Dylan Cutler . resolved

      Thanks, Anusha!

      File net/base/features.h
      Line 854, Patchset 9:NET_EXPORT BASE_DECLARE_FEATURE(kCookieStoreAPIMaxAge);
      Dylan Cutler . resolved

      Consider making this a Blink feature instead of a feature in net/, since this flag only toggles support of `maxAge` in the Blink API, not the cookie attribute in general https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/common/features.h

      Anusha Muley

      ok gotcha, made it a blink feature and its autogenerated based on the addition to runtime_enabled_features.json. Lmk if thats reasonable

      Dylan Cutler

      Acknowledged

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Anusha Muley
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I884a00c390cb9754ed36da344534b77329704ba1
        Gerrit-Change-Number: 6707788
        Gerrit-PatchSet: 11
        Gerrit-Owner: Anusha Muley <anush...@google.com>
        Gerrit-Reviewer: Anusha Muley <anush...@google.com>
        Gerrit-Reviewer: Dylan Cutler <dylan...@google.com>
        Gerrit-Attention: Anusha Muley <anush...@google.com>
        Gerrit-Comment-Date: Thu, 13 Nov 2025 19:42:09 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Anusha Muley <anush...@google.com>
        Comment-In-Reply-To: Dylan Cutler <dylan...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Dylan Cutler (Gerrit)

        unread,
        3:53 PM (7 hours ago) 3:53 PM
        to Anusha Muley, Chris Harrelson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, storage...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, net-r...@chromium.org
        Attention needed from Anusha Muley and Chris Harrelson

        Dylan Cutler voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Anusha Muley
        • Chris Harrelson
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I884a00c390cb9754ed36da344534b77329704ba1
        Gerrit-Change-Number: 6707788
        Gerrit-PatchSet: 17
        Gerrit-Owner: Anusha Muley <anush...@google.com>
        Gerrit-Reviewer: Anusha Muley <anush...@google.com>
        Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
        Gerrit-Reviewer: Dylan Cutler <dylan...@google.com>
        Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
        Gerrit-Attention: Anusha Muley <anush...@google.com>
        Gerrit-Comment-Date: Fri, 14 Nov 2025 20:53:47 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages