[M129] Unship KeyboardFocusableScrollers, temporarily [chromium/src : refs/branch-heads/6668]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Aug 22, 2024, 5:46:33 PM8/22/24
to Joey Arhar, Chromium LUCI CQ, Kyra Seevers, AyeAye, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Joey Arhar

Mason Freed voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Gerrit-Change-Number: 5804522
Gerrit-PatchSet: 1
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kyra Seevers <kyras...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Aug 2024 21:46:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Aug 22, 2024, 5:47:27 PM8/22/24
to Mason Freed, Chromium LUCI CQ, Kyra Seevers, AyeAye, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed

Joey Arhar voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Gerrit-Change-Number: 5804522
Gerrit-PatchSet: 1
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kyra Seevers <kyras...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Aug 2024 21:47:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Aug 22, 2024, 6:58:45 PM8/22/24
to Joey Arhar, Chromium LUCI CQ, Kyra Seevers, AyeAye, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Joey Arhar

Mason Freed voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Gerrit-Change-Number: 5804522
Gerrit-PatchSet: 1
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kyra Seevers <kyras...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Aug 2024 22:58:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Aug 23, 2024, 10:36:07 AM8/23/24
to Mason Freed, Chromium LUCI CQ, Kyra Seevers, AyeAye, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed

Joey Arhar voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Gerrit-Change-Number: 5804522
Gerrit-PatchSet: 1
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kyra Seevers <kyras...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:35:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 23, 2024, 11:35:58 AM8/23/24
to Mason Freed, Joey Arhar, Kyra Seevers, AyeAye, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M129] Unship KeyboardFocusableScrollers, temporarily

See [1] for details, but due to compat issues, we are going to
disable the feature while we make some adjustments to the
behavior.

This was enabled by default in [2], which landed in M129, so this
CL will need to be merged back to 129.

[1] https://issues.chromium.org/issues/361072782#comment7
[2] https://chromium-review.googlesource.com/c/chromium/src/+/5775613

(cherry picked from commit 9d1ddc1570946d5353a544a6a65bfdf6bd1f751b)
Fixed: 361072782
Bug: 337158524
Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Auto-Submit: Mason Freed <mas...@chromium.org>
Reviewed-by: Di Zhang <dizh...@chromium.org>
Commit-Queue: Di Zhang <dizh...@chromium.org>
Commit-Queue: Mason Freed <mas...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1344534}
Reviewed-by: Joey Arhar <jar...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/branch-heads/6668@{#203}
Cr-Branched-From: 05bc664984ca075216b7f2198c88b9725bfa1b9b-refs/heads/main@{#1343869}
Files:
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: S
Delta: 1 file changed, 5 insertions(+), 6 deletions(-)
Branch: refs/branch-heads/6668
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Joey Arhar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Gerrit-Change-Number: 5804522
Gerrit-PatchSet: 2
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kyra Seevers <kyras...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages