text-box-trim: add tests for text-emphasis + ruby [chromium/src : main]
0 views
Skip to first unread message
Lingqi Chi (Gerrit)
Jul 2, 2024, 4:49:24 AM (yesterday) Jul 2
to Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Koji Ishii
Lingqi Chi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
12:12 AM (6 hours ago) 12:12 AM
to Lingqi Chi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Lingqi Chi
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Lingqi Chi
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
12:19 AM (6 hours ago) 12:19 AM
to Lingqi Chi, Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Lingqi Chi
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/46975.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Lingqi Chi
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lingqi Chi (Gerrit)
1:23 AM (5 hours ago) 1:23 AM
to Blink W3C Test Autoroller, Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Lingqi Chi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lingqi Chi
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:26 AM (5 hours ago) 1:26 AM
to Lingqi Chi, Blink W3C Test Autoroller, Koji Ishii, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
text-box-trim: add tests for text-emphasis + ruby
Both of the annotations should be trimmed when text-box-trim is set.
Bug: 40254880
Change-Id: Ie0f05ad292e0e76f633a3862c826545f509f1797
Reviewed-by: Koji Ishii <ko...@chromium.org>
Commit-Queue: Lingqi Chi <lin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322584}
Files:
- A third_party/blink/web_tests/external/wpt/css/css-inline/text-box-trim/text-box-trim-ruby-start-002.html
Change size: S
Delta: 1 file changed, 27 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Koji Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
2:11 AM (4 hours ago) 2:11 AM
to Lingqi Chi, Chromium LUCI CQ, Koji Ishii, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/46975
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages