[unsafe-buffers] Remove allow_unsafe_buffers from base/ [chromium/src : main]

0 views
Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,
7:10 AM (9 hours ago) 7:10 AM
to SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Arthur Sonzogni added 5 comments

File base/command_line_unittest.cc
Line 503, Patchset 82 (Latest): // SAFETY: CommandLineToArgvW returns an array of size num_args.
auto argv_span =
UNSAFE_TODO(base::span(argv.get(), static_cast<size_t>(num_args)));

std::wstring recreated_command_line;
for (int i = 1; i < num_args; ++i) {
recreated_command_line.append(
CommandLine::QuoteForCommandLineToArgvW(argv_span[i]));
Arthur Sonzogni . unresolved

let's just use UNSAFE_TODO here, without trying to rewrite code, or add SAFETY comments.

File base/ios/device_util.mm
Line 101, Patchset 82 (Latest): // |found_address_struct->sdl_data| contains the interface name followed
// by the interface address. The address part can be accessed based on
// the length of the name, that is, |found_address_struct->sdl_nlen|.
base::span<const unsigned char> address_span = UNSAFE_TODO(
base::span(reinterpret_cast<const unsigned char*>(
&found_address_struct
->sdl_data[found_address_struct->sdl_nlen]),
static_cast<size_t>(found_address_struct->sdl_alen)));

for (size_t i = 0; i < address_span.size(); ++i) {
if (i != 0) {
mac_string.push_back(':');
}
base::StringAppendF(&mac_string, "%02X", address_span[i]);
}
break;
}
Arthur Sonzogni . unresolved

Here, let's not try to improve code. Just use the original code with UNSAFE_TODO where needed.

File base/ios/ios_util.mm
Line 57, Patchset 82 (Latest): bool IsRunningOnOrLater(const std::array<int32_t, 3>& version) const {
for (size_t i = 0; i < current_version_.size(); ++i) {
if (current_version_[i] != version[i]) {
return current_version_[i] > version[i];
}
}
return true;
}

private:
std::array<int32_t, 3> current_version_;
} kOSVersion;

std::array<int32_t, 3> version = {major, minor, bug_fix};
return kOSVersion.IsRunningOnOrLater(version);
Arthur Sonzogni . unresolved

Here, let's just use UNSAFE_TODO where needed and revert the changes to the code.

File base/mac/authorization_util.mm
Line 2, Patchset 82 (Latest):// Use of this source code is governed by a BSD-style license that can be
Arthur Sonzogni . unresolved

Let's revert this file.

File base/mac/test/launch_application_test_helper_main.m
Line 3, Patchset 82 (Latest):// found in the LICENSE file.
Arthur Sonzogni . unresolved

Let's revert this file.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
Gerrit-Change-Number: 8025652
Gerrit-PatchSet: 82
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zhe Su <su...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Jul 2026 11:10:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
8:53 AM (7 hours ago) 8:53 AM
to SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Arthur Sonzogni added 1 comment

File base/command_line_unittest.cc
Line 503, Patchset 88 (Latest): for (int i = 1; i < num_args; ++i) {
recreated_command_line.append(
CommandLine::QuoteForCommandLineToArgvW(UNSAFE_TODO(argv.get()[i])));

if (i + 1 < num_args) {
recreated_command_line.push_back(L' ');
}
}
Arthur Sonzogni . resolved

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
Gerrit-Change-Number: 8025652
Gerrit-PatchSet: 88
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zhe Su <su...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Jul 2026 12:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
8:54 AM (7 hours ago) 8:54 AM
to SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Arthur Sonzogni added 1 comment

File base/ios/device_util.mm
Line 101, Patchset 88 (Latest): // by the interface address. The address part can be accessed based on

// the length of the name, that is, |found_address_struct->sdl_nlen|.
const unsigned char* found_address =
reinterpret_cast<const unsigned char*>(
UNSAFE_TODO(&found_address_struct
->sdl_data[found_address_struct->sdl_nlen]));

int found_address_length = found_address_struct->sdl_alen;
for (int i = 0; i < found_address_length; ++i) {

if (i != 0) {
mac_string.push_back(':');
}
base::StringAppendF(&mac_string, "%02X",
UNSAFE_TODO(found_address[i]));
}
break;
}
Gerrit-Comment-Date: Mon, 06 Jul 2026 12:53:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
8:54 AM (7 hours ago) 8:54 AM
to SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Arthur Sonzogni added 1 comment

File base/ios/ios_util.mm
Line 57, Patchset 88 (Latest): for (size_t i = 0; i < std::size(current_version_); ++i) {
if (UNSAFE_TODO(current_version_[i]) != UNSAFE_TODO(version[i])) {
return UNSAFE_TODO(current_version_[i]) > UNSAFE_TODO(version[i]);
}
}
return true;
}

private:
int32_t current_version_[3];
} kOSVersion;

int32_t version[3] = {major, minor, bug_fix};
return kOSVersion.IsRunningOnOrLater(version);
}
Gerrit-Comment-Date: Mon, 06 Jul 2026 12:53:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
8:54 AM (7 hours ago) 8:54 AM
to SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Arthur Sonzogni added 1 comment

File base/mac/authorization_util.mm
Line 2, Patchset 82:// Use of this source code is governed by a BSD-style license that can be
Arthur Sonzogni . resolved

Let's revert this file.

Arthur Sonzogni

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
Gerrit-Change-Number: 8025652
Gerrit-PatchSet: 82
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zhe Su <su...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Jul 2026 12:54:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Sonzogni <arthurs...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
8:54 AM (7 hours ago) 8:54 AM
to SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Arthur Sonzogni added 1 comment

File base/mac/test/launch_application_test_helper_main.m
Line 3, Patchset 82:// found in the LICENSE file.
Arthur Sonzogni . resolved

Let's revert this file.

Arthur Sonzogni

Done

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
    Gerrit-Change-Number: 8025652
    Gerrit-PatchSet: 82
    Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Zhe Su <su...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 12:54:18 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Arthur Sonzogni (Gerrit)

    unread,
    9:48 AM (6 hours ago) 9:48 AM
    to Daniel Cheng, SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
    Attention needed from Daniel Cheng

    Arthur Sonzogni voted and added 3 comments

    Votes added by Arthur Sonzogni

    Auto-Submit+1
    Code-Review+1

    3 comments

    Patchset-level comments
    File-level comment, Patchset 88 (Latest):
    Arthur Sonzogni . resolved

    This looks good to me.

    @dch...@chromium.org, could you please take take a look.


    (Note that it contains two std::array rewrite along the way)

    File base/command_line_unittest.cc
    Line 503, Patchset 82: // SAFETY: CommandLineToArgvW returns an array of size num_args.

    auto argv_span =
    UNSAFE_TODO(base::span(argv.get(), static_cast<size_t>(num_args)));

    std::wstring recreated_command_line;
    for (int i = 1; i < num_args; ++i) {
    recreated_command_line.append(
    CommandLine::QuoteForCommandLineToArgvW(argv_span[i]));
    Arthur Sonzogni . resolved

    let's just use UNSAFE_TODO here, without trying to rewrite code, or add SAFETY comments.

    Arthur Sonzogni

    Acknowledged

    File base/ios/device_util.mm
    Line 101, Patchset 82: // |found_address_struct->sdl_data| contains the interface name followed

    // by the interface address. The address part can be accessed based on
    // the length of the name, that is, |found_address_struct->sdl_nlen|.
    base::span<const unsigned char> address_span = UNSAFE_TODO(
    base::span(reinterpret_cast<const unsigned char*>(
    &found_address_struct
    ->sdl_data[found_address_struct->sdl_nlen]),
    static_cast<size_t>(found_address_struct->sdl_alen)));

    for (size_t i = 0; i < address_span.size(); ++i) {

    if (i != 0) {
    mac_string.push_back(':');
    }
    base::StringAppendF(&mac_string, "%02X", address_span[i]);
    }
    break;
    }
    Arthur Sonzogni . resolved

    Here, let's not try to improve code. Just use the original code with UNSAFE_TODO where needed.

    Arthur Sonzogni

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
    Gerrit-Change-Number: 8025652
    Gerrit-PatchSet: 88
    Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Zhe Su <su...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 13:48:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Arthur Sonzogni <arthurs...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    11:01 AM (5 hours ago) 11:01 AM
    to Arthur Sonzogni, Daniel Cheng, SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
    Attention needed from Arthur Sonzogni

    Daniel Cheng voted and added 2 comments

    Votes added by Daniel Cheng

    Code-Review+1

    2 comments

    Patchset-level comments
    Daniel Cheng . resolved

    LGTM

    File base/message_loop/message_pump_apple.mm
    Line 156, Patchset 88 (Latest): return modes[static_cast<size_t>(mode_index_)];
    Daniel Cheng . unresolved

    Though it would be nice to avoid the cast here by using the correct type to begin with.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Arthur Sonzogni
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
    Gerrit-Change-Number: 8025652
    Gerrit-PatchSet: 88
    Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Zhe Su <su...@chromium.org>
    Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 15:01:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Arthur Sonzogni (Gerrit)

    unread,
    11:09 AM (5 hours ago) 11:09 AM
    to Daniel Cheng, SLSA Policy Verification Service, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

    Arthur Sonzogni voted and added 2 comments

    Votes added by Arthur Sonzogni

    Commit-Queue+2

    2 comments

    Patchset-level comments
    Arthur Sonzogni . resolved

    Thanks!

    File base/message_loop/message_pump_apple.mm
    Line 156, Patchset 88 (Latest): return modes[static_cast<size_t>(mode_index_)];
    Daniel Cheng . resolved

    Though it would be nice to avoid the cast here by using the correct type to begin with.

    Arthur Sonzogni

    I am planning a follow-up.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
      Gerrit-Change-Number: 8025652
      Gerrit-PatchSet: 88
      Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: Zhe Su <su...@chromium.org>
      Gerrit-Comment-Date: Mon, 06 Jul 2026 15:08:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      11:12 AM (5 hours ago) 11:12 AM
      to Arthur Sonzogni, Daniel Cheng, SLSA Policy Verification Service, Akihiro Ota, (Julie)Jeongeun Kim, Kevin Babbitt, Zhe Su, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org, caitkp...@chromium.org, derinel+wat...@google.com, tranbaod...@chromium.org, hidehik...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, yhanad...@chromium.org, arc-review...@google.com, keithle...@chromium.org, nona+...@chromium.org, webauthn...@chromium.org, gcasto+w...@chromium.org, shuche...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, agriev...@chromium.org, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, grt+...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, kinuko...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, titoua...@chromium.org, torne...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [unsafe-buffers] Remove allow_unsafe_buffers from base/

      This is a mechanical change transitioning the last few files in base/
      from coarse, file-level pragmas to fine-grained, instruction-level
      UNSAFE_TODO() macros.
      Bug: 351564777, 501112808
      Doc: go/complete_unsafe_todo_migration
      Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
      Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
      Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
      Reviewed-by: Daniel Cheng <dch...@chromium.org>
      Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1657199}
      Files:
      • M base/allocator/dispatcher/testing/observer_mock.h
      • M base/allocator/dispatcher/testing/tools.h
      • M base/command_line_unittest.cc
      • M base/debug/asan_invalid_access.cc
      • M base/debug/test_elf_image_builder.cc
      • M base/i18n/file_util_icu.cc
      • M base/ios/device_util.mm
      • M base/ios/ios_util.mm
      • M base/logging_win.cc
      • M base/message_loop/message_pump_apple.mm
      • M base/system/sys_info_win.cc
      • M base/time/time_win_unittest.cc
      • M base/tools_sanity_unittest.cc
      • M base/win/com_init_check_hook.cc
      • M base/win/event_trace_controller.cc
      • M base/win/pe_image_reader.cc
      • M base/win/registry_unittest.cc
      Change size: L
      Delta: 17 files changed, 115 insertions(+), 178 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Daniel Cheng, +1 by Arthur Sonzogni
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ibe7e73becd77e67625fc473cec312687ad9fc3ac
      Gerrit-Change-Number: 8025652
      Gerrit-PatchSet: 89
      Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages