[bindings] Retain underlying array buffer for [PassAsSpan] arrays... [chromium/src : main]
0 views
Skip to first unread message
Nate Chapin (Gerrit)
Feb 20, 2026, 5:46:55 PM (8 days ago) Feb 20
to Andrey Kosyakov, Daniel Cheng, Andreas Haas, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Andrey Kosyakov and Daniel Cheng
Nate Chapin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrey Kosyakov
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Feb 20, 2026, 5:47:19 PM (8 days ago) Feb 20
to Nate Chapin, Daniel Cheng, Andreas Haas, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Daniel Cheng
Andrey Kosyakov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Feb 20, 2026, 5:47:34 PM (8 days ago) Feb 20
to Nate Chapin, Daniel Cheng, Andreas Haas, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Andrey Kosyakov and Daniel Cheng
Andrey Kosyakov voted![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Feb 22, 2026, 10:59:18 PM (6 days ago) Feb 22
to Andrey Kosyakov, Daniel Cheng, Nate Chapin, Andreas Haas, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Andrey Kosyakov
Daniel Cheng voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Feb 22, 2026, 10:59:51 PM (6 days ago) Feb 22
to Andrey Kosyakov, Daniel Cheng, Nate Chapin, Andreas Haas, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Andrey Kosyakov
Daniel Cheng added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/bindings/core/v8/pass_as_span.h
Line 18, Patchset 4 (Latest):
template <bool SupportReentry>Daniel Cheng . unresolved
(I usually see these named with constant-style names, e.g. kSupportReentry, but I don't feel strongly about this)
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Feb 23, 2026, 1:21:08 PM (5 days ago) Feb 23
to Daniel Cheng, Nate Chapin, Andreas Haas, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Auto-Submit | +1 |
1 comment
File third_party/blink/renderer/bindings/core/v8/pass_as_span.h
(I usually see these named with constant-style names, e.g. kSupportReentry, but I don't feel strongly about this)
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Feb 23, 2026, 1:28:03 PM (5 days ago) Feb 23
to Andrey Kosyakov, Daniel Cheng, Nate Chapin, Andreas Haas, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57992.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Feb 24, 2026, 1:28:05 PM (4 days ago) Feb 24
to Blink W3C Test Autoroller, Daniel Cheng, Nate Chapin, Andreas Haas, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Andrey Kosyakov voted![]( "Open in Gerrit")
| Auto-Submit | +0 |
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Feb 24, 2026, 2:35:03 PM (4 days ago) Feb 24
to Andrey Kosyakov, Blink W3C Test Autoroller, Daniel Cheng, Nate Chapin, Andreas Haas, AI Code Reviewer, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/bindings/core/v8/pass_as_span.h
Insertions: 7, Deletions: 7.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[bindings] Retain underlying array buffer for [PassAsSpan] arrays...
if re-entry into JS is possible while converting other params or within the function
Bug: 484946544
Change-Id: I5ca911656d37bb77b10168da6455dfc403587d82
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1589594}
Files:
- M PRESUBMIT.py
- M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl.cc
- M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl.h
- M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl_test.cc
- M third_party/blink/renderer/bindings/core/v8/pass_as_span.h
- M third_party/blink/renderer/bindings/scripts/bind_gen/blink_v8_bridge.py
- M third_party/blink/web_tests/external/wpt/encoding/textdecoder-arguments.any.js
Change size: M
Delta: 7 files changed, 141 insertions(+), 48 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng, +1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Feb 24, 2026, 3:15:39 PM (4 days ago) Feb 24
to Chromium LUCI CQ, Andrey Kosyakov, Daniel Cheng, Nate Chapin, Andreas Haas, AI Code Reviewer, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57992
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikita Skovoroda (Gerrit)
3:53 PM (5 hours ago) 3:53 PM
to Chromium LUCI CQ, Andrey Kosyakov, Blink W3C Test Autoroller, Daniel Cheng, Nate Chapin, Andreas Haas, AI Code Reviewer, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Nikita Skovoroda added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Nikita Skovoroda . unresolved
The test here was wrong (and the implemented behavior is wrong too I guess?)
The exact opposite should be happening
I fixed the test in WPT: https://github.com/web-platform-tests/wpt/pull/58101
Reply all
Reply to author
Forward
0 new messages