Remove enterprise policy for KeyboardFocusableScrollers at 138 [chromium/src : main]
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From chrome/enterprise/gwsq/enterprise-policy-review.gwsq:
Note: A shadow reviewer was assigned to this CL. go/new-policy-review-process
Shadowed: seblalancette
Reviewer source(s):
hend...@chromium.org, seblalancette is from context(chrome/enterprise/gwsq/enterprise-policy-review.gwsq)
Related details
- Alexander Hendrich
- Avi Drissman
- Philip Rogers
- Sébastien Lalancette
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman added 1 comment![]( "Open in Gerrit")
policy::policy_prefs::kKeyboardFocusableScrollersEnabled, true);Please follow [procedure for removing a pref](https://chromium.googlesource.com/chromium/src/+/refs/heads/main/chrome/browser/prefs/README.md#deleting-an-old-pref) to clean it up.
Related details
- Alexander Hendrich
- Di Zhang
- Philip Rogers
- Sébastien Lalancette
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman added 1 comment![]( "Open in Gerrit")
Sébastien Lalancette (Gerrit)
Sébastien Lalancette added 2 comments![]( "Open in Gerrit")
1258: 'KeyboardFocusableScrollersEnabled'I will let @hend...@chromium.org comment on this, but I don't think this line should be changed (as it was indeed launched in the past, see https://source.chromium.org/chromium/chromium/src/+/main:docs/enterprise/life_of_a_policy.md).
default: trueYou should also add:
`deprecated: true`
Related details
- Alexander Hendrich
- Di Zhang
- Philip Rogers
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Di Zhang added 3 comments![]( "Open in Gerrit")
policy::policy_prefs::kKeyboardFocusableScrollersEnabled, true);Please follow [procedure for removing a pref](https://chromium.googlesource.com/chromium/src/+/refs/heads/main/chrome/browser/prefs/README.md#deleting-an-old-pref) to clean it up.
Done
I will let @hend...@chromium.org comment on this, but I don't think this line should be changed (as it was indeed launched in the past, see https://source.chromium.org/chromium/chromium/src/+/main:docs/enterprise/life_of_a_policy.md).
Ah, my bad, I was wondering if I should change it to '' and then changed the wrong thing.
You should also add:
`deprecated: true`
- Alexander Hendrich
- Avi Drissman
- Philip Rogers
- Sébastien Lalancette
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Avi Drissman
| Code-Review | +1 |
1 comment
Related details
- Alexander Hendrich
- Di Zhang
- Philip Rogers
- Sébastien Lalancette
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Hendrich (Gerrit)
Alexander Hendrich voted and added 3 comments![]( "Open in Gerrit")
Votes added by Alexander Hendrich
| Code-Review | +1 |
3 comments
lgtm with nits
const char kKeyboardFocusableScrollersEnabled[] =this pref was only written to by the policy stack, which keeps the values in memory. Therefore, you don't need any of the changes in this file. These changes are required for user-writable prefs, where values are stored as JSON file on disk. In order to clear the stale values from these files, you would need to do this cleanup work here. You can just remove your pref without this.
"reason_for_missing_test": "Policy was removed"actually delete this file then
Related details
- Di Zhang
- Philip Rogers
- Sébastien Lalancette
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sébastien Lalancette (Gerrit)
Sébastien Lalancette voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Di Zhang
- Philip Rogers
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Di Zhang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Di Zhang
| Commit-Queue | +1 |
2 comments
const char kKeyboardFocusableScrollersEnabled[] =this pref was only written to by the policy stack, which keeps the values in memory. Therefore, you don't need any of the changes in this file. These changes are required for user-writable prefs, where values are stored as JSON file on disk. In order to clear the stale values from these files, you would need to do this cleanup work here. You can just remove your pref without this.
Thanks, this was unclear in the documentation. I saw some people add it, and some don't and I wasn't sure what to do.
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/chrome/browser/prefs/README.md#deleting-an-old-pref-exposed-by-a-policy
I will still follow step 6 in another CL.
actually delete this file then
- Alexander Hendrich
- Avi Drissman
- Philip Rogers
- Sébastien Lalancette
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman added 1 comment![]( "Open in Gerrit")
const char kKeyboardFocusableScrollersEnabled[] =Di Zhangthis pref was only written to by the policy stack, which keeps the values in memory. Therefore, you don't need any of the changes in this file. These changes are required for user-writable prefs, where values are stored as JSON file on disk. In order to clear the stale values from these files, you would need to do this cleanup work here. You can just remove your pref without this.
Thanks, this was unclear in the documentation. I saw some people add it, and some don't and I wasn't sure what to do.
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/chrome/browser/prefs/README.md#deleting-an-old-pref-exposed-by-a-policy
I will still follow step 6 in another CL.
My apologies! I missed that subtlety.
Thank you for pointing that out. TIL.
Related details
- Alexander Hendrich
- Di Zhang
- Philip Rogers
- Sébastien Lalancette
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Philip Rogers voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Rogers
| Code-Review | +1 |
1 comment
Related details
- Alexander Hendrich
- Di Zhang
- Sébastien Lalancette
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Di Zhang voted Commit-Queue+2![]( "Open in Gerrit")
- Alexander Hendrich
- Sébastien Lalancette
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Remove enterprise policy for KeyboardFocusableScrollers at 138
We decided to remove this enterprise policy in 138 to match the end
of its opt-out origin trial.
chromestatus:
https://chromestatus.com/feature/5231964663578624
- M chrome/browser/chrome_content_browser_client.cc
- M chrome/browser/policy/BUILD.gn
- M chrome/browser/policy/configuration_policy_handler_list_factory.cc
- D chrome/browser/policy/test/keyboard_focusable_scollers_policy_browsertest.cc
- M components/policy/core/common/policy_pref_names.cc
- M components/policy/core/common/policy_pref_names.h
- M components/policy/resources/templates/policy_definitions/Miscellaneous/KeyboardFocusableScrollersEnabled.yaml
- D components/policy/test/data/pref_mapping/KeyboardFocusableScrollersEnabled.json
- M content/child/runtime_features.cc
- M third_party/blink/common/switches.cc
- M third_party/blink/public/common/switches.h
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Code-Review: +1 by Philip Rogers
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |