[Fetch API][Interop2026] Implement Fetch-compliant Range handling for Blob URLs [chromium/src : main]

[Mayur Patil (Gerrit)]

Attention needed from Jatin Mittal

Mayur Patil added 10 comments

File net/http/http_util.cc

Line 229, Patchset 3 (Latest):// static

Mayur Patil . unresolved

// Parses Fetch's "single range header value" for the "bytes" range
 // unit. Optional HTTP tab/space around '=' and '-' is accepted only when
 // `allow_whitespace` is true. At least one side of the range must contain
 // digits.

Line 230, Patchset 3 (Latest):bool HttpUtil::ParseFetchSingleRange(std::string_view value,

Mayur Patil . unresolved

nit: range_header_value

Line 232, Patchset 3 (Latest): HttpByteRange* range) {

Mayur Patil . unresolved

nit: range_out

Line 233, Patchset 3 (Latest): // Range unit must be "bytes".

Mayur Patil . unresolved

// Fetch requires the range unit to be exactly "bytes".

Line 241, Patchset 3 (Latest): auto skip_ws = [&]() {

Mayur Patil . unresolved

nit: skip_optional_whitespace

Line 249, Patchset 3 (Latest): auto consume_char = [&](char c) {

Mayur Patil . unresolved

Rename lambda parameter as `delimiter` & consume_char with `consume_delimiter`

Also add supporting comment

Line 261, Patchset 3 (Latest): bool overflow = false;

Mayur Patil . unresolved

nit: number_overflowed

and comment : // Fetch parses range numbers as decimal numbers, but HttpByteRange stores them as int64_t, so overflow is treated as parse failure here.

Line 262, Patchset 3 (Latest): auto collect_digits = [&]() -> std::optional<int64_t> {

Mayur Patil . unresolved

nit: parse_decimal_number

Add a supporting comment above this method

Line 271, Patchset 3 (Latest): if (!base::StringToInt64(value.substr(start, pos - start), &parsed)) {

Mayur Patil . unresolved

`ParseInt64` makes the intent much clearer

Line 292, Patchset 3 (Latest): if (!range_start) {
*range = HttpByteRange::Suffix(*range_end);
} else if (range_end) {
*range = HttpByteRange::Bounded(*range_start, *range_end);
} else {
*range = HttpByteRange::RightUnbounded(*range_start);
}
// Reject syntactically valid but invalid ranges.
return range->IsValid();
}

Mayur Patil . unresolved

Do not update range out parameter unless it is validated.

if (range is valid)
  then only update range out parameter

Open in Gerrit

Related details

Attention is currently required from:

• Jatin Mittal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 3

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Comment-Date: Mon, 15 Jun 2026 09:24:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mayur Patil (Gerrit)]

Attention needed from Jatin Mittal

Mayur Patil added 1 comment

File net/http/http_util.cc

Line 292, Patchset 3 (Latest): if (!range_start) {
*range = HttpByteRange::Suffix(*range_end);
} else if (range_end) {
*range = HttpByteRange::Bounded(*range_start, *range_end);
} else {
*range = HttpByteRange::RightUnbounded(*range_start);
}
// Reject syntactically valid but invalid ranges.
return range->IsValid();
}

Mayur Patil . unresolved

Do not update range out parameter unless it is validated.

if (range is valid)
  then only update range out parameter

Mayur Patil

Instead, the better way would be to remove out parameter and use
optional<HttpByteRange> return type.

if invalid return nullopt

Gerrit-Comment-Date: Mon, 15 Jun 2026 09:25:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mayur Patil <patil...@microsoft.com>

[Jatin Mittal (Gerrit)]

Attention needed from Mayur Patil

Jatin Mittal added 10 comments

File net/http/http_util.cc

Line 229, Patchset 3:// static

Mayur Patil . resolved

// Parses Fetch's "single range header value" for the "bytes" range
 // unit. Optional HTTP tab/space around '=' and '-' is accepted only when
 // `allow_whitespace` is true. At least one side of the range must contain
 // digits.

Jatin Mittal

Updated the comment

Line 230, Patchset 3:bool HttpUtil::ParseFetchSingleRange(std::string_view value,

Mayur Patil . resolved

nit: range_header_value

Jatin Mittal

Renamed value to range_header_value.

Line 232, Patchset 3: HttpByteRange* range) {

Mayur Patil . resolved

nit: range_out

Jatin Mittal

This is no longer applicable after switching to the std::optional<HttpByteRange> return type, since the range parameter has been removed.

Line 233, Patchset 3: // Range unit must be "bytes".

Mayur Patil . resolved

// Fetch requires the range unit to be exactly "bytes".

Jatin Mittal

Done

Line 241, Patchset 3: auto skip_ws = [&]() {

Mayur Patil . resolved

nit: skip_optional_whitespace

Jatin Mittal

Renamed in the next patchset.

Line 249, Patchset 3: auto consume_char = [&](char c) {

Mayur Patil . resolved

Rename lambda parameter as `delimiter` & consume_char with `consume_delimiter`

Also add supporting comment

Jatin Mittal

both renamed in the next patchset.

Line 261, Patchset 3: bool overflow = false;

Mayur Patil . resolved

nit: number_overflowed

and comment : // Fetch parses range numbers as decimal numbers, but HttpByteRange stores them as int64_t, so overflow is treated as parse failure here.

Jatin Mittal

Done

Line 262, Patchset 3: auto collect_digits = [&]() -> std::optional<int64_t> {

Mayur Patil . resolved

nit: parse_decimal_number

Add a supporting comment above this method

Jatin Mittal

Done

Line 271, Patchset 3: if (!base::StringToInt64(value.substr(start, pos - start), &parsed)) {

Mayur Patil . resolved

`ParseInt64` makes the intent much clearer

Jatin Mittal

Switched to net::ParseInt64(...) in the next patchset.

Line 292, Patchset 3: if (!range_start) {


*range = HttpByteRange::Suffix(*range_end);
} else if (range_end) {
*range = HttpByteRange::Bounded(*range_start, *range_end);
} else {
*range = HttpByteRange::RightUnbounded(*range_start);
}
// Reject syntactically valid but invalid ranges.
return range->IsValid();
}

Mayur Patil . resolved

Do not update range out parameter unless it is validated.

if (range is valid)
  then only update range out parameter

Mayur Patil

Instead, the better way would be to remove out parameter and use
optional<HttpByteRange> return type.

if invalid return nullopt

Jatin Mittal

Good point. Switched to a std::optional<HttpByteRange> return type and return std::nullopt on failure, which removes the out parameter and avoids partial updates.

Open in Gerrit

Related details

Attention is currently required from:

• Mayur Patil

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 4

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mayur Patil <patil...@microsoft.com>

Gerrit-Comment-Date: Tue, 16 Jun 2026 03:59:04 +0000

[Mayur Patil (Gerrit)]

Attention needed from Jatin Mittal

Mayur Patil added 1 comment

File net/http/http_util.cc

Line 303, Patchset 4 (Latest): HttpByteRange range;

Mayur Patil . unresolved

nit: candidate_range

Open in Gerrit

Related details

Attention is currently required from:

• Jatin Mittal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 4

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Comment-Date: Tue, 16 Jun 2026 14:38:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jatin Mittal (Gerrit)]

Attention needed from Mayur Patil

Jatin Mittal added 1 comment

File net/http/http_util.cc

Line 303, Patchset 4 (Latest): HttpByteRange range;

Mayur Patil . resolved

nit: candidate_range

Jatin Mittal

Done

Open in Gerrit

Related details

Attention is currently required from:

• Mayur Patil

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 4

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mayur Patil <patil...@microsoft.com>

Gerrit-Comment-Date: Tue, 16 Jun 2026 16:16:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mayur Patil <patil...@microsoft.com>

[Mayur Patil (Gerrit)]

Attention needed from Jatin Mittal

Mayur Patil added 5 comments

File net/http/http_util.cc

Line 246, Patchset 5 (Latest): allow_whitespace && pos < range_header_value.size() &&

Mayur Patil . unresolved

allow_whitespace is checked everytime inside while loop

add a condition 
```
if (allow_whitespace)
  return
```

Line 246, Patchset 5 (Latest): allow_whitespace && pos < range_header_value.size() &&

Mayur Patil . unresolved

```
 // Helper: Check if we can still read from the input
   auto in_bounds = [&]() {
     return pos < range_header_value.size();
   };
```

introduce this helper, it will make it more readable

Line 256, Patchset 5 (Latest): if (pos >= range_header_value.size() ||

Mayur Patil . unresolved

```
 if (!in_bounds()) {
     return false;
   }
   if (range_header_value[pos] != delimiter) {
     return false;
   }
   
   ```

Line 298, Patchset 5 (Latest): if (pos != range_header_value.size() || number_overflowed ||
(!range_start && !range_end)) {

Mayur Patil . unresolved

`(in_bounds() || number_overflowed || (!range_start && !range_end))`

Line 303, Patchset 5 (Latest): HttpByteRange candidate_range;

Mayur Patil . unresolved

nit:
```
std::optional<HttpByteRange> candidate_range;
```
and accordingly update the if statement
```
 if (!candidate_range->IsValid()) {
   return std::nullopt;
 }
```

Open in Gerrit

Related details

Attention is currently required from:

• Jatin Mittal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 5

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: kokoro <noreply...@google.com>

Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Comment-Date: Wed, 17 Jun 2026 04:51:19 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mayur Patil (Gerrit)]

Attention needed from Jatin Mittal

Mayur Patil added 1 comment

File net/http/http_util.cc

Line 237, Patchset 5 (Latest): constexpr std::string_view kBytesUnit = "bytes";

Mayur Patil . unresolved

"bytes" is used in multiple places in the file. Can you make this field reusable?
Move it to an nameless namespace and use it throughout the file?

[Mayur Patil (Gerrit)]

Attention needed from Jatin Mittal

Mayur Patil added 2 comments

File net/http/http_util_unittest.cc

Line 1271, Patchset 5 (Latest):// Verifies that optional HTTP tab/space around '=' and '-' is accepted
// only when `allow_whitespace` is true, and rejected otherwise.
TEST(HttpUtilTest, ParseFetchSingleRangeAcceptsWhitespaceWhenAllowed) {
static constexpr const char* kCases[] = {
"bytes =5-10", "bytes= 5-10", "bytes=5 -10",
"bytes=5- 10", "bytes=5\t-\t10",
};
for (const char* value : kCases) {
SCOPED_TRACE(value);
// Spec-allowed whitespace is accepted only when enabled.
std::optional<HttpByteRange> range =
HttpUtil::ParseFetchSingleRange(value, /*allow_whitespace=*/true);
ASSERT_TRUE(range.has_value());
EXPECT_EQ(5, range->first_byte_position());
EXPECT_EQ(10, range->last_byte_position());
EXPECT_FALSE(
HttpUtil::ParseFetchSingleRange(value, /*allow_whitespace=*/false)
.has_value());
}
}

Mayur Patil . unresolved

The test coverage is good, but consider adding two more test cases:

 1. Boundary value testing: Add a test for edge cases like  bytes=0-  (zero-start open-ended) and  bytes=-1  (single-byte suffix). These are valid but at the boundaries of typical usage.
 2. Strict mode positive cases: The existing ParseFetchSingleRangeAcceptsWhitespaceWhenAllowed  test verifies that  allow_whitespace=false  rejects whitespace, but doesn't verify that valid ranges without whitespace still parse successfully in strict mode. Add a     test that confirms  bytes=5-10 ,  bytes=5- , and  bytes=-5  work with  allow_whitespace=false .

File storage/browser/blob/blob_url_loader.cc

Line 136, Patchset 5 (Latest): // Reuses the multi-range error code; surfaces to Fetch as a TypeError.

Mayur Patil . unresolved

// Range header is invalid or malformed. Fail the request.

Gerrit-Comment-Date: Wed, 17 Jun 2026 05:19:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Himanshu Panwar (Gerrit)]

Attention needed from Jatin Mittal

Himanshu Panwar added 2 comments

File net/http/http_util.cc

Line 298, Patchset 4: if (pos != range_header_value.size() || number_overflowed ||

Himanshu Panwar . unresolved

Overflow: The spec says "interpreted as decimal number" which is conceptually
    unbounded. So `bytes=4-999999999999999999999999` should parse successfully —
    the serving layer would clamp rangeEnd to fullLength-1 later. Currently int64_t
    overflow → std::nullopt → network error.
 
    Possible fix: If rangeStart parsed OK but rangeEnd overflows, saturate to a
    right-unbounded range (equivalent to `bytes=4-`), since clamping would produce
    the same result anyway.

Line 312, Patchset 4: if (!range.IsValid()) {
return std::nullopt;

Himanshu Panwar . unresolved

`bytes=-0`: Tracing the spec algorithm — rangeStart="" → null, rangeEnd="0" → 0.
    Neither "both null" nor "start > end" conditions trigger, so it returns (null, 0).
    The spec parser accepts it. Currently rejected via HttpByteRange::IsValid() inside
    the parser, conflating parsing with semantic validity.
 
    Possible fix: Move the IsValid() check to the caller (BlobURLLoader), so the
    parser is purely syntactic. The caller can then reject "last 0 bytes" as a
    serving-level decision.

Open in Gerrit

Related details

Attention is currently required from:

• Jatin Mittal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 4

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: kokoro <noreply...@google.com>

Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Comment-Date: Wed, 17 Jun 2026 06:16:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jatin Mittal (Gerrit)]

Attention needed from Himanshu Panwar and Mayur Patil

Jatin Mittal added 10 comments

File net/http/http_util.cc

Line 237, Patchset 5: constexpr std::string_view kBytesUnit = "bytes";

Mayur Patil . resolved

"bytes" is used in multiple places in the file. Can you make this field reusable?
Move it to an nameless namespace and use it throughout the file?

Jatin Mittal

Done, hoisted `kBytesUnit` into the anonymous namespace and reused it across the range-parsing helpers to avoid duplicating the `"bytes"` literal.

Line 246, Patchset 5: allow_whitespace && pos < range_header_value.size() &&

Mayur Patil . resolved

```
 // Helper: Check if we can still read from the input
   auto in_bounds = [&]() {
     return pos < range_header_value.size();
   };
```

introduce this helper, it will make it more readable

Jatin Mittal

Done

Line 246, Patchset 5: allow_whitespace && pos < range_header_value.size() &&

Mayur Patil . resolved

allow_whitespace is checked everytime inside while loop

add a condition 
```
if (allow_whitespace)
  return
```

Jatin Mittal

Done

Line 256, Patchset 5: if (pos >= range_header_value.size() ||

Mayur Patil . resolved

```
 if (!in_bounds()) {
     return false;
   }
   if (range_header_value[pos] != delimiter) {
     return false;
   }
   
   ```

Jatin Mittal

updated this to use `in_bounds()`

Line 298, Patchset 4: if (pos != range_header_value.size() || number_overflowed ||

Himanshu Panwar . resolved

Overflow: The spec says "interpreted as decimal number" which is conceptually
    unbounded. So `bytes=4-999999999999999999999999` should parse successfully —
    the serving layer would clamp rangeEnd to fullLength-1 later. Currently int64_t
    overflow → std::nullopt → network error.
 
    Possible fix: If rangeStart parsed OK but rangeEnd overflows, saturate to a
    right-unbounded range (equivalent to `bytes=4-`), since clamping would produce
    the same result anyway.

Jatin Mittal

Done. I updated the parser to saturate overflowing values to `int64_t::max()` rather than rejecting them. This preserves the spec behavior for all range forms (`bytes=4-999...`, `bytes=-999...`, and `bytes=999...-`) while allowing the existing `HttpByteRange::ComputeBounds()` logic to perform the appropriate clamping or rejection. Added `ParseFetchSingleRangeSaturatesOverflow` coverage for these cases as well.

Line 298, Patchset 5: if (pos != range_header_value.size() || number_overflowed ||
(!range_start && !range_end)) {

Mayur Patil . resolved

`(in_bounds() || number_overflowed || (!range_start && !range_end))`

Jatin Mittal

Done

Line 303, Patchset 5: HttpByteRange candidate_range;

Mayur Patil . resolved

nit:
```
std::optional<HttpByteRange> candidate_range;
```
and accordingly update the if statement
```
 if (!candidate_range->IsValid()) {
   return std::nullopt;
 }
```

Jatin Mittal

changed `candidate_range` to `std::optional<HttpByteRange>` and updated the validity check to use `!candidate_range->IsValid()`.

Line 312, Patchset 4: if (!range.IsValid()) {
return std::nullopt;

Himanshu Panwar . resolved

`bytes=-0`: Tracing the spec algorithm — rangeStart="" → null, rangeEnd="0" → 0.
    Neither "both null" nor "start > end" conditions trigger, so it returns (null, 0).
    The spec parser accepts it. Currently rejected via HttpByteRange::IsValid() inside
    the parser, conflating parsing with semantic validity.
 
    Possible fix: Move the IsValid() check to the caller (BlobURLLoader), so the
    parser is purely syntactic. The caller can then reject "last 0 bytes" as a
    serving-level decision.

Jatin Mittal

Separated parsing from validation. The parser now follows the Fetch spec and accepts bytes=-0 syntactically, while BlobURLLoader rejects semantically invalid ranges during request handling. This keeps parsing spec-compliant and validation at the serving layer.

File net/http/http_util_unittest.cc

Line 1271, Patchset 5:// Verifies that optional HTTP tab/space around '=' and '-' is accepted


// only when `allow_whitespace` is true, and rejected otherwise.
TEST(HttpUtilTest, ParseFetchSingleRangeAcceptsWhitespaceWhenAllowed) {
static constexpr const char* kCases[] = {
"bytes =5-10", "bytes= 5-10", "bytes=5 -10",
"bytes=5- 10", "bytes=5\t-\t10",
};
for (const char* value : kCases) {
SCOPED_TRACE(value);
// Spec-allowed whitespace is accepted only when enabled.
std::optional<HttpByteRange> range =
HttpUtil::ParseFetchSingleRange(value, /*allow_whitespace=*/true);
ASSERT_TRUE(range.has_value());
EXPECT_EQ(5, range->first_byte_position());
EXPECT_EQ(10, range->last_byte_position());
EXPECT_FALSE(
HttpUtil::ParseFetchSingleRange(value, /*allow_whitespace=*/false)
.has_value());
}
}

Mayur Patil . resolved

The test coverage is good, but consider adding two more test cases:

 1. Boundary value testing: Add a test for edge cases like  bytes=0-  (zero-start open-ended) and  bytes=-1  (single-byte suffix). These are valid but at the boundaries of typical usage.
 2. Strict mode positive cases: The existing ParseFetchSingleRangeAcceptsWhitespaceWhenAllowed  test verifies that  allow_whitespace=false  rejects whitespace, but doesn't verify that valid ranges without whitespace still parse successfully in strict mode. Add a     test that confirms  bytes=5-10 ,  bytes=5- , and  bytes=-5  work with  allow_whitespace=false .

Jatin Mittal

Done. Added ParseFetchSingleRangeAcceptsBoundaryValues covering
bytes=0- and bytes=-1 ,
and ParseFetchSingleRangeAcceptsValidRangesInStrictMode which confirms
bytes=5-10, bytes=5-, and bytes=-5 all parse with
allow_whitespace=false.

File storage/browser/blob/blob_url_loader.cc

Line 136, Patchset 5: // Reuses the multi-range error code; surfaces to Fetch as a TypeError.

Mayur Patil . resolved

// Range header is invalid or malformed. Fail the request.

Jatin Mittal

Done

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar
• Mayur Patil

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 6

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: kokoro <noreply...@google.com>

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Mayur Patil <patil...@microsoft.com>

Gerrit-Comment-Date: Wed, 17 Jun 2026 18:13:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Himanshu Panwar <himp...@microsoft.com>

Comment-In-Reply-To: Mayur Patil <patil...@microsoft.com>

[Rakina Zata Amni (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar and Jatin Mittal

Rakina Zata Amni voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Jatin Mittal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 9

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Ale Bzk <ales...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Anurag Simgeker <anurags...@google.com>

Gerrit-CC: Avi Drissman <a...@chromium.org>

Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>

Gerrit-CC: CJ DiMeglio <lethala...@chromium.org>

Gerrit-CC: Charles Hager <clh...@google.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fernando Fiori <ffi...@microsoft.com>

Gerrit-CC: Frank Liberato <libe...@chromium.org>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Hans Wennborg <ha...@chromium.org>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hirokazu Honda <hi...@chromium.org>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Ian Vollick <vol...@chromium.org>

Gerrit-CC: Ilya Biryukov <ibir...@google.com>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Javier Fernandez <jfern...@igalia.com>

Gerrit-CC: Jerome Jiang <ji...@chromium.org>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Josh Karlin <jka...@chromium.org>

Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>

Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Kevin McNee <mc...@chromium.org>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: Lei Zhang <the...@chromium.org>

Gerrit-CC: Lin, Wanming <wanmi...@intel.com>

Gerrit-CC: Linyu He <lin...@google.com>

Gerrit-CC: Mandy, Arnaud <arnaud...@intel.com>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Mark Schillaci <mschi...@google.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Michael Moss <mm...@chromium.org>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>

Gerrit-CC: Moe Adel <ad...@google.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Neil Coronado <ne...@google.com>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Nico Weber <tha...@chromium.org>

Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Per Åhgren <pe...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Peter Collingbourne <p...@chromium.org>

Gerrit-CC: Peter Williamson <pet...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Reid Kleckner <r...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Ryan Sultanem <rs...@google.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sam Zackrisson <sa...@chromium.org>

Gerrit-CC: Sean Maher <sp...@chromium.org>

Gerrit-CC: Sharon Yang <yangs...@igalia.com>

Gerrit-CC: Shu Yang <shu...@google.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Sinan Sahin <sinan...@google.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Thorsten Kober <thor...@google.com>

Gerrit-CC: Tommy Li <tomm...@chromium.org>

Gerrit-CC: Urvang Joshi <urv...@chromium.org>

Gerrit-CC: Wang, Wei4 <wei4...@intel.com>

Gerrit-CC: Xida Chen <xida...@chromium.org>

Gerrit-CC: Yao Xiao <yao...@chromium.org>

Gerrit-CC: Zewen Li <zew...@google.com>

Gerrit-CC: Zhe Su <su...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: kokoro <noreply...@google.com>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Comment-Date: Fri, 19 Jun 2026 02:40:05 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Takuto Ikuta (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar and Jatin Mittal

Takuto Ikuta removed chrome-b...@google.com from this change

Deleted Reviewers:

• chrome-b...@google.com

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Jatin Mittal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteReviewer

[Greg Thompson (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar and Jatin Mittal

Greg Thompson removed grt+...@chromium.org from this change

Deleted Reviewers:

• grt+...@chromium.org

[Adam Rice (Gerrit)]

Attention needed from Himanshu Panwar and Jatin Mittal

Adam Rice voted and added 6 comments

Votes added by Adam Rice

Code-Review

+1

6 comments

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Adam Rice . resolved

lgtm with nits

File net/http/http_util.h

Line 83, Patchset 9 (Latest): bool allow_whitespace);

Adam Rice . unresolved

Are you going to add a use of this function with `allow_whitespace` set to false?

File net/http/http_util.cc

Line 237, Patchset 9 (Latest):std::optional<HttpByteRange> HttpUtil::ParseFetchSingleRange(

Adam Rice . unresolved

It's good to add a fuzzer when adding a new parser. This is very easy with the `FUZZ_TEST` macro: see https://chromium.googlesource.com/chromium/src/+/HEAD/testing/libfuzzer/getting_started.md

Line 244, Patchset 9 (Latest): size_t pos = kBytesUnit.size();

Adam Rice . unresolved

Nit: you can make a string parser more obviously correct by having a `std::string_view` variable that contains the parts of the string you haven't yet parsed, and removing chunks from the strong with the `remove_prefix()` method as you consume them. If you use high-level methods like `find_first_not_of()` you can avoid subscripting, and bounds checks can be replaced with `!remaining_input.empty()` checks. See https://source.chromium.org/chromium/chromium/src/+/main:net/third_party/uri_template/uri_template.cc;drc=362dbaf3c1048a93929fff003e784d537f3ebfbc;bpv=1;bpt=1;l=167?gsn=Expand&gs=KYTHE%3A%2F%2Fkythe%3A%2F%2Fchromium.googlesource.com%2Fcodesearch%2Fchromium%2Fsrc%2F%2Fmain%3Flang%3Dc%252B%252B%3Fpath%3Dnet%2Fthird_party%2Furi_template%2Furi_template.cc%23jarBFsW_57seV6_jeOna5zFFWAA5nzNowIAXLd5OK5Afor an example of this technique.

This parser is simple enough that you don't need to do this, unless you want to.

Line 305, Patchset 9 (Latest): std::optional<HttpByteRange> candidate_range;
if (!range_start) {
candidate_range = HttpByteRange::Suffix(*range_end);
} else if (range_end) {
candidate_range = HttpByteRange::Bounded(*range_start, *range_end);
} else {
candidate_range = HttpByteRange::RightUnbounded(*range_start);
}
return candidate_range;

Adam Rice . unresolved

Why not do:

```suggestion
  if (!range_start) {
    return HttpByteRange::Suffix(*range_end);
  }
  if (!range_end) {
    return HttpByteRange::RightUnbounded(*range_start);
  }
  return HttpByteRange::Bounded(*range_start, *range_end);
```
?

File net/http/http_util_unittest.cc

Line 1243, Patchset 9 (Latest): "bytes=5-10 ",

Adam Rice . unresolved

Also good to test that we reject multiple ranges, and that extra '=' or '-' are rejected:
```
"bytes=0-10,15-20",
"bytes==0-5",
"bytes=0--5",
"bytes="0-5-",
"bytes="-0-5",
```

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar
• Jatin Mittal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Comment-Date: Wed, 24 Jun 2026 19:41:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Jatin Mittal (Gerrit)]

Attention needed from Himanshu Panwar

Jatin Mittal added 5 comments

File net/http/http_util.h

Line 83, Patchset 9 (Latest): bool allow_whitespace);

Adam Rice . resolved

Are you going to add a use of this function with `allow_whitespace` set to false?

Jatin Mittal

I am planning to use allow_whitespace=false for the Fetch CORS-safelisted Range header check. The Fetch spec explicitly defines parsing a single range header with an allowWhitespace boolean ("To parse a single range header value from a byte sequence value and a boolean allowWhitespace, run these steps:"), so this parser is intended to be reused for that validation.

Today, the CORS Range check in services/network/public/cpp/cors/cors.cc is implemented on top of the lenient ParseRangeHeader, with additional validation for LWS/comma handling, single-range enforcement, and suffix-range exclusion. The strict parser is intended to replace this hand-rolled validation.

Since this affects observable CORS behavior, I'd prefer to make that migration in a dedicated follow-up CL with appropriate CORS/WPT coverage rather than expand the scope of this parser CL.

Spec links:
CORS-safelisted request-header (the range case, allowWhitespace = false):
  https://fetch.spec.whatwg.org/#cors-safelisted-request-header
The shared parser this CL implements (parse a single range header value,
  takes an allowWhitespace boolean):
  https://fetch.spec.whatwg.org/#simple-range-header-value

File net/http/http_util.cc

Line 237, Patchset 9 (Latest):std::optional<HttpByteRange> HttpUtil::ParseFetchSingleRange(

Adam Rice . resolved

It's good to add a fuzzer when adding a new parser. This is very easy with the `FUZZ_TEST` macro: see https://chromium.googlesource.com/chromium/src/+/HEAD/testing/libfuzzer/getting_started.md

Jatin Mittal

Done. Added a `FUZZ_TEST` for `ParseFetchSingleRange` that fuzzes both the input string and the `allow_whitespace` flag, ensuring the parser never crashes. Also registered it in `net/BUILD.gn` under the `net_unittests` fuzztests list.

Line 244, Patchset 9 (Latest): size_t pos = kBytesUnit.size();

Adam Rice . resolved

Nit: you can make a string parser more obviously correct by having a `std::string_view` variable that contains the parts of the string you haven't yet parsed, and removing chunks from the strong with the `remove_prefix()` method as you consume them. If you use high-level methods like `find_first_not_of()` you can avoid subscripting, and bounds checks can be replaced with `!remaining_input.empty()` checks. See https://source.chromium.org/chromium/chromium/src/+/main:net/third_party/uri_template/uri_template.cc;drc=362dbaf3c1048a93929fff003e784d537f3ebfbc;bpv=1;bpt=1;l=167?gsn=Expand&gs=KYTHE%3A%2F%2Fkythe%3A%2F%2Fchromium.googlesource.com%2Fcodesearch%2Fchromium%2Fsrc%2F%2Fmain%3Flang%3Dc%252B%252B%3Fpath%3Dnet%2Fthird_party%2Furi_template%2Furi_template.cc%23jarBFsW_57seV6_jeOna5zFFWAA5nzNowIAXLd5OK5Afor an example of this technique.

This parser is simple enough that you don't need to do this, unless you want to.

Jatin Mittal

Thank you for the suggestion and for sharing the parsing pattern. I'll leave the implementation as-is for this CL, since, as you noted, the parser is simple enough that it doesn't require this approach. The current implementation keeps all accesses bounds-checked via the in_bounds() helper, and it is covered by both the unit tests and the new fuzzer, so I'd prefer to avoid refactoring the already-reviewed parsing logic for a stylistic change

Line 305, Patchset 9 (Latest): std::optional<HttpByteRange> candidate_range;
if (!range_start) {
candidate_range = HttpByteRange::Suffix(*range_end);
} else if (range_end) {
candidate_range = HttpByteRange::Bounded(*range_start, *range_end);
} else {
candidate_range = HttpByteRange::RightUnbounded(*range_start);
}
return candidate_range;

Adam Rice . resolved

Why not do:

```suggestion
  if (!range_start) {
    return HttpByteRange::Suffix(*range_end);
  }
  if (!range_end) {
    return HttpByteRange::RightUnbounded(*range_start);
  }
  return HttpByteRange::Bounded(*range_start, *range_end);
```
?

Jatin Mittal

Good suggestion. Updated to use early returns and dropped the temporary `std::optional`.

File net/http/http_util_unittest.cc

Line 1243, Patchset 9 (Latest): "bytes=5-10 ",

Adam Rice . resolved

Also good to test that we reject multiple ranges, and that extra '=' or '-' are rejected:
```
"bytes=0-10,15-20",
"bytes==0-5",
"bytes=0--5",
"bytes="0-5-",
"bytes="-0-5",
```

Jatin Mittal

Done. Added test cases for multiple ranges (`bytes=0-10,15-20`) and invalid extra `=`/`-` delimiters (`bytes==0-5`, `bytes=0--5`, `bytes=0-5-`, and `bytes=-0-5`).

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Gerrit-Comment-Date: Fri, 26 Jun 2026 11:59:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Mike Taylor (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar, Jatin Mittal, Rakina Zata Amni and Takashi Toyoshima

Mike Taylor voted and added 1 comment

Votes added by Mike Taylor

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Mike Taylor . resolved

third_party/blink/renderer/platform/runtime_enabled_features.json5 LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Jatin Mittal

• Rakina Zata Amni
• Takashi Toyoshima

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 10

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Jun 2026 13:03:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Mike Taylor (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar, Jatin Mittal, Rakina Zata Amni and Takashi Toyoshima

Mike Taylor added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Mike Taylor . unresolved

I just noticed there's 500 people in CC? That doesn't seem right... did an agent do that?

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Jatin Mittal
• Rakina Zata Amni
• Takashi Toyoshima

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Gerrit-Comment-Date: Fri, 26 Jun 2026 13:04:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jatin Mittal (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar, Jatin Mittal and Rakina Zata Amni

Jatin Mittal removed Takashi Toyoshima from this change

Deleted Reviewers:

• Takashi Toyoshima

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Jatin Mittal
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteReviewer

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 10

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

[Jatin Mittal (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar and Rakina Zata Amni

Jatin Mittal added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Mike Taylor . resolved

I just noticed there's 500 people in CC? That doesn't seem right... did an agent do that?

Jatin Mittal

Yes, Mike. That happened during a rebase. I noticed it afterward and tried to clean it up, but I couldn't find an option to remove all of the CCs at once.
I'll take extra care going forward to ensure it doesn't happen again.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Jun 2026 13:11:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mike Taylor <mike...@chromium.org>

[Adam Rice (Gerrit)]

Attention needed from Himanshu Panwar, Jatin Mittal and Rakina Zata Amni

Adam Rice added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 930, Patchset 10 (Latest): // Kill switch for Fetch-compliant Range header validation on blob: URLs.

Adam Rice . unresolved

Sorry, I mistakenly assumed the cost was in Blink. Since the feature is not in Blink, it is wasteful (and an encapsulation violation) to define it here, and you should define i in storage/browser/blob/features.h instead.

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar
• Jatin Mittal
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Jun 2026 13:41:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mike Taylor (Gerrit)]

Attention needed from Himanshu Panwar, Jatin Mittal and Rakina Zata Amni

Mike Taylor voted Code-Review+0

Code-Review

+0

Gerrit-Comment-Date: Fri, 26 Jun 2026 14:02:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Jatin Mittal (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar and Rakina Zata Amni

Jatin Mittal added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 930, Patchset 10: // Kill switch for Fetch-compliant Range header validation on blob: URLs.

Adam Rice . resolved

Sorry, I mistakenly assumed the cost was in Blink. Since the feature is not in Blink, it is wasteful (and an encapsulation violation) to define it here, and you should define i in storage/browser/blob/features.h instead.

Jatin Mittal

Done, I've updated it. Thanks for the clarification, and sorry for the oversight. I'm still getting familiar with the repository structure, and I'll make sure to pay closer attention to this in the future.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 11

Gerrit-CC: Sharon Yang <yangs...@igalia.com>

Gerrit-CC: Shu Yang <shu...@google.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Sinan Sahin <sinan...@google.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Thorsten Kober <thor...@google.com>

Gerrit-CC: Tommy Li <tomm...@chromium.org>

Gerrit-CC: Urvang Joshi <urv...@chromium.org>

Gerrit-CC: Wang, Wei4 <wei4...@intel.com>

Gerrit-CC: Xida Chen <xida...@chromium.org>

Gerrit-CC: Yao Xiao <yao...@chromium.org>

Gerrit-CC: Zewen Li <zew...@google.com>

Gerrit-CC: Zhe Su <su...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: kokoro <noreply...@google.com>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Jun 2026 15:34:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Jatin Mittal (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar and Rakina Zata Amni

Jatin Mittal voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I8abf9ce8263dd3b2db2e43e728855be09338cee5

Gerrit-Change-Number: 7902659

Gerrit-PatchSet: 11

Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>

Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>

Gerrit-Comment-Date: Sat, 27 Jun 2026 10:32:00 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes