web-bluetooth: Add deprecation warning to writeValue() [chromium/src : main]
0 views
Skip to first unread message
Giovanni Ortuno Urquidi (Gerrit)
Oct 13, 2025, 2:42:42 PM (2 days ago) Oct 13
to Giovanni Ortuno Urquidi, Matt Reynolds, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Matt Reynolds
Giovanni Ortuno Urquidi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Giovanni Ortuno Urquidi
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Matt Reynolds
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reynolds (Gerrit)
Oct 14, 2025, 6:19:17 PM (yesterday) Oct 14
to Giovanni Ortuno Urquidi, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Giovanni Ortuno Urquidi
Matt Reynolds added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/frame/deprecation/deprecation.json5
Line 581, Patchset 3 (Latest):
message: "`BluetoothRemoteGATTCharacteristic.writeValue()` is deprecated. Use `writeValueWithResponse()` or `writeValueWithoutResponse()` instead.",Matt Reynolds . unresolved
I expect developers will want more information about the plans to deprecate this method, but currently there's nowhere to go to find that information. Please create a chromestatus.com entry for this deprecation and add its `chrome_status_feature` value to the deprecation.json5 entry.
Related details
Attention is currently required from:
- Giovanni Ortuno Urquidi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
10:49 AM (10 hours ago) 10:49 AM
to Giovanni Ortuno Urquidi, Matt Reynolds, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Matt Reynolds
Giovanni Ortuno Urquidi added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/frame/deprecation/deprecation.json5
Line 581, Patchset 3:
message: "`BluetoothRemoteGATTCharacteristic.writeValue()` is deprecated. Use `writeValueWithResponse()` or `writeValueWithoutResponse()` instead.",Matt Reynolds . resolved
I expect developers will want more information about the plans to deprecate this method, but currently there's nowhere to go to find that information. Please create a chromestatus.com entry for this deprecation and add its `chrome_status_feature` value to the deprecation.json5 entry.
Attention is currently required from:
- Matt Reynolds
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reynolds (Gerrit)
1:45 PM (7 hours ago) 1:45 PM
to Giovanni Ortuno Urquidi, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Giovanni Ortuno Urquidi
Matt Reynolds added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_characteristic.idl
Line 20, Patchset 4 (Latest):
[CallWith=ScriptState, RaisesException, MeasureAs=WebBluetoothRemoteCharacteristicWriteValue, DeprecateAs=WebBluetoothRemoteCharacteristicWriteValue] Promise<undefined> writeValue([PassAsSpan] BufferSource value);Matt Reynolds . unresolved
Deprecation docs strongly suggest adding a test for the deprecation issue:
Can you check if it's possible to write a test for this deprecation? I think the WebDriver bidi interface is built out enough that we should be able to do this now. But, I don't see any other bidi inspector-protocol tests so there may be some blocker I'm not aware of.
Related details
Attention is currently required from:
- Giovanni Ortuno Urquidi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
2:00 PM (7 hours ago) 2:00 PM
to Giovanni Ortuno Urquidi, Matt Reynolds, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Matt Reynolds
Giovanni Ortuno Urquidi added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_characteristic.idl
Line 20, Patchset 4 (Latest):
[CallWith=ScriptState, RaisesException, MeasureAs=WebBluetoothRemoteCharacteristicWriteValue, DeprecateAs=WebBluetoothRemoteCharacteristicWriteValue] Promise<undefined> writeValue([PassAsSpan] BufferSource value);Matt Reynolds . resolved
Deprecation docs strongly suggest adding a test for the deprecation issue:
Can you check if it's possible to write a test for this deprecation? I think the WebDriver bidi interface is built out enough that we should be able to do this now. But, I don't see any other bidi inspector-protocol tests so there may be some blocker I'm not aware of.
Giovanni Ortuno Urquidi
I tried writing a test but I couldn't get the bluetooth test infra to work with the devtools test infra. I looked at other tests there and they are for simpler things. I tested this manually though and it seems to work.
Related details
Attention is currently required from:
- Matt Reynolds
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reynolds (Gerrit)
2:02 PM (7 hours ago) 2:02 PM
to Giovanni Ortuno Urquidi, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Giovanni Ortuno Urquidi
Matt Reynolds voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matt Reynolds
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Giovanni Ortuno Urquidi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
2:23 PM (7 hours ago) 2:23 PM
to Giovanni Ortuno Urquidi, Matt Reynolds, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Giovanni Ortuno Urquidi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Giovanni Ortuno Urquidi
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Giovanni Ortuno Urquidi . resolved
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
2:24 PM (7 hours ago) 2:24 PM
to Giovanni Ortuno Urquidi, Ari Chivukula, Matt Reynolds, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Ari Chivukula
Giovanni Ortuno Urquidi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Giovanni Ortuno Urquidi
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Giovanni Ortuno Urquidi . resolved
arichiv: PTAL at deprecation.json5
Related details
Attention is currently required from:
- Ari Chivukula
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
2:41 PM (6 hours ago) 2:41 PM
to Giovanni Ortuno Urquidi, Matt Reynolds, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Giovanni Ortuno Urquidi
Ari Chivukula added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Ari Chivukula . resolved
Can a test be added like https://chromium-review.googlesource.com/c/chromium/src/+/6440921
Related details
Attention is currently required from:
- Giovanni Ortuno Urquidi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages