Skip multicol block-size calculation for table cells. [chromium/src : main]
0 views
Skip to first unread message
Morten Stenshorne (Gerrit)
Jun 27, 2022, 2:43:30 PM6/27/22
to atotic+...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Alison Maher, chromium...@chromium.org
Attention is currently required from: Alison Maher.
To view, visit change 3726071. To unsubscribe, or for help writing mail filters, visit settings.
Morten Stenshorne (Gerrit)
Jun 27, 2022, 2:43:31 PM6/27/22
to Alison Maher, atotic+...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org
Attention is currently required from: Alison Maher.
Morten Stenshorne would like Alison Maher to review this change.
Skip multicol block-size calculation for table cells.
Table cell sizing is special, and if a table cell is also a multicol
container, skip the manual multicol-specific pre-layout sizing, as that
only messes up things.
Add some tests. Note that only table-cell-multicol-nested-002.html was
failing without this CL, but they all prove that we need to apply outer
fragmentation context constraints before bailing.
Bug: 1335873
Change-Id: I7a0b1c1428a01e67df1d782d5028136d8d8fb5e5
---
M third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm.cc
M third_party/blink/web_tests/TestExpectations
A third_party/blink/web_tests/external/wpt/css/css-multicol/table/table-cell-multicol-nested-001.html
A third_party/blink/web_tests/external/wpt/css/css-multicol/table/table-cell-multicol-nested-002.html
A third_party/blink/web_tests/external/wpt/css/css-multicol/table/table-cell-multicol-nested-003.html
5 files changed, 69 insertions(+), 1 deletion(-)
Blink W3C Test Autoroller (Gerrit)
Jun 27, 2022, 2:49:03 PM6/27/22
to Morten Stenshorne, atotic+...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Alison Maher, chromium...@chromium.org
Attention is currently required from: Alison Maher.
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/34610.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Alison Maher (Gerrit)
Jun 27, 2022, 2:53:21 PM6/27/22
to Morten Stenshorne, atotic+...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Blink W3C Test Autoroller, chromium...@chromium.org
Attention is currently required from: Morten Stenshorne.
Patch set 1:Code-Review +1
Morten Stenshorne (Gerrit)
Jun 27, 2022, 3:39:36 PM6/27/22
to atotic+...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Alison Maher, Blink W3C Test Autoroller, chromium...@chromium.org
Attention is currently required from: Morten Stenshorne.
Patch set 2:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Jun 27, 2022, 5:43:26 PM6/27/22
to Morten Stenshorne, atotic+...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Alison Maher, Blink W3C Test Autoroller, chromium...@chromium.org
Chromium LUCI CQ submitted this change.
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Approvals:
Alison Maher: Looks good to me
Morten Stenshorne: Commit
Skip multicol block-size calculation for table cells.
Table cell sizing is special, and if a table cell is also a multicol
container, skip the manual multicol-specific pre-layout sizing, as that
only messes up things.
Add some tests. Note that only table-cell-multicol-nested-002.html was
failing without this CL, but they all prove that we need to apply outer
fragmentation context constraints before bailing.
Bug: 1335873
Change-Id: I7a0b1c1428a01e67df1d782d5028136d8d8fb5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3726071
Reviewed-by: Alison Maher <alm...@microsoft.com>
Commit-Queue: Morten Stenshorne <mste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1018416}
---
M third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm.cc
M third_party/blink/web_tests/TestExpectations
A third_party/blink/web_tests/external/wpt/css/css-multicol/table/table-cell-multicol-nested-001.html
A third_party/blink/web_tests/external/wpt/css/css-multicol/table/table-cell-multicol-nested-002.html
A third_party/blink/web_tests/external/wpt/css/css-multicol/table/table-cell-multicol-nested-003.html
5 files changed, 73 insertions(+), 1 deletion(-)
Blink W3C Test Autoroller (Gerrit)
Jun 27, 2022, 6:10:09 PM6/27/22
to Morten Stenshorne, Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Alison Maher, chromium...@chromium.org
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/34610
Reply all
Reply to author
Forward
0 new messages