LoAF: durations fix [chromium/src : main]
0 views
Skip to first unread message
Noam Rosenthal (Gerrit)
7:20 AM (2 hours ago) 7:20 AM
to Yoav Weiss (@Shopify), android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Attention needed from Yoav Weiss (@Shopify)
Noam Rosenthal added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Noam Rosenthal . resolved
Looks good, but could use with a proper commit message maybe? :)
Related details
Attention is currently required from:
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
7:29 AM (2 hours ago) 7:29 AM
to Yoav Weiss (@Shopify), android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Attention needed from Yoav Weiss (@Shopify)
Noam Rosenthal voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
7:32 AM (2 hours ago) 7:32 AM
to Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Yoav Weiss (@Shopify) voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
7:39 AM (2 hours ago) 7:39 AM
to Yoav Weiss (@Shopify), Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59141.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
7:50 AM (2 hours ago) 7:50 AM
to Yoav Weiss (@Shopify), Blink W3C Test Autoroller, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
LoAF: durations fix
See bug for details.
Bug: 502073069
Change-Id: I39b9328f87899b9f302c3d3fe36aaa7d5dc90010
Reviewed-by: Noam Rosenthal <nrose...@google.com>
Commit-Queue: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1613631}
Files:
- M third_party/blink/renderer/core/timing/performance_long_animation_frame_timing.cc
- M third_party/blink/renderer/core/timing/performance_long_animation_frame_timing.h
- M third_party/blink/renderer/core/timing/performance_script_timing.cc
- M third_party/blink/renderer/core/timing/performance_script_timing.h
- M third_party/blink/web_tests/external/wpt/long-animation-frame/loaf-script-nested-callback.html
- M third_party/blink/web_tests/external/wpt/long-animation-frame/resources/utils.js
Change size: M
Delta: 6 files changed, 39 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Noam Rosenthal
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages