[Masonry] Ignore auto-placement cursor when finding track openings in [chromium/src : main]
0 views
Skip to first unread message
Celeste Pan (Gerrit)
Sep 23, 2025, 2:34:38 PM (2 days ago) Sep 23
to Alison Maher, Kurt Catti-Schmidt, Hoch Hochkeppel, Yanling Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Alison Maher and Kurt Catti-Schmidt
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alison Maher
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kurt Catti-Schmidt (Gerrit)
Sep 23, 2025, 6:03:56 PM (2 days ago) Sep 23
to Celeste Pan, Alison Maher, Hoch Hochkeppel, Yanling Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Alison Maher and Celeste Pan
Kurt Catti-Schmidt voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alison Maher
- Celeste Pan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Celeste Pan (Gerrit)
Sep 23, 2025, 8:19:21 PM (2 days ago) Sep 23
to Kurt Catti-Schmidt, Alison Maher, Hoch Hochkeppel, Yanling Wang, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Alison Maher
Celeste Pan voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Alison Maher
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 23, 2025, 9:18:15 PM (2 days ago) Sep 23
to Celeste Pan, Kurt Catti-Schmidt, Alison Maher, Hoch Hochkeppel, Yanling Wang, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Masonry] Ignore auto-placement cursor when finding track openings in
Per the resolution here:
https://github.com/w3c/csswg-drafts/pull/12807#event-19756655852 ignore
the auto-placement cursor when searching for openings in dense-packing.
This change also updates tests to no longer prioritize track openings
closest after the auto-placement cursor.
Bug: 343257585
Change-Id: I7e6fe5f52298b532af5feeaf2fa70f362cca6945
Reviewed-by: Kurt Catti-Schmidt <ksc...@microsoft.com>
Commit-Queue: Celeste Pan <celes...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1519720}
Files:
- M third_party/blink/renderer/core/layout/masonry/masonry_running_positions.cc
- M third_party/blink/web_tests/wpt_internal/css/css-masonry/column-dense-packing-002-ref.html
- M third_party/blink/web_tests/wpt_internal/css/css-masonry/column-dense-packing-multi-span-002-ref.html
- M third_party/blink/web_tests/wpt_internal/css/css-masonry/row-dense-packing-002-ref.html
- M third_party/blink/web_tests/wpt_internal/css/css-masonry/row-dense-packing-multi-span-002-ref.html
Change size: M
Delta: 5 files changed, 34 insertions(+), 46 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kurt Catti-Schmidt
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Maher (Gerrit)
Sep 24, 2025, 2:55:16 PM (yesterday) Sep 24
to Celeste Pan, Chromium LUCI CQ, Kurt Catti-Schmidt, Hoch Hochkeppel, Yanling Wang, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Celeste Pan
Alison Maher added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Alison Maher . resolved
One minor thought on the explicit position case, but can be done in a separate change if it makes sense
File third_party/blink/renderer/core/layout/masonry/masonry_running_positions.cc
Line 167, Patchset 3 (Latest):
// Find the highest eligible opening iterating from the auto-placement cursorAlison Maher . unresolved
This comment is no longer accurate (can be updated in a follow up)
Line 180, Patchset 3 (Latest):
(!masonry_item.is_auto_placed && item_span != initial_span)) {Alison Maher . unresolved
Relooking at this case, I think what would be simpler is to break this out and do:
if (!masonry_item.is_auto_placed && item_span != initial_span)
break;
}
Otherwise, we will essentially just loop through till the end line, when all we needed to do was check the current span
Related details
Attention is currently required from:
- Celeste Pan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Celeste Pan (Gerrit)
12:54 PM (9 hours ago) 12:54 PM
to Chromium LUCI CQ, Kurt Catti-Schmidt, Alison Maher, Hoch Hochkeppel, Yanling Wang, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Celeste Pan added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/layout/masonry/masonry_running_positions.cc
Line 167, Patchset 3 (Latest):
// Find the highest eligible opening iterating from the auto-placement cursorAlison Maher . resolved
This comment is no longer accurate (can be updated in a follow up)
Celeste Pan
Done
Line 180, Patchset 3 (Latest):
(!masonry_item.is_auto_placed && item_span != initial_span)) {Alison Maher . resolved
Relooking at this case, I think what would be simpler is to break this out and do:
if (!masonry_item.is_auto_placed && item_span != initial_span)
break;
}Otherwise, we will essentially just loop through till the end line, when all we needed to do was check the current span
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages