[anchor] Make the anchor attribute add position-anchor:auto [chromium/src : main]
0 views
Skip to first unread message
Ian Kilpatrick (Gerrit)
5:33 PM (6 hours ago) 5:33 PM
to chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Ian Kilpatrick voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
5:34 PM (6 hours ago) 5:34 PM
to Rune Lillesveen, Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed and Rune Lillesveen
Ian Kilpatrick added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/html_element.cc
Line 328, Patchset 2 (Latest):
if (name == html_names::kAlignAttr || name == html_names::kAnchorAttr ||Ian Kilpatrick . resolved
This doesn't make sense on Element IMO e.g. SVG elements can't abspos or be anchors.
Related details
Attention is currently required from:
- Mason Freed
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
5:42 PM (5 hours ago) 5:42 PM
to Rune Lillesveen, Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed and Rune Lillesveen
Ian Kilpatrick added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/dom/element.cc
Line 3698, Patchset 2 (Latest):
if (params.new_value == keywords::kUntilFound) {Ian Kilpatrick . unresolved
Actually should the kAnchorAttr branch go down here now?
Related details
Attention is currently required from:
- Mason Freed
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages